From: Richard Guenther <richard.guenther@gmail.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: gcc@gcc.gnu.org
Subject: Re: [RFC] removing statement walking from domwalk.c?
Date: Mon, 25 May 2009 02:00:00 -0000 [thread overview]
Message-ID: <84fc9c000905241017we300da1ma3b3767d59d54a39@mail.gmail.com> (raw)
In-Reply-To: <gvbv15$5p1$1@ger.gmane.org>
On Sun, May 24, 2009 at 7:09 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
> Hi all,
>
> for my next patch to fwprop for PR33928, I need a dominator walk and I
> would have liked to use domwalk.c; however it is only for trees at the
> moment, while I need it on RTL.
>
> I was thinking therefore of removing the following fields from the
> dominator walk callbacks:
>
> BOOL_BITFIELD walk_stmts_backward : 1;
>
> void (*before_dom_children_walk_stmts) (struct dom_walk_data *,
> basic_block,
> gimple_stmt_iterator);
>
> void (*after_dom_children_walk_stmts) (struct dom_walk_data *,
> basic_block,
> gimple_stmt_iterator);
>
> (the last is unused anyway). After merging the before_stmts/after_stmts
> callbacks into one, the callbacks would be initialize_block_local_data,
> before_dom_children and after_dom_children. I would of course take care
> of adapting the current uses, which would be quite mechanical (and
> anyway there are just half a dozen).
>
> Any objections? I don't know exactly when I'll get to it, but I hope by
> the end of June.
Works for me.
Richard.
prev parent reply other threads:[~2009-05-24 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 1:50 Paolo Bonzini
2009-05-25 2:00 ` Richard Guenther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fc9c000905241017we300da1ma3b3767d59d54a39@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=bonzini@gnu.org \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).