From: Richard Guenther <richard.guenther@gmail.com>
To: Jeff Law <law@redhat.com>
Cc: Ian Lance Taylor <iant@google.com>, GCC <gcc@gcc.gnu.org>
Subject: Re: Latent bug in update_equiv_regs?
Date: Thu, 20 Aug 2009 15:11:00 -0000 [thread overview]
Message-ID: <84fc9c000908200703h380c95e8w5b416f35adec48e5@mail.gmail.com> (raw)
In-Reply-To: <4A8D519D.5020705@redhat.com>
On Thu, Aug 20, 2009 at 3:37 PM, Jeff Law<law@redhat.com> wrote:
> On 08/20/09 02:45, Richard Guenther wrote:
>>
>> It looks indeed bogus. Do you have a testcase at hand?
>>
>
> Compile the attached testcase with -O3 -mopenmp on i686-pc-linux-gnu. Find
> MAIN__.omp_fn.2 in the .expand dump.
>
> Within that function, you're looking for this sequence of insns:
>
>
>
> ;; D.3137_29 = REALPART_EXPR <.omp_data_i_55(D)->c>;
>
> (insn 242 241 0 j.f90:138 (set (reg:SF 74 [ D.3137 ])
> (mem/s:SF (plus:SI (reg/f:SI 247 [ .omp_data_i ])
> (const_int 32 [0x20])) [2 .omp_data_i_55(D)->c+0 S4 A64])) -1
> (nil))
>
> [ ... ]
>
> (insn 247 246 0 j.f90:138 (set (mem/s:SF (plus:SI (reg/f:SI 247 [
> .omp_data_i ])
> (const_int 32 [0x20])) [13 S4 A64])
> (reg:SF 351)) -1 (nil))
>
>
> This doesn't cause a libgomp testsuite failure in the mainline because
> (reg:SF 74) gets a hard reg and thus reload doesn't utilize the bogus
> REG_EQUIV note that eventually gets added to insn 242.
I suppose we are using the complex type alias-set at one place and
the component at another. My suggestion would be to handle
complex types like we do array and vector tyoes in get_alias_set,
thus assign the component alias set to the complex types.
Richard.
> Jeff
>
prev parent reply other threads:[~2009-08-20 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 0:01 Jeff Law
2009-08-20 0:24 ` Ian Lance Taylor
2009-08-20 1:20 ` Jeff Law
2009-08-20 4:48 ` Ian Lance Taylor
2009-08-20 14:03 ` Jeff Law
2009-08-20 9:48 ` Richard Guenther
2009-08-20 14:27 ` Jeff Law
2009-08-20 15:11 ` Richard Guenther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fc9c000908200703h380c95e8w5b416f35adec48e5@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=iant@google.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).