Hi David,

On 3/29/23 15:32, David Malcolm wrote:
>> $ cat pass.c 
>> #include <err.h>
>> #include <errno.h>
>> #include <limits.h>
>> #include <readpassphrase.h>
>> #include <stdlib.h>
>> #include <string.h>
>> #include <unistd.h>
>>
> 
> [...snip...]
> 
> I very briefly tried to reproduce this myself, but I suspect we've got
> different headers.

I'm on Debian Sid with libbsd-dev 0.11.7-4, and libc-dev 2.36-8.
Maybe that tells you something?

> 
>>
>>
>> Maybe I'm missing something, but I don't think falanyzer is correct
>> here.
> 
> Quite possibly.
> 
>> Should I report this in bugzilla?
> 
> Yes please.

Will do.

>  Please can you attach the preprocessed source [1] to the
> bug report(s) so that we're looking at the same code.

Sure; it's attached to this mail.  Produced with:

$ cc -Wall -Wextra pass.c $(pkgconf --cflags --libs libbsd-overlay) -fanalyzer -O3 -E > pass.c.i

 > Ideally also a
> link to godbolt.org showing the issue.

I'm not very used to godbolt, sorry.  If this email isn't enough for you,
I'll try godbolt.

> 
> Thanks
> Dave

Cheers,
Alex

> 
> [1] you can get this via -E
> 

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5