From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12348 invoked by alias); 6 Oct 2009 17:29:38 -0000 Received: (qmail 12329 invoked by uid 22791); 6 Oct 2009 17:29:36 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Oct 2009 17:29:31 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id n96HTSMl006198; Tue, 6 Oct 2009 10:29:29 -0700 Received: from pzk4 (pzk4.prod.google.com [10.243.19.132]) by wpaz37.hot.corp.google.com with ESMTP id n96HRGxD006394; Tue, 6 Oct 2009 10:29:26 -0700 Received: by pzk4 with SMTP id 4so578007pzk.32 for ; Tue, 06 Oct 2009 10:29:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.25.9 with SMTP id c9mr140587wfj.7.1254850165968; Tue, 06 Oct 2009 10:29:25 -0700 (PDT) In-Reply-To: <863b0cbf0910011437m4cb6fc4cwe99b15fcab052c82@mail.gmail.com> References: <863b0cbf0908081459u33e84018h2e2b6cf871d9be5c@mail.gmail.com> <4ABB0C77.8020700@gnu.org> <4ABB0E99.5@gnu.org> <4ABB10DF.9020906@gnu.org> <84fc9c000909240136l4702ea51h11fb78ffcf2e4f3b@mail.gmail.com> <863b0cbf0909240934q3fa6b2d2x35ec666048378221@mail.gmail.com> <863b0cbf0910011437m4cb6fc4cwe99b15fcab052c82@mail.gmail.com> Date: Tue, 06 Oct 2009 17:29:00 -0000 Message-ID: <863b0cbf0910061029t55d5c1ccn95a9303800911ba1@mail.gmail.com> Subject: Re: Request for code review - (ZEE patch : Redundant Zero extension elimination) From: Sriraman Tallam To: Richard Guenther Cc: Paolo Bonzini , Ian Lance Taylor , gcc@gcc.gnu.org, Diego Novillo , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00118.txt.bz2 Hi Richard, I was wondering if you got a chance to see if this new patch is alright= ?. Thanks, -Sriraman. On Thu, Oct 1, 2009 at 2:37 PM, Sriraman Tallam wrote: > Hi, > > =A0 =A0 =A0I moved implicit-zee.c to config/i386. Can you please take ano= ther look ? > > =A0 =A0 =A0 =A0* tree-pass.h (pass_implicit_zee): New pass. > =A0 =A0 =A0 =A0* testsuite/gcc.target/i386/zee.c: New test. > =A0 =A0 =A0 =A0* timevar.def (TV_ZEE): New. > =A0 =A0 =A0 =A0* common.opt (fzee): New flag. > =A0 =A0 =A0 =A0* config.gcc: Add implicit-zee.o for x86_64 target. > =A0 =A0 =A0 =A0* implicit-zee.c: New file, zero extension elimination pas= s. > =A0 =A0 =A0 =A0* config/i386/t-i386: Add rule for implicit-zee.o. > =A0 =A0 =A0 =A0* i386.c (optimization_options): Enable zee pass for x86_6= 4 target. > > Thanks, > -Sriraman. > > > On Thu, Sep 24, 2009 at 9:34 AM, Sriraman Tallam wr= ote: >> On Thu, Sep 24, 2009 at 1:36 AM, Richard Guenther >> wrote: >>> On Thu, Sep 24, 2009 at 8:25 AM, Paolo Bonzini wrote: >>>> On 09/24/2009 08:24 AM, Ian Lance Taylor wrote: >>>>> >>>>> We already have the hooks, they have just been stuck in plugin.c when >>>>> they should really be in the generic backend. =A0See register_pass. >>>>> >>>>> (Sigh, every time I looked at this I said "the pass control has to be >>>>> generic" but it still wound up in plugin.c.) >>>> >>>> Then I'll rephrase and say only that the pass should be in config/i386= /. >>> >>> It should also be on by default on -O[23s] I think (didn't check if it = already >>> is). =A0Otherwise it shortly will go the see lala-land. >> >> It is already on by default in O2 and higher. >> >>> >>> Richard. >>> >>>> Paolo >>>> >>> >> >