From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by sourceware.org (Postfix) with ESMTPS id F115C385AC2A; Sat, 3 Sep 2022 06:02:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F115C385AC2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=keithp.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=keithp.com Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id C19423F32FC4; Fri, 2 Sep 2022 23:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1662184949; bh=Vb113GWNtVS4c8UoAO3fvYe/yWEDuFx8XijzaxxvhtA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Iq7XuN+2mJTsQdTfugTqpeHSyxMGVCzuZwWEKvAJk1y/R/HJq4qCB7J7H92YWojwB TpRfO456EMok9s9JgW42GxACVyIkddm6iq7MxwjlVXLUB4HsKmjM6iPP0wWmVPm04q itX9VCR9YP0OU5MqSnDxt5V/k16ZNFHhirjue07ID/Pj2mZXv33j1Epl4e1dKc1nQ/ sQJVIcHdyM1lXYCFY/WB7M+CS+WBpH2zJTs8P75om5FwrL2Jj+eSsEIf76FUNAataU NR3ZPejuiYbSh4P1qFmjJERKw4PesZXEv+iRVHsFXEKOYAjBRwzC/OOC4YcBsYXqhx A2gDoLLKFLBlA== X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0qX9bx2_4XTi; Fri, 2 Sep 2022 23:02:29 -0700 (PDT) Received: from keithp.com (unknown [204.134.242.194]) by elaine.keithp.com (Postfix) with ESMTPSA id 5C2333F32F78; Fri, 2 Sep 2022 23:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1662184949; bh=Vb113GWNtVS4c8UoAO3fvYe/yWEDuFx8XijzaxxvhtA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Iq7XuN+2mJTsQdTfugTqpeHSyxMGVCzuZwWEKvAJk1y/R/HJq4qCB7J7H92YWojwB TpRfO456EMok9s9JgW42GxACVyIkddm6iq7MxwjlVXLUB4HsKmjM6iPP0wWmVPm04q itX9VCR9YP0OU5MqSnDxt5V/k16ZNFHhirjue07ID/Pj2mZXv33j1Epl4e1dKc1nQ/ sQJVIcHdyM1lXYCFY/WB7M+CS+WBpH2zJTs8P75om5FwrL2Jj+eSsEIf76FUNAataU NR3ZPejuiYbSh4P1qFmjJERKw4PesZXEv+iRVHsFXEKOYAjBRwzC/OOC4YcBsYXqhx A2gDoLLKFLBlA== Received: by keithp.com (Postfix, from userid 1000) id 358221E600C3; Fri, 2 Sep 2022 23:02:28 -0700 (PDT) From: Keith Packard To: Richard Sandiford , Keith Packard via Gcc-patches Cc: gcc@gcc.gnu.org Subject: Re: [PATCH 0/3] picolibc: Add picolibc linking help In-Reply-To: References: <20220824180426.820576-1-keithp@keithp.com> Date: Fri, 02 Sep 2022 23:02:27 -0700 Message-ID: <8735d90zd8.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Richard Sandiford writes: Thanks much for reviewing this series. I really appreciate it. > should there be a default case that raises an error for unrecognised > libcs? Command-line checking for configure isn't very tight, but we > do raise similar errors for things like invalid --enable-threads > values. Good thinking. It's way to easy to introduce a typo somewhere and have it get missed. > On balance I think it would be better to accept > --with-default-libc=3Dnewlib but set default_libc to the empty string. That also makes good sense -- leave existing configurations unchanged. > - Should we raise an error for toolchains that don't support the given > C library? It feels like we should, but I realise that could be > difficult to do. That would be nice, but it also feels like making it reliable enough to be useful would be difficult to maintain in the future, even if we did manage to make it mostly work today. > - Very minor, but in lines like: > > +#if defined(DEFAULT_LIBC) && defined(LIBC_PICOLIBC) && DEFAULT_LIBC = =3D=3D LIBC_PICOLIBC > > is LIBC_PICOLIB ever undefined? It looks like config.gcc provides > an unconditional definition. If it is always defined then: > > #if DEFAULT_LIBC =3D=3D LIBC_PICOLIB > > would be clearer. Agreed. Thanks again for taking a look; I'll send a new series with these issues fixed shortly. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAmMS7fMACgkQ2yIaaQAA ABGx7w/7B0Xm0D5jEaAUsjnsLnbjPt692R1Pv9IrDJQUmvyWNJokhn58MEVLXrCF T1qPr3Om3rhsH8Fr68PTMoXwLA7wCoGvjhGa7O0Nno2IftonZV4NPYR1XdDw2VI2 vuBSjqBSL2xRpLCsgykzXy6FvKYyWxpHHhbEBP7aHJdyvoy+E05EHze8wKO/H2Ln CjOoNbKvwfveOqRGEIbhMQSucHPIWlVBqnXKr8ZsZGal+kTNPEJS4PZ3czn5LOCQ IjjJXpG19FE0gJNfasanGBTzTnI9I940ctp5mm6c97LqyrKVGcOkEEd6hPT4XWbm 6eYREb+OUuNjXStC/WkBi6ElUB6v6fOAs58o6gq3MZfLPjCA1bh0EsevKqFkqE4v O3p9A4xTLlijVU5BcKDXDPL0HJDyaahrbUId65QqkGcmwyjzwgkiVNbMaBmi3xjS S3SbepN+6QGIjR+hBBzNH0eiraga0A7Q00Kq4C0CBxA+6FxYnKDmeUGKjh6d6il9 H4tb/7y7fzoiQo1nucgo8xD4lWKoLWKDdbu30BUPtByCiptaNT8EYiEocTdg02t8 /T9on7D4kaZk2NnfNOmq1+aY/oGmrvIwrbjm+CyQUHqmd604BpVMXqPkGfjNqZH/ KF6mlL3VWSZ8hZeSGm9Re/MugPvFl0uSe52hk1mbG1f8gNFC1qE= =qfAU -----END PGP SIGNATURE----- --=-=-=--