Re: -Wformat-security warnings generated in gcc build

[Dodji Seketeli <dodji@redhat.com>]

Prathamesh Kulkarni <bilbotheelffriend@gmail.com> writes:

>
> Shall it be correct then to replace calls to error() and friends,
> taking only format string with no-argument specifiers
> to error_at_no_args() ? (similarly we shall need warning_at_no_args,
> pedwarn_no_args, etc.)

I would guess so, yes.

>>
>> Also, you'd need to modify cp/error.c:cp_printer in a similar way, to
>> issue an internal_error each time we try to access a null test->args_ptr.
>
> Shall check for text->args_ptr be required in each case label of
> argument specifier in pp_format()
> and client-specific functions like cp_printer() ?

Yes, I think so.  Maybe you can make that a bit more maintainable by
creating a macro like those used to access text->args_ptr in cp_printer,
e.g:

    #define next_int     va_arg (*text->args_ptr, int)

In that macro, make the check for text->args_ptr before accessing it,
and then use that macro to access text->args_ptr through the function.

-- 
		Dodji