From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-65759-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28005 invoked by alias); 5 Jan 2003 23:05:12 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 27998 invoked from network); 5 Jan 2003 23:05:11 -0000
Received: from unknown (HELO egil.codesourcery.com) (66.92.14.122)
  by 209.249.29.67 with SMTP; 5 Jan 2003 23:05:11 -0000
Received: from zack by egil.codesourcery.com with local (Exim 3.36 #1 (Debian))
	id 18VJp7-0005Il-00; Sun, 05 Jan 2003 15:04:53 -0800
To: Neil Booth <neil@daikokuya.co.uk>
Cc: Diego Novillo <dnovillo@redhat.com>,  Phil Edwards <phil@jaj.com>,
	  Andreas Jaeger <aj@suse.de>,  gcc@gcc.gnu.org
Subject: Re: tree-ssa-cvs corrupt
From: Zack Weinberg <zack@codesourcery.com>
Date: Sun, 05 Jan 2003 23:07:00 -0000
In-Reply-To: <20030105210544.GA18414@daikokuya.co.uk> (Neil Booth's message
 of "Sun, 5 Jan 2003 21:05:44 +0000")
Message-ID: <8765t342qy.fsf@egil.codesourcery.com>
User-Agent: Gnus/5.090011 (Oort Gnus v0.11) Emacs/21.2 (i386-pc-linux-gnu)
References: <u81y3uqkuf.fsf@gromit.moeb>
	<20030103162912.GA12816@tornado.toronto.redhat.com>
	<20030103193535.A13114@disaster.jaj.com>
	<87hecoxdze.fsf@egil.codesourcery.com>
	<20030105202708.GA11893@tornado.toronto.redhat.com>
	<20030105210544.GA18414@daikokuya.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-01/txt/msg00240.txt.bz2

Neil Booth <neil@daikokuya.co.uk> writes:

>> > A distant voice on the wind whispers "#error ..."
>> > 
>> The wind replies "we still try to compile the file anyway ..."
>
> Yeah, #error should stop compilation like the standard requires.  I've
> never gotten round to fixing it.  CPP would need a way to stop it lexing
> any more tokens (not too hard), and a way to signal to the front end to
> not do any more work.

The trouble is that #error causes cpplib's parse_in.errors to be
bumped, but that doesn't propagate back to errorcount until
cpp_finish() is called, from c_common_finish.

We can't just change that line you quoted to

  if (errorcount || sorrycount || cpp_errors (&parse_in))

because that will screw over non-C front ends.  Ideas?

zw