From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D5C57384F025 for ; Wed, 13 Jul 2022 12:05:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5C57384F025 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-2wUy_serNRORdo0IfeEedg-1; Wed, 13 Jul 2022 08:05:49 -0400 X-MC-Unique: 2wUy_serNRORdo0IfeEedg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1071F85A587; Wed, 13 Jul 2022 12:05:49 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17326400DFA6; Wed, 13 Jul 2022 12:05:47 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy via Gcc Cc: David Malcolm , Szabolcs Nagy , libc-alpha@sourceware.org Subject: Re: Adding file descriptor attribute(s) to gcc and glibc References: <260f0b41c663133cea96eb64bd85e8ba16d8a936.camel@redhat.com> <5769682d0d17579cbd72f72a4001bfa8444b80a8.camel@redhat.com> Date: Wed, 13 Jul 2022 14:05:46 +0200 In-Reply-To: (Szabolcs Nagy via Gcc's message of "Wed, 13 Jul 2022 09:37:09 +0100") Message-ID: <877d4h1alh.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 12:05:55 -0000 * Szabolcs Nagy via Gcc: > to be honest, i'd expect interesting fd bugs to be > dynamic and not easy to statically analyze. > the use-after-unchecked-open maybe useful. i would > not expect the access direction to catch many bugs. You might be right. But I think the annotations could help to catch use-after-close errors. By the way, I think it would help us if we didn't have to special-case AT_FDCWD using inline wrappers. Thanks, Florian