From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTP id 5396C385041E
 for <gcc@gcc.gnu.org>; Thu, 10 Jun 2021 11:55:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5396C385041E
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-162-KhUH-bN5PwmKxcLhkgvDtg-1; Thu, 10 Jun 2021 07:54:59 -0400
X-MC-Unique: KhUH-bN5PwmKxcLhkgvDtg-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B9B38049C5;
 Thu, 10 Jun 2021 11:54:58 +0000 (UTC)
Received: from oldenburg.str.redhat.com (ovpn-115-60.ams2.redhat.com
 [10.36.115.60])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id C2ACF9CA0;
 Thu, 10 Jun 2021 11:54:56 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: Martin =?utf-8?Q?Li=C5=A1ka?= <mliska@suse.cz>,  Xionghu Luo
 <luoxhu@linux.ibm.com>, "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: [Patch] contrig/gcc-changelog: Check that PR in subject in in
 changelog
References: <4c1114a7-2377-99e4-d451-1a086857e991@linux.ibm.com>
 <f07ac516-ecf8-351c-8da7-52864f46bc7d@linux.ibm.com>
 <d8f865bd-00b7-79eb-6aee-044420c00fc3@suse.cz>
 <fb113efa-6d7c-7f3c-052e-9093805c5b66@codesourcery.com>
 <36a4f5c4-357a-ca1c-e7f5-ede6ff3ba445@suse.cz>
 <00b1fc7c-7dd8-a0df-9603-0af917048a4d@codesourcery.com>
Date: Thu, 10 Jun 2021 13:54:54 +0200
In-Reply-To: <00b1fc7c-7dd8-a0df-9603-0af917048a4d@codesourcery.com> (Tobias
 Burnus's message of "Thu, 10 Jun 2021 13:51:24 +0200")
Message-ID: <877dj20wa9.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc mailing list <gcc.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <mailto:gcc-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jun 2021 11:55:01 -0000

* Tobias Burnus:

> On 10.06.21 10:07, Martin Li=C5=A1ka wrote:
>> On 6/10/21 8:35 AM, Tobias Burnus wrote:
>>> One options would be to require a 'PR <comp>/<nnnnn+>' line if there is
>>> 'PRnnnnn+' in the commit title, rejecting the commit otherwise.
>>
>> Quite interesting idea! Are you willing to prepare a patch for it?
>
> Done.
>
> I was thinking of 'PRs 1234 and 4566' but it soon became too special and
> I did not want to reject valid cases (false positive), hence, I settled
> on the attached variant. (It should detect the most common issues, thus,
> I don't worry about false negatives.)
>
> OK? Comments?

Typo in commit subject: =E2=80=9Ccontrig=E2=80=9D

Thanks,
Florian