From: Richard Sandiford <richard.sandiford@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Sandra Loosemore <sandra@codesourcery.com>,
"gcc\@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: $target.h vs $target-protos.h
Date: Fri, 23 Feb 2018 18:12:00 -0000 [thread overview]
Message-ID: <878tbjwp5x.fsf@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1802191749200.32177@digraph.polyomino.org.uk> (Joseph Myers's message of "Mon, 19 Feb 2018 17:51:07 +0000")
Joseph Myers <joseph@codesourcery.com> writes:
> On Mon, 19 Feb 2018, Sandra Loosemore wrote:
>
>> On 02/19/2018 09:45 AM, Joseph Myers wrote:
>> > On Sun, 18 Feb 2018, Sandra Loosemore wrote:
>> >
>> > > Thanks, this makes sense. I think I could produce a documentation patch
>> > > that
>> > > explains that the difference is early vs late inclusion, and explains that
>> > > any
>> > > declarations involving tree or rtx types must go in $target-protos.h
>> > > because
>> > > those types are not defined when $target.h is included.
>> >
>> > That's not the case now for tree or rtx types, since they're (forward)
>> > declared in coretypes.h. It may still be the case for some types, but not
>> > those.
>>
>> OK, I think I misunderstood your previous message -- it's the
>> machine_mode-related types that have the circular dependency, but rtx and tree
>> no longer do. Is that right?
>
> The machine_mode-related types don't either (since coretypes.h includes
> insn-modes.h and machmode.h). Some types may well still have that
> dependency, but I don't know which.
The main one I remember is rtx_code, but that can only be used in
$target-protos.h when RTX_CODE is defined.
Richard
next prev parent reply other threads:[~2018-02-23 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 17:53 Sandra Loosemore
2018-02-18 19:10 ` Joseph Myers
2018-02-18 22:55 ` Sandra Loosemore
2018-02-19 16:45 ` Joseph Myers
2018-02-19 17:35 ` Sandra Loosemore
2018-02-19 17:51 ` Joseph Myers
2018-02-23 18:12 ` Richard Sandiford [this message]
2018-02-25 19:24 ` Georg-Johann Lay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tbjwp5x.fsf@linaro.org \
--to=richard.sandiford@linaro.org \
--cc=gcc@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).