From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AFE2E3858D35 for ; Tue, 26 Sep 2023 12:04:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFE2E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695729858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yUtgIvMP14UTZj8C+94Sv8kV0pX5OEHqzUYGPx/HxOA=; b=H2tShYHM/dULC0zbpK8mQ6aAQ2vYwdyRl5RV+wxxbNOkyXKRCbA/X9XYArBPxI1ytlMuMS ICW/pt0mmHVGXDD+YUXxKYH2sjHGKjfO/gBflzyEyJnhy6nnq7GQEc0qQoEHQFs4M/4qoo 37XOM4/3awlojzXPs8JRFCd6eT6I+os= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-UKbDF2sSOjKH_2rPDkMX0A-1; Tue, 26 Sep 2023 08:04:17 -0400 X-MC-Unique: UKbDF2sSOjKH_2rPDkMX0A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE4E4185A797 for ; Tue, 26 Sep 2023 12:04:16 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D32F2026D4B; Tue, 26 Sep 2023 12:04:16 +0000 (UTC) From: Florian Weimer To: Jakub Jelinek Cc: gcc@gcc.gnu.org Subject: Re: Report from the additional type errors for GCC 14 BoF at Cauldron References: <87edilpcct.fsf@oldenburg.str.redhat.com> Date: Tue, 26 Sep 2023 14:04:15 +0200 In-Reply-To: (Jakub Jelinek's message of "Tue, 26 Sep 2023 11:22:07 +0200") Message-ID: <87a5t9p2dc.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Jakub Jelinek: > On Tue, Sep 26, 2023 at 10:28:34AM +0200, Florian Weimer via Gcc wrote: >> My understanding of the consensus goes as follows: >> >> * We want to make some changes in this area for GCC 14. >> * We should do the same thing that Clang does: default to the relevant >> -Werror= options. > > I think it doesn't have to be necessarily using defaulting to -Werror=, > -Werror= involves diagnostic_classify_diagnostic etc. > It could very well be also just testing if the corresponding warning > option isn't explicitly (OPTION_SET_P) disabled and isn't explicitly > -Wno-error=OPTION and c99 or later and conditionally based on that > use error (which would print the [-W...] part though) or warning. > The former would be in system headers too, the latter wouldn't. > We need to decide what exact options we want to turn those errors (and/or > warnings) off or on, -Wno-implicit-int, -w, -Wno-error, > -Wno-error=implicit-int, ... I didn't mean to be prescriptive about implementation details, sorry. With Clang, -w and -Wno-error have no effect on those error-by-default warnings, too. And I don't think Clang supports suppressing warnings from system headers. Thanks, Florian