From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id A5462385DC3D for ; Mon, 26 Apr 2021 15:11:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A5462385DC3D IronPort-SDR: jQWsyeeFe6zLbSZ3GWi1Yty/TN1cYl+I5oRIeIO0xAM/hV62Q9Mo6V3fXytpVOOgcsLrc3TG/u VRbHxWKxAbKw== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="175832261" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="175832261" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 08:11:56 -0700 IronPort-SDR: xq256ZQXTQdveMFgoJ/SmBOiQChWOnZxziUk7VbNUXBRFvyFnL9+TvHlT01coqc59SZcKJfTst X3rfW9/hoLMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="422691159" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.54.74.11]) by fmsmga008.fm.intel.com with ESMTP; 26 Apr 2021 08:11:56 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 6AD833011E7; Mon, 26 Apr 2021 08:11:56 -0700 (PDT) From: Andi Kleen To: Jan Hubicka Cc: Xinliang David Li , "gcc\@gcc.gnu.org" , Wei Mi , Eugene Rozenfeld Subject: Re: State of AutoFDO in GCC References: <20210423165449.GC56452@kam.mff.cuni.cz> <20210423171611.GA82007@kam.mff.cuni.cz> <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> Date: Mon, 26 Apr 2021 08:11:56 -0700 In-Reply-To: <20210425190754.GA88857@kam.mff.cuni.cz> (Jan Hubicka's message of "Sun, 25 Apr 2021 21:07:54 +0200") Message-ID: <87a6plulkz.fsf@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 15:12:02 -0000 Jan Hubicka writes: > > Is there a way to get this working w/o using older perf? It's usually rather simple to fix up autofdo for new perf. I did it before here https://github.com/andikleen/autofdo/commits/perf4-3 I think it would work always if it just ignored unknown records (which is quite possible). perf adds new records now and then, but they can be usually ignored by old tools. Only the assert happy coding style in autofdo prevents it. BTW longer term my feeling is autofdo should be replaced with something like https://lists.llvm.org/pipermail/llvm-dev/2020-August/144101.html I think that would fix most of the weirdnesses in the current autofdo implementation. -Andi