From: Jim Meyering <meyering@ascend.com>
To: law@cygnus.com
Cc: drepper@cygnus.com (Ulrich Drepper), egcs@cygnus.com
Subject: Re: x*alloc optimizations
Date: Wed, 20 May 1998 08:42:00 -0000 [thread overview]
Message-ID: <87emxpcab2.fsf@eng.ascend.com> (raw)
In-Reply-To: <18727.895553279@hurl.cygnus.com>
Jeffrey A Law <law@cygnus.com> writes:
| In message < r2af8fzfwu.fsf@happy.cygnus.com >you write:
| > law@cygnus.com (Jeffrey A Law) writes:
| >
| > > I quickly scanned your patch for any problems this creates, but didn't
| > > find any. However, we should probably fix xrealloc to avoid losing if
| > > a zero sized request is made.
| >
| > But please fix this system dependent. I.e., add a configure test for
| > this non-ISO C behaviour and don't let normal systems do the same work
| > twice (since their realloc implementation again checks for NULL).
| The amount of time saved by this optimization is likely to be so
| small that it's dwarfed by the time to write an autoconf test make
| sure it does the right thing, and get it checked in. :-)
|
| IMHO, it's not worth the effort.
In case anyone decides to do this, you don't have to
write the autoconf tests; I already did it for fileutils:
ftp://alpha.gnu.org/gnu/fileutils-3.16n.tar.gz
see these files:
lib/malloc.c
lib/realloc.c
m4/malloc.m4
m4/realloc.m4
I don't know if it was worth the effort, but I'm happier :-)
next prev parent reply other threads:[~1998-05-20 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-05-16 22:35 Richard Henderson
1998-05-18 2:09 ` Jeffrey A Law
[not found] ` <25274.895468839.cygnus.egcs@hurl.cygnus.com>
1998-05-18 9:58 ` Ulrich Drepper
1998-05-18 22:49 ` Jeffrey A Law
1998-05-20 8:42 ` Jim Meyering [this message]
1998-05-18 18:06 Michael Meissner
1998-05-20 7:09 ` Jim Meyering
1998-05-20 12:48 Michael Meissner
1998-05-20 19:03 ` Ulrich Drepper
1998-05-20 19:03 Michael Meissner
1998-05-20 19:03 ` Ulrich Drepper
1998-05-21 0:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87emxpcab2.fsf@eng.ascend.com \
--to=meyering@ascend.com \
--cc=drepper@cygnus.com \
--cc=egcs@cygnus.com \
--cc=law@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).