From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3634 invoked by alias); 14 Dec 2004 18:35:01 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 3531 invoked from network); 14 Dec 2004 18:34:56 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 14 Dec 2004 18:34:56 -0000 Received: (qmail 28380 invoked from network); 14 Dec 2004 18:34:56 -0000 Received: from localhost (HELO taltos.codesourcery.com) (zack@127.0.0.1) by mail.codesourcery.com with SMTP; 14 Dec 2004 18:34:56 -0000 Received: by taltos.codesourcery.com (sSMTP sendmail emulation); Tue, 14 Dec 2004 10:34:55 -0800 To: Matt Kraai Cc: gcc@gcc.gnu.org Subject: Re: GTY and const References: <20041213203007.GA4907@localhost.localdomain> From: Zack Weinberg Date: Tue, 14 Dec 2004 18:35:00 -0000 In-Reply-To: <20041213203007.GA4907@localhost.localdomain> (Matt Kraai's message of "Mon, 13 Dec 2004 12:30:07 -0800") Message-ID: <87fz28enjk.fsf@codesourcery.com> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-12/txt/msg00521.txt.bz2 Matt Kraai writes: > Howdy, > > One of the warnings that causes PR 18176 is an assignment of a const > cpp_token * to the source member of the val union of the cpp_token > structure, which is not const. According to the uses I've found, this > member could be const, except that doing so causes warnings in > gtype-desc.c, which does not preserve the const qualifier. > > Would it be better to add a cast around the assignment or to make > the GTY code handle const members? I'd prefer that you improved gengtype. zw