From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D310A385AC19 for ; Tue, 20 Jul 2021 14:53:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D310A385AC19 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-574-LfBMZTR7OdOJ6ijggVJ--w-1; Tue, 20 Jul 2021 10:53:01 -0400 X-MC-Unique: LfBMZTR7OdOJ6ijggVJ--w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D196804150; Tue, 20 Jul 2021 14:53:00 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-73.phx2.redhat.com [10.3.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1AA919C44; Tue, 20 Jul 2021 14:52:58 +0000 (UTC) From: Florian Weimer To: gcc@gcc.gnu.org, libc-alpha@sourceware.org, qemu-devel@nongnu.org Subject: Disabling TLS address caching to help QEMU on GNU/Linux Date: Tue, 20 Jul 2021 16:52:56 +0200 Message-ID: <87im15qbp3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 14:53:04 -0000 Currently, the GNU/Linux ABI does not really specify whether the thread pointer (the address of the TCB) may change at a function boundary. Traditionally, GCC assumes that the ABI allows caching addresses of thread-local variables across function calls. Such caching varies in aggressiveness between targets, probably due to differences in the choice of -mtls-dialect=gnu and -mtls-dialect=gnu2 as the default for the targets. (Caching with -mtls-dialect=gnu2 appears to be more aggressive.) In addition to that, glibc defines errno as this: extern int *__errno_location (void) __attribute__ ((__const__)); #define errno (*__errno_location ()) And the const attribute has the side effect of caching the address of errno within the same stack frame. With stackful coroutines, such address caching is only valid if coroutines are only ever resumed on the same thread on which they were suspended. (The C++ coroutine implementation is not stackful and is not affected by this at the ABI level.) Historically, I think we took the position that cross-thread resumption is undefined. But the ABIs aren't crystal-clear on this matter. One important piece of software for GNU is QEMU (not just for GNU/Linux, Hurd development also benefits from virtualization). QEMU uses stackful coroutines extensively. There are some hard-to-change code areas where resumption happens across threads unfortunately. These increasingly cause problems with more inlining, inter-procedural analysis, and a general push towards LTO (which is also needed for some security hardening features). Should the GNU toolchain offer something to help out the QEMU developers? Maybe GCC could offer an option to disable the caching for all TLS models. glibc could detect that mode based on a new preprocessor macro and adjust its __errno_location declaration and similar function declarations. There will be a performance impact of this, of course, but it would make the QEMU usage well-defined (at the lowest levels). If this is a programming model that should be supported, then restoring some of the optimizations would be possible, by annotating context-switching functions and TLS-address-dependent functions. But I think QEMU would immediately benefit from just the simple approach that disables address caching of TLS variables. Thanks, Florian