From: Richard Sandiford <rsandifo@redhat.com>
To: Graham Stott <graham.stott@btinternet.com>
Cc: Andrew Pinski <pinskia@physics.uc.edu>,
Matt Austern <austern@apple.com>,
gcc@gcc.gnu.org
Subject: Re: Mainline bootstrap fails on powerpc-apple-darwin7.5.0 with --enable-checking=all
Date: Wed, 08 Sep 2004 21:59:00 -0000 [thread overview]
Message-ID: <87k6v4xvzi.fsf@redhat.com> (raw)
In-Reply-To: <20040908192129.49815.qmail@web86106.mail.ukl.yahoo.com> (Graham Stott's message of "Wed, 8 Sep 2004 20:21:29 +0100 (BST)")
Graham Stott <graham.stott@btinternet.com> writes:
> Yes it's a different problem, probably fallout from Richard's eariler patch
> on 2004-08-13
Me again eh? ;( Oh well. I'm really sorry for the breakage. The way
things are going, I think it's time I jumped off a cliff and left gcc
development to people who are vaguely competent. ;/
Anyway, the attached patch should fix things. It at least gets past
the rtl checking failure in genattrtab for a cross-compile.
Hmm. Maybe it's time to reconsider including rtl checking in the
default --enable-checking flags? Clearly I should be doing that
locally anyway if I'm making stupid mistakes like this.
Richard
* genattrtab.c (write_attr_case, write_const_num_delay_slots): Check
for DEFINE_PEEPHOLEs before writing out the insn name.
Index: genattrtab.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/genattrtab.c,v
retrieving revision 1.151
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.151 genattrtab.c
*** genattrtab.c 13 Aug 2004 16:43:04 -0000 1.151
--- genattrtab.c 8 Sep 2004 21:46:40 -0000
*************** write_attr_case (struct attr_desc *attr,
*** 3905,3911 ****
{
write_indent (indent);
printf ("case %d: /* %s */\n",
! ie->def->insn_code, XSTR (ie->def->def, 0));
}
}
else
--- 3905,3914 ----
{
write_indent (indent);
printf ("case %d: /* %s */\n",
! ie->def->insn_code,
! GET_CODE (ie->def->def) == DEFINE_PEEPHOLE
! ? "peephole"
! : XSTR (ie->def->def, 0));
}
}
else
*************** write_const_num_delay_slots (void)
*** 4383,4389 ****
for (ie = av->first_insn; ie; ie = ie->next)
if (ie->def->insn_code != -1)
printf (" case %d: /* %s */\n",
! ie->def->insn_code, XSTR (ie->def->def, 0));
printf (" return 0;\n");
}
}
--- 4386,4394 ----
for (ie = av->first_insn; ie; ie = ie->next)
if (ie->def->insn_code != -1)
printf (" case %d: /* %s */\n",
! GET_CODE (ie->def->def) == DEFINE_PEEPHOLE
! ? "peephole"
! : XSTR (ie->def->def, 0));
printf (" return 0;\n");
}
}
next prev parent reply other threads:[~2004-09-08 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-08 18:18 Matt Austern
2004-09-08 18:47 ` Andrew Pinski
2004-09-08 19:21 ` Graham Stott
2004-09-08 21:59 ` Richard Sandiford [this message]
2004-09-08 22:09 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k6v4xvzi.fsf@redhat.com \
--to=rsandifo@redhat.com \
--cc=austern@apple.com \
--cc=gcc@gcc.gnu.org \
--cc=graham.stott@btinternet.com \
--cc=pinskia@physics.uc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).