From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3032 invoked by alias); 8 Sep 2004 21:59:55 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 3024 invoked from network); 8 Sep 2004 21:59:54 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 8 Sep 2004 21:59:54 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i88LxlS0012909; Wed, 8 Sep 2004 17:59:47 -0400 Received: from localhost (mail@vpnuser10.surrey.redhat.com [172.16.9.10]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i88Lxk316544; Wed, 8 Sep 2004 17:59:46 -0400 Received: from rsandifo by localhost with local (Exim 3.35 #1) id 1C5ATh-0005pZ-00; Wed, 08 Sep 2004 22:59:45 +0100 To: Graham Stott Cc: Andrew Pinski , Matt Austern , gcc@gcc.gnu.org Subject: Re: Mainline bootstrap fails on powerpc-apple-darwin7.5.0 with --enable-checking=all References: <7CA4CFEA-01C7-11D9-84CB-00039351ED8A@physics.uc.edu> <20040908192129.49815.qmail@web86106.mail.ukl.yahoo.com> From: Richard Sandiford Date: Wed, 08 Sep 2004 21:59:00 -0000 In-Reply-To: <20040908192129.49815.qmail@web86106.mail.ukl.yahoo.com> (Graham Stott's message of "Wed, 8 Sep 2004 20:21:29 +0100 (BST)") Message-ID: <87k6v4xvzi.fsf@redhat.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-09/txt/msg00399.txt.bz2 Graham Stott writes: > Yes it's a different problem, probably fallout from Richard's eariler patch > on 2004-08-13 Me again eh? ;( Oh well. I'm really sorry for the breakage. The way things are going, I think it's time I jumped off a cliff and left gcc development to people who are vaguely competent. ;/ Anyway, the attached patch should fix things. It at least gets past the rtl checking failure in genattrtab for a cross-compile. Hmm. Maybe it's time to reconsider including rtl checking in the default --enable-checking flags? Clearly I should be doing that locally anyway if I'm making stupid mistakes like this. Richard * genattrtab.c (write_attr_case, write_const_num_delay_slots): Check for DEFINE_PEEPHOLEs before writing out the insn name. Index: genattrtab.c =================================================================== RCS file: /cvs/gcc/gcc/gcc/genattrtab.c,v retrieving revision 1.151 diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.151 genattrtab.c *** genattrtab.c 13 Aug 2004 16:43:04 -0000 1.151 --- genattrtab.c 8 Sep 2004 21:46:40 -0000 *************** write_attr_case (struct attr_desc *attr, *** 3905,3911 **** { write_indent (indent); printf ("case %d: /* %s */\n", ! ie->def->insn_code, XSTR (ie->def->def, 0)); } } else --- 3905,3914 ---- { write_indent (indent); printf ("case %d: /* %s */\n", ! ie->def->insn_code, ! GET_CODE (ie->def->def) == DEFINE_PEEPHOLE ! ? "peephole" ! : XSTR (ie->def->def, 0)); } } else *************** write_const_num_delay_slots (void) *** 4383,4389 **** for (ie = av->first_insn; ie; ie = ie->next) if (ie->def->insn_code != -1) printf (" case %d: /* %s */\n", ! ie->def->insn_code, XSTR (ie->def->def, 0)); printf (" return 0;\n"); } } --- 4386,4394 ---- for (ie = av->first_insn; ie; ie = ie->next) if (ie->def->insn_code != -1) printf (" case %d: /* %s */\n", ! GET_CODE (ie->def->def) == DEFINE_PEEPHOLE ! ? "peephole" ! : XSTR (ie->def->def, 0)); printf (" return 0;\n"); } }