public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Joseph S. Myers" <jsm28@cam.ac.uk>
Cc: <gcc@gnu.org>
Subject: Re: on reputation and lines and putting things places (Re: gcc branches?)
Date: Mon, 09 Dec 2002 09:40:00 -0000	[thread overview]
Message-ID: <87k7ijzlfl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0212090008540.26329-100000@kern.srcf.societies.cam.ac.uk>

>>>>> "Joseph" == Joseph S Myers <jsm28@cam.ac.uk> writes:

Joseph> That sort of problem is what *I* generally see as merge
Joseph> problems - failure to follow coding standards, especially as
Joseph> regards to documentation (including comments), when patches
Joseph> are submitted, even though the issues involved have been
Joseph> cleaned up in the tree before.

I agree.  But as you point out it's hard to keep up with all the
changes that go through.

In automake our approach has been to automate the checking of such
changes.  For instance, if we discover a new systemic error (sh and
make bugs occasionally pop up that require a sweep across all of
automake), we add a new entry to the `maintainer-check' target.  Then
you can run `make maintainer-check' to see if anything has regressed.
Maintainers are expected to keep the code maintainer-check-clean.

This is basically the same idea as poisoning identifiers in system.h.
As we've seen with warnings, if we can't automate it, there will be
regressions.

Tom

  parent reply	other threads:[~2002-12-09  7:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-02 16:58 gcc branches? Per Bothner
2002-12-02 17:04 ` Zack Weinberg
2002-12-02 17:09   ` Per Bothner
2002-12-02 17:32     ` Zack Weinberg
2002-12-02 18:03       ` Tom Lord
2002-12-06 14:43         ` Per Bothner
2002-12-07  2:40           ` Tom Lord
2002-12-07  3:11             ` Per Bothner
2002-12-07  2:34               ` Tom Lord
2002-12-07 12:50                 ` Per Bothner
2002-12-07 13:06                   ` Tom Lord
2002-12-07 15:41             ` Phil Edwards
2002-12-07 17:18               ` on reputation and lines and putting things places (Re: gcc branches?) Tom Lord
2002-12-07 20:30                 ` Tom Lord
2002-12-08 10:23                   ` on reputation and lines and putting things places (Re: gcc branche Kai Henningsen
2002-12-08 14:09                 ` on reputation and lines and putting things places (Re: gcc branches?) Stan Shebs
2002-12-08 14:45                   ` Bruce Stephens
2002-12-08 16:24                   ` Joseph S. Myers
2002-12-08 16:49                     ` on reputation and lines and putting things places (Re: gccbranches?) Joel Sherrill
2002-12-09  9:40                     ` Tom Tromey [this message]
2002-12-09 10:13                   ` on reputation and lines and putting things places (Re: gcc branches?) Tom Lord
2002-12-09 20:59                     ` Stan Shebs
2002-12-08  1:56 Robert Dewar
2002-12-08  2:24 ` Tom Lord
2002-12-08  2:48 Robert Dewar
2002-12-08  4:05 ` Tom Lord
2002-12-08  7:13 Robert Dewar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k7ijzlfl.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gcc@gnu.org \
    --cc=jsm28@cam.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).