From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19461 invoked by alias); 24 Sep 2004 01:30:53 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 19454 invoked from network); 24 Sep 2004 01:30:52 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.10) by sourceware.org with SMTP; 24 Sep 2004 01:30:52 -0000 Received: (qmail 18298 invoked from network); 24 Sep 2004 01:30:52 -0000 Received: from taltos.codesourcery.com (zack@66.92.218.83) by mail.codesourcery.com with DES-CBC3-SHA encrypted SMTP; 24 Sep 2004 01:30:52 -0000 Received: by taltos.codesourcery.com (sSMTP sendmail emulation); Thu, 23 Sep 2004 18:30:51 -0700 To: Andrew Pinski Cc: Geoffrey Keating , gcc List Subject: Re: attribute data structure rewrite References: <7CCA5E88-0DBD-11D9-921D-000A95D692F4@physics.uc.edu> From: Zack Weinberg Date: Fri, 24 Sep 2004 01:47:00 -0000 In-Reply-To: <7CCA5E88-0DBD-11D9-921D-000A95D692F4@physics.uc.edu> (Andrew Pinski's message of "Thu, 23 Sep 2004 20:05:47 -0400") Message-ID: <87r7oscv1w.fsf@codesourcery.com> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-09/txt/msg01372.txt.bz2 Andrew Pinski writes: > Shouldn't name be redefined as char* as you don't really need a full > IDENTIFIER_NODE? Or better still, as code numbers (with an identifier->number mapping through the identifier hash table - as Joseph correctly points out, the identifiers get allocated during parsing anyway). Currently we have to do string comparison to decide which attributes are which (since any attribute can be written either as "name" or as "__name__"). zw