From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id EDB153858C50; Mon, 4 Mar 2024 00:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDB153858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDB153858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709512214; cv=none; b=bD++a+lXgCxQPNy1yjwcfTPmD+PdW6SvDHA2Q+xiVaYNvJDp5zQJEyL/ITm3PwHry+r5CRnUmvazeiqlRGQcKNzOn/KonSD0A8di+Qi3Naf786FbNkbGHZt/zykOX4tPVg3YEd97tn7M8aOlUGn0VUpnOPqHaCqw3z/A/gNZ13o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709512214; c=relaxed/simple; bh=rBVdFM9yyNc+Vm1xkw6/pLOMzpdbGjk31Q6pdStWWwA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ia4klUgZLafJCG4N1/RxKhWmE9HhBgouA4+tN3N07na0ipamTzyE83G8eHBS2gY1RgdgGhzyabtjW8pVmQjgPTkwQ1/AobDolOnObKUPklEMFDApL1lr4n8z3eHRZViCl1gHGgDUUEuqXhL0BlXAqTEWFQcfVcvDUeisTNO54n8= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: Mark Wielaard Cc: Christophe Lyon , binutils@sourceware.org, GCC Mailing List , gdb-patches@sourceware.org, David Malcolm , arsen@gentoo.org, Alexandre Oliva , Thomas Schwinge Subject: Re: Help needed with maintainer-mode In-Reply-To: <20240303211541.GK13156@gnu.wildebeest.org> (Mark Wielaard's message of "Sun, 3 Mar 2024 22:15:41 +0100") Organization: Gentoo References: <20240229110039.GB18580@gnu.wildebeest.org> <72dff8ae4cc6b56208b7e7f93676debcaba900d4.camel@klomp.org> <20240303211541.GK13156@gnu.wildebeest.org> User-Agent: mu4e 1.12.0; emacs 30.0.50 Date: Mon, 04 Mar 2024 00:30:05 +0000 Message-ID: <87v862260i.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark Wielaard writes: > Hi Christophe, Hi Mark, Christophe, et. al, > > On Fri, Mar 01, 2024 at 05:32:15PM +0100, Christophe Lyon wrote: >> > > > And it was indeed done this way because that way the files are >> > > > regenerated in a reproducible way. Which wasn't the case when usin= g --enable-maintainer-mode (and autoreconfig also doesn't work). >> > > >> > > I see. So it is possibly incomplete, in the sense that it may lack >> > > some of the steps that maintainer-mode would perform? >> > > For instance, gas for aarch64 has some *opcodes*.c files that need >> > > regenerating before committing. The regeneration step is enabled in >> > > maintainer-mode, so I guess the autoregen bots on Sourceware would >> > > miss a problem with these files? >> > >> > Yes, it is certainly incomplete. But it is done this way because it is >> > my understanding that even the gcc release maintainers do the >> > automake/autoconf invocations by hand instead of running with configure >> > --enable-maintainer-mode. >>=20 >> After a discussion on IRC, I read >> https://gcc.gnu.org/wiki/Regenerating_GCC_Configuration >> which basically says "run autoreconf in every dir where there is a >> configure script" >> but this is not exactly what autoregen.py is doing. IIRC it is based >> on a script from Martin Liska, do you know/remember why it follows a >> different process? > > CCing Sam and Arsen who helped refine the autoregen.py script, who > might remember more details. We wanted a script that worked for both > gcc and binutils-gdb. And as far as I know autoreconf simply didn't > work in all directories. We also needed to skip some directories that > did contain a configure script, but that were imported (gotools, > readline, minizip). What we really need to do is, for a start, land tschwinge/aoliva's patches = [0] for AC_CONFIG_SUBDIRS. Right now, the current situation is janky and it's nowhere near idiomatic autotools usage. It is not a comfortable experience interacting with it even as someone who is familiar and happy with using autotools otherwise. I didn't yet play with maintainer-mode myself but I also didn't see much point given I knew of more fundamental problems like this. [0] https://inbox.sourceware.org/gcc-patches/oril72c4yh.fsf@lxoliva.fsfla.o= rg/ > > Cheers, > > Mark best, sam --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZeUWDV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZDKFgEAnz/fkn3WJ4rZCDFos4GotVvsq1EKXKWq8KdV FNOALjwBAL9MBp3IJJOUJQpQKg+2J1XJb0ayzAmwuWQbbIvLFQkA =aeM8 -----END PGP SIGNATURE----- --=-=-=--