From: Zack Weinberg <zack@codesourcery.com>
To: "Håkan Hjort" <hakan@safelogic.se>
Cc: Reza Roboubi <reza@linisoft.com>, gcc@gcc.gnu.org
Subject: Re: optimizations
Date: Tue, 18 Feb 2003 18:17:00 -0000 [thread overview]
Message-ID: <87vfzhwj6l.fsf@egil.codesourcery.com> (raw)
In-Reply-To: <20030218175524.GA8638@safelogic.se> =?iso-8859-1?q?(H=E5kan?= Hjort's message of "Tue, 18 Feb 2003 18:55:24 +0100")
Håkan Hjort <hakan@safelogic.se> writes:
> For Sun's Forte compiler one gets the following:
>
> main:
> save %sp,-104,%sp
> or %g0,16,%g1
> st %g1,[%fp-4]
> add %fp,-4,%o1
> or %g0,1,%o0
> call write ! params = %o0 %o1 %o2 ! Result
> or %g0,1,%o2
> ret ! Result = %i0
> restore %g0,0,%o0
>
> I.e. it just stores '16' in k before the call to write, no trace left
> of mm() or any loop, as should be.
>
> Perhaps GCC now does the same after hoisting both the load and the store?
Unfortunately not. On x86, with -O2, 3.4 20030211 produces
main:
pushl %ebp
movl %esp, %ebp
subl $24, %esp
movl $0, -4(%ebp)
andl $-16, %esp
jmp .L2
.p2align 4,,7
.L9:
incl %eax
movl %eax, -4(%ebp)
.L2:
movl -4(%ebp), %eax
cmpl $16, %eax
jne .L9
movl $1, 8(%esp)
leal -4(%ebp), %eax
movl %eax, 4(%esp)
movl $1, (%esp)
call write
leave
xorl %eax, %eax
ret
so you can see that not only is the loop still present, but the memory
write has not been sunk.
What happens at -O2 -fssa -fssa-ccp -fssa-dce is interesting:
main:
pushl %ebp
movl %esp, %ebp
subl $24, %esp
andl $-16, %esp
jmp .L2
.p2align 4,,7
.L9:
incl %eax
.L2:
cmpl $16, %eax
jne .L9
movl $1, 8(%esp)
leal -4(%ebp), %eax
movl %eax, 4(%esp)
movl $1, (%esp)
call write
leave
xorl %eax, %eax
ret
The unnecessary memory references are now gone, but the loop remains;
also you can see what may appear to be a bug at first glance -- %eax
is never initialized. This is not actually a correctness bug: no
matter what value %eax happened to have before the loop, it will leave
the loop with the value 16. However, I think you'll agree that this
is poor optimization.
RTL-SSA is, I believe, considered somewhat of a failed experiment -
the interesting work is happening on the tree-ssa branch. I do not
have that branch checked out to experiment with. Also, the loop
optimizer has been overhauled on the rtlopt branch, which again I do
not have to hand.
zw
next prev parent reply other threads:[~2003-02-18 18:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-15 23:20 optimizations Bonzini
2003-01-16 10:53 ` optimizations Reza Roboubi
2003-01-16 11:03 ` optimizations tm_gccmail
2003-01-16 12:34 ` optimizations Reza Roboubi
2003-02-18 18:13 ` optimizations Håkan Hjort
2003-02-18 18:16 ` optimizations Andrew Pinski
2003-02-18 18:17 ` Zack Weinberg [this message]
2003-02-18 18:40 ` optimizations Håkan Hjort
2003-02-19 5:02 ` optimizations David Edelsohn
2003-01-16 11:53 ` optimizations Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2003-01-14 22:58 optimizations Reza Roboubi
2003-01-15 0:15 ` optimizations Andrew Pinski
2003-01-15 5:10 ` optimizations Reza Roboubi
2003-01-15 6:31 ` optimizations Reza Roboubi
2003-01-15 17:37 ` optimizations Andrew Pinski
2003-01-15 17:46 ` optimizations Reza Roboubi
2000-03-10 1:46 Optimizations Virgil Palanciuc
1997-12-14 14:30 [EGCS] Optimizations meissner
1997-12-15 5:38 ` Optimizations Marc Lehmann
1997-12-15 11:29 ` Optimizations Dave Love
1997-12-15 15:43 ` Optimizations Marc Lehmann
[not found] ` <19971216000653.24186.cygnus.egcs@cerebro.laendle>
1997-12-23 7:51 ` Optimizations Stan Cox
1997-12-09 9:52 Optimizations David M. Ronis
1997-12-09 11:19 ` Optimizations Jeffrey A Law
1997-12-10 10:46 ` [EGCS] Optimizations Marc Lehmann
1997-12-14 5:39 ` Philipp Thomas
1997-12-14 15:14 ` Optimizations Marc Lehmann
1997-12-14 20:14 ` Optimizations Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vfzhwj6l.fsf@egil.codesourcery.com \
--to=zack@codesourcery.com \
--cc=gcc@gcc.gnu.org \
--cc=hakan@safelogic.se \
--cc=reza@linisoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).