From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 118AA38561B8 for ; Fri, 21 Oct 2022 08:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 118AA38561B8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666341620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=hLz38Ea1BYQkSfWxlq2pVD8hUhGByRE/1M+Jn6V3PZ8=; b=Zu6znmdHoxzl5+Ne1dq5g+LV/7v2ydltCtunuI1ZefYJqmCL/Z5qAbjbGAFBs0aAYAoBLL hqWHvmOcdLejuPyyG2bmhjfE8vqnwhzg/8w1cP7WuY9QmMBBE2AdM5aMl2dFM02Y4Uhj8T FW/X64kUobNKjURoSgY61/5zBdmGsCw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-CvgxJ5dLOO-nT_YjOVVDyw-1; Fri, 21 Oct 2022 04:40:18 -0400 X-MC-Unique: CvgxJ5dLOO-nT_YjOVVDyw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE73E3817A69 for ; Fri, 21 Oct 2022 08:40:17 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7113153AA for ; Fri, 21 Oct 2022 08:40:17 +0000 (UTC) From: Florian Weimer To: gcc@gcc.gnu.org Subject: C89isms in the test suite Date: Fri, 21 Oct 2022 10:40:16 +0200 Message-ID: <87wn8tbmdr.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: What should we do about these when they are not relevant to what's being tested? For example, gcc/testsuite/gcc.c-torture/execute/ieee/mzero6.c has this: int main () { if (__builtin_copysign (1.0, func (0.0 / -5.0, 10)) != -1.0) abort (); exit (0); } but no include files, so abort and exit are implicitly declared. Should we inject a header with -include with the most common declarations (which includes at least abort and exit)? Or add the missing #include directives? But the latter might not work for freestanding targets. Implicit ints and function declarations without prototypes are also common (not just for main). Other tests look like they might be intended to be built in C89 mode, e.g. gcc/testsuite/gcc.c-torture/compile/386.c, although it's not immediately obvious to me what they test. Thanks, Florian