public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Iain Sandoe <idsandoe@googlemail.com>
To: Bruno Haible <bruno@clisp.org>
Cc: GCC Development <gcc@gcc.gnu.org>
Subject: Re: remove intl/ directory?
Date: Thu, 23 Jun 2022 07:51:29 +0100	[thread overview]
Message-ID: <8EDC08C4-3680-49C3-BFEB-9DD6F5425B5E@googlemail.com> (raw)
In-Reply-To: <39868934.7CIiGjFlj5@omega>

Hi Bruno,

> On 23 Jun 2022, at 05:24, Bruno Haible <bruno@clisp.org> wrote:
> 
> Iain Sandoe wrote:

>> … although now I see some configure warnings about not being able to access build-aux (which I do not recall seeing with the previous hack - but that could be just bad memory ;) )
> 
> You can get warnings if you _move_ the gettext-runtime directory so that it
> becomes a sibling directory of 'gcc'. You should *not* get warnings if you
> create a symlink, sibling of the 'gcc' directory, to the
> gettext-20220620/gettext-runtime/ directory.

I did symlink, and agree it should work - I’ll need to try and repeat when next I have some time.
> 
>> FWIW this following snippet would be just as broken on macOS as other noted platforms - it would need auto-foo-provided shared lib extension - or the equivalent to be used.
>> …  is there any reason that all platforms with non-’so’ suffixes would not work with that change?
> 
> On macOS (with .dylib instead of .so) it would probably work.
> 
> However, AIX and HP-UX will not work, because (as I understand it) if you want
> to have a binary, say cc1, which depends on libintl, then
>  - the cc1 that accesses /usr/local/lib/libintl.$suffix
> and
>  - the cc1 that accesses /home/user/build/gcc-snap/gettext-runtime/intl/.libs/libintl.$suffix
> must necessarily be different. You cannot just install the second one in
> public locations, because it will have the wrong shared library filename
> hardcoded into it. This is why on these systems, libtool has to rebuild
> executables during "make install".

Ah, actually a similar situation might apply to the macOS case, you would either need
to build it “@rpath” and install the library in the exe’s dir or build and install it into
‘prefix’ (that puts the full pathname into the dylib, in a similar way to AIX / HP-UX).
This is also requires a bit of juggling on macOS (I have patches in flight to make all
the runtimes for GCC built with ‘@rpath’ and using embedded rpaths in exe) hopefully
for GCC-13
 … so let’s quietly forget the shared case for now...

> Anyway, you said that for GCC, the important case is to build libintl as a
> static (non-shared) library.

Yes, in a 1:1 replacement for ‘intl’ that’s the case, we can figure out shared stuff as a follow-on.

>> I think that we now need to deal with the GCC-side of the configury …
>> 
>> 1) add logic [like GMP et. al.] to specify an external source of the library (when there is no-in-tree source present)
> 
> Are you aware that gettext.m4 already introduces the configure options
>  --with-libintl-prefix[=DIR]  search for libintl in DIR/include and DIR/lib
>  --without-libintl-prefix     don't search for libintl in includedir and libdir

Hmm - the following cases:
a) there’s no gettext-runtime in the source tree and the user needs to configure —with-libintl-prefix= 
b) there is a  gettext-runtime in the source tree and the user decides to configure —with-libintl-prefix= (which will be ignored if we take the way the other in-tree builds are handled as ’status quo’
c) there is a  gettext-runtime in the source tree  and no —with-libintl-prefix= is given (we expect to pick up the in-tree build silently and automatically).

… in case (a) we’d need to arrange for the gettext macro to be called in configure, but I don’t think it will play nicely with gettext-sister .. so there’s some work needed here.
in case (b) I’m not sure what will happen - will the configure for libintl just point the variables to the install suggested?

case (c) works today.

cheers
Iain




  reply	other threads:[~2022-06-23  6:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18 17:01 Bruno Haible
2022-06-18 17:42 ` Iain Sandoe
2022-06-18 18:14   ` David Edelsohn
2022-06-19  0:53     ` Bruno Haible
2022-06-19  0:32   ` Bruno Haible
2022-06-19  8:40     ` Iain Sandoe
2022-06-19 20:15       ` Iain Sandoe
2022-06-21  2:05         ` Bruno Haible
2022-06-22 20:21           ` Iain Sandoe
2022-06-23  4:24             ` Bruno Haible
2022-06-23  6:51               ` Iain Sandoe [this message]
2022-06-23 15:40                 ` Iain Sandoe
2022-06-23 15:50                   ` Iain Sandoe
2022-06-23 15:13               ` Eric Gallager
2022-06-20 19:45 ` Eric Gallager
2022-06-21  2:09   ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8EDC08C4-3680-49C3-BFEB-9DD6F5425B5E@googlemail.com \
    --to=idsandoe@googlemail.com \
    --cc=bruno@clisp.org \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).