Bootstrap broken on i386-pc-solaris2.10

Bootstrap broken on i386-pc-solaris2.10

[Art Haas]

Hi.

I've been unable to successfully bootstrap on my i386-pc-solaris2.10 
system since this set of changes made it into the repository:

2008-05-20  Kai Tietz  <kai.tietz@onevision.com>

        * config/i386/i386-protos.h (ix86_return_in_memory): Removed.
        (ix86_i386elf_return_in_memory): Likewise.
        (ix86_i386interix_return_in_memory): Likewise.
        * config/i386/i386-interix.h (TARGET_RETURN_IN_MEMORY): Removed.
        (SUBTARGET_RETURN_IN_MEMORY): New.
        * config/i386/i386elf.h: Likewise.
        * config/i386/ptx4-i.h: Likewise.
        * config/i386/sol2-10.h: Likewise.
        * config/i386/sysv4.h: Likewise.
        * config/i386/vx-common.h: Likewise.
        * config/i386/i386.h (TARGET_RETURN_IN_MEMORY): Removed.
        * config/i386/i386.c (ix86_return_in_memory): Made static and
        make use of optional SUBTARGET_RETURN_IN_MEMORY macro.
        (ix86_i386elf_return_in_memory): Removed.
        (ix86_i386interix_return_in_memory): Removed.
        (TARGET_RETURN_IN_MEMORY): Declared within i386.c only.
        * target-def.h (TARGET_RETURN_IN_MEMORY): Remove protection
#ifdef.

Lots of warnings during the stage1 portion of the build, and once things
get into stage2 the '-Werror' flag kills the build:

{ ... snip build log ... }
/export/home/arth/gnu/gcc-0522/./prev-gcc/xgcc
-B/export/home/arth/gnu/gcc-0522/./prev-gcc/
-B/usr/local/i386-pc-solaris2.10/bin/ -c  -O2 -march=pentium4 -DIN_GCC  
-W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
-Wold-style-definition -Wmissing-format-attribute -pedantic
-Wno-long-long -Wno-variadic-macros                              
-Wno-overlength-strings -Werror   -DHAVE_CONFIG_H -DGENERATOR_FILE -I.
-Ibuild -I/export/home/arth/gnu/gcc.git/gcc
-I/export/home/arth/gnu/gcc.git/gcc/build
-I/export/home/arth/gnu/gcc.git/gcc/../include
-I/export/home/arth/gnu/gcc.git/gcc/../libcpp/include
-I/usr/local/include -I/usr/local/include
-I/export/home/arth/gnu/gcc.git/gcc/../libdecnumber
-I/export/home/arth/gnu/gcc.git/gcc/../libdecnumber/dpd
-I../libdecnumber  -o build/gensupport.o
/export/home/arth/gnu/gcc.git/gcc/gensupport.c
In file included from ./tm.h:24,
                 from /export/home/arth/gnu/gcc.git/gcc/gensupport.c:24:
/export/home/arth/gnu/gcc.git/gcc/config/i386/sol2-10.h:113:1: error:
"SUBTARGET_RETURN_IN_MEMORY" redefined
In file included from ./tm.h:18,
                 from /export/home/arth/gnu/gcc.git/gcc/gensupport.c:24:
/export/home/arth/gnu/gcc.git/gcc/config/i386/sysv4.h:28:1: error: this
is the location of the previous definition
make[3]: *** [build/gensupport.o] Error 1
make[3]: *** Waiting for unfinished jobs....
{ ... snip ...}

Art Haas

Re: Bootstrap broken on i386-pc-solaris2.10

[Kai Tietz]

Art,

2008/5/22 Art Haas <ahaas@impactweather.com>:
> Hi.
>
> I've been unable to successfully bootstrap on my i386-pc-solaris2.10
> system since this set of changes made it into the repository:
>
> 2008-05-20  Kai Tietz  <kai.tietz@onevision.com>
>
>        * config/i386/i386-protos.h (ix86_return_in_memory): Removed.
>        (ix86_i386elf_return_in_memory): Likewise.
>        (ix86_i386interix_return_in_memory): Likewise.
>        * config/i386/i386-interix.h (TARGET_RETURN_IN_MEMORY): Removed.
>        (SUBTARGET_RETURN_IN_MEMORY): New.
>        * config/i386/i386elf.h: Likewise.
>        * config/i386/ptx4-i.h: Likewise.
>        * config/i386/sol2-10.h: Likewise.
>        * config/i386/sysv4.h: Likewise.
>        * config/i386/vx-common.h: Likewise.
>        * config/i386/i386.h (TARGET_RETURN_IN_MEMORY): Removed.
>        * config/i386/i386.c (ix86_return_in_memory): Made static and
>        make use of optional SUBTARGET_RETURN_IN_MEMORY macro.
>        (ix86_i386elf_return_in_memory): Removed.
>        (ix86_i386interix_return_in_memory): Removed.
>        (TARGET_RETURN_IN_MEMORY): Declared within i386.c only.
>        * target-def.h (TARGET_RETURN_IN_MEMORY): Remove protection
> #ifdef.
>
> Lots of warnings during the stage1 portion of the build, and once things
> get into stage2 the '-Werror' flag kills the build:
>
> { ... snip build log ... }
> /export/home/arth/gnu/gcc-0522/./prev-gcc/xgcc
> -B/export/home/arth/gnu/gcc-0522/./prev-gcc/
> -B/usr/local/i386-pc-solaris2.10/bin/ -c  -O2 -march=pentium4 -DIN_GCC
> -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
> -Wold-style-definition -Wmissing-format-attribute -pedantic
> -Wno-long-long -Wno-variadic-macros
> -Wno-overlength-strings -Werror   -DHAVE_CONFIG_H -DGENERATOR_FILE -I.
> -Ibuild -I/export/home/arth/gnu/gcc.git/gcc
> -I/export/home/arth/gnu/gcc.git/gcc/build
> -I/export/home/arth/gnu/gcc.git/gcc/../include
> -I/export/home/arth/gnu/gcc.git/gcc/../libcpp/include
> -I/usr/local/include -I/usr/local/include
> -I/export/home/arth/gnu/gcc.git/gcc/../libdecnumber
> -I/export/home/arth/gnu/gcc.git/gcc/../libdecnumber/dpd
> -I../libdecnumber  -o build/gensupport.o
> /export/home/arth/gnu/gcc.git/gcc/gensupport.c
> In file included from ./tm.h:24,
>                 from /export/home/arth/gnu/gcc.git/gcc/gensupport.c:24:
> /export/home/arth/gnu/gcc.git/gcc/config/i386/sol2-10.h:113:1: error:
> "SUBTARGET_RETURN_IN_MEMORY" redefined
> In file included from ./tm.h:18,
>                 from /export/home/arth/gnu/gcc.git/gcc/gensupport.c:24:
> /export/home/arth/gnu/gcc.git/gcc/config/i386/sysv4.h:28:1: error: this
> is the location of the previous definition
> make[3]: *** [build/gensupport.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> { ... snip ...}
>
> Art Haas
>

I sent the following patch to patch-gcc for this.

Index: gcc/gcc/config/i386/sol2-10.h
===================================================================
--- gcc.orig/gcc/config/i386/sol2-10.h
+++ gcc/gcc/config/i386/sol2-10.h
@@ -110,5 +110,6 @@ along with GCC; see the file COPYING3.
 #undef TARGET_ASM_NAMED_SECTION
 #define TARGET_ASM_NAMED_SECTION i386_solaris_elf_named_section

+#undef SUBTARGET_RETURN_IN_MEMORY
 #define SUBTARGET_RETURN_IN_MEMORY(TYPE, FNTYPE) \
 	ix86_sol10_return_in_memory (TYPE, FNTYPE)

Thanks for reporting,
  Kai


-- 
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Re: Bootstrap broken on i386-pc-solaris2.10

[Art Haas]

On Thu, 2008-05-22 at 19:41, Kai Tietz wrote:
> Ok, fixed on gcc trunk revision 135776.

The patch fixed the warning error, but the bootstrap is still broken:

{ ... snip ... }
cc1: warnings being treated as errors
/export/home/arth/gnu/gcc.git/gcc/config/i386/i386.c:4845: error:
'return_in_memory_32' defined but not used
/export/home/arth/gnu/gcc.git/gcc/config/i386/i386.c:4892: error:
'return_in_memory_ms_64' defined but not used
make[3]: *** [i386.o] Error 1
make[3]: *** Waiting for unfinished jobs....
{ ... snip end of log ... }

Art Haas

Re: Bootstrap broken on i386-pc-solaris2.10

[Art Haas]

On Thu, 2008-05-22 at 21:12, Kai Tietz wrote:
> Art,
> 
> 2008/5/22 Art Haas <ahaas@impactweather.com>:
> >
> > On Thu, 2008-05-22 at 19:41, Kai Tietz wrote:
> >> Ok, fixed on gcc trunk revision 135776.
> >
> > The patch fixed the warning error, but the bootstrap is still
> broken:
> >
> > { ... snip ... }
> > cc1: warnings being treated as errors
> > /export/home/arth/gnu/gcc.git/gcc/config/i386/i386.c:4845: error:
> > 'return_in_memory_32' defined but not used
> > /export/home/arth/gnu/gcc.git/gcc/config/i386/i386.c:4892: error:
> > 'return_in_memory_ms_64' defined but not used
> > make[3]: *** [i386.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > { ... snip end of log ... }
> 
> Could you please test the attached patch. I have no solaris2 box. If
> everything works for you please let me know.

The patch worked - I've successfully built the current GCC.

Thanks!

Art Haas

Re: Bootstrap broken on i386-pc-solaris2.10

[Kai Tietz]

2008/5/23 Art Haas <ahaas@impactweather.com>:
> On Thu, 2008-05-22 at 21:12, Kai Tietz wrote:
>> Art,
>>
>> 2008/5/22 Art Haas <ahaas@impactweather.com>:
>> >
>> > On Thu, 2008-05-22 at 19:41, Kai Tietz wrote:
>> >> Ok, fixed on gcc trunk revision 135776.
>> >
>> > The patch fixed the warning error, but the bootstrap is still
>> broken:
>> >
>> > { ... snip ... }
>> > cc1: warnings being treated as errors
>> > /export/home/arth/gnu/gcc.git/gcc/config/i386/i386.c:4845: error:
>> > 'return_in_memory_32' defined but not used
>> > /export/home/arth/gnu/gcc.git/gcc/config/i386/i386.c:4892: error:
>> > 'return_in_memory_ms_64' defined but not used
>> > make[3]: *** [i386.o] Error 1
>> > make[3]: *** Waiting for unfinished jobs....
>> > { ... snip end of log ... }
>>
>> Could you please test the attached patch. I have no solaris2 box. If
>> everything works for you please let me know.
>
> The patch worked - I've successfully built the current GCC.
>
> Thanks!
>
> Art Haas
>

The patch is applyed on trunk.

Thanks,
  Kai

-- 
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination