From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 3AB25383D839 for ; Tue, 6 Jul 2021 21:44:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AB25383D839 Received: by mail-ot1-x32d.google.com with SMTP id f12-20020a056830204cb029048bcf4c6bd9so226045otp.8 for ; Tue, 06 Jul 2021 14:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5JUaA93dLhK4V1yRA6cwSL5GfjMAvBJ/v1K6pFI8mN0=; b=LcuM/ueeRBYcK4UNo8DSL9YM58G0TrJ2jYorGCCPwkpYQ4e2QYcSJQI55SDV0mIQFp 94/ejrQ6nSVuhrc8YsIrntKKs3Oi8eek7bgmITDF6AUro0HJOLHogYCVw1wuVX+SxUpn cuKhpUmDZrdtjYNQdo5W1PrugQikT2rggC5L6IBiu5z7PZZ1PDDrMIzojH9lSpWZ84w9 on1cjLioYAs0s7aoDpjFYXGAf6Hh+MUgxH2zuZLjfnc3eJc5bQFCyAcJglZpPzgoH+OB 6jmStqTkqgaOmX+/ELN6NbLkL7deMU6BWBo8nRlPzOyG37U0kcG5Ok1q1ElP75hJSt0m HmIA== X-Gm-Message-State: AOAM533eiZQJdWqIfHbhs/uVDm9NMEAB11rqaFKjxjwubdMciKuAHiys YdtF5U4xQ3NwNWFw2nzf/2OlV9ihUCQ= X-Google-Smtp-Source: ABdhPJz+oxyDSl1ENA/iE3TkYXYl3FgZQQpF9A7Sf8nUqFItPaSwme89XyEjV6S6Dxrw0ffHjwIz4A== X-Received: by 2002:a9d:4104:: with SMTP id o4mr17373654ote.139.1625607859122; Tue, 06 Jul 2021 14:44:19 -0700 (PDT) Received: from [192.168.0.41] (75-166-102-22.hlrn.qwest.net. [75.166.102.22]) by smtp.gmail.com with ESMTPSA id k24sm3742626oig.13.2021.07.06.14.44.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 14:44:18 -0700 (PDT) Subject: Re: where is PRnnnn required again? To: Marek Polacek Cc: gcc mailing list References: From: Martin Sebor Message-ID: <9121724e-e741-9bad-a39d-d6ac49422589@gmail.com> Date: Tue, 6 Jul 2021 15:44:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_LOTSOFHASH, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 21:44:21 -0000 On 7/6/21 3:36 PM, Marek Polacek wrote: > On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: >> I came away from the recent discussion of ChangeLogs requirements >> with the impression that the PRnnnn bit should be in the subject >> (first) line and also above the ChangeLog part but doesn't need >> to be repeated again in the ChangeLog entries. But my commit >> below was rejected last Friday with the subsequent error. Adding >> PR middle-end/98871 to the ChangeLog entry let me push the change: >> >> https://gcc.gnu.org/g:6feb628a706e86eb3f303aff388c74bdb29e7381 >> >> I just had the same error happen now, again with what seems like >> a valid commit message. Did I misunderstand something or has >> something changed recently? >> >> Martin >> >> commit 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 (HEAD -> master) >> Author: Martin Sebor >> Date: Fri Jul 2 16:16:31 2021 -0600 >> >> Improve warning suppression for inlined functions [PR98512]. >> >> Resolves: >> PR middle-end/98871 - Cannot silence -Wmaybe-uninitialized at >> declaration si >> te >> PR middle-end/98512 - #pragma GCC diagnostic ignored ineffective in >> conjunct >> ion with alias attribute > > This should be just > > PR middle-end/98871 > PR middle-end/98512 > > , no? Does it matter if there's text after the PR ...? I managed to push https://gcc.gnu.org/pipermail/gcc-cvs/2021-July/350316.html that uses the same style earlier today but the one below failed just a little while later. Copying the PR tree-optimization/86650 part into the ChangeLog entry fixed it (I didn't think to try without the PR summary). Enumerating objects: 10, done. Counting objects: 100% (10/10), done. Delta compression using up to 16 threads Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 1008 bytes | 1008.00 KiB/s, done. Total 6 (delta 4), reused 0 (delta 0) remote: *** The following commit was rejected by your hooks.commit-extra-checker script (status: 1) remote: *** commit: e8c83cb3d4824f85588d162e7aa58c25f8cb926b remote: *** ChangeLog format failed: remote: *** ERR: PR 86650 in subject but not in changelog: "Add test for [PR86650]." remote: *** remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs remote: *** remote: error: hook declined to update refs/heads/master To git+ssh://gcc.gnu.org/git/gcc.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'git+ssh://msebor@gcc.gnu.org/git/gcc.git' tmp$ (cd /src/gcc/master/ && git show 151b423a82f..e8c83cb3d48) commit e8c83cb3d4824f85588d162e7aa58c25f8cb926b (HEAD -> master) Author: Martin Sebor Date: Tue Jul 6 15:15:53 2021 -0600 Add test for [PR86650]. PR tree-optimization/86650 - -Warray-bounds missing inlining context gcc/testsuite/ChangeLog: * gcc.dg/Warray-bounds-76.c: New test. diff --git a/gcc/testsuite/gcc.dg/Warray-bounds-76.c b/gcc/testsuite/gcc.dg/Warray-bounds-76.c ... Martin > Either here, or... > >> gcc/ChangeLog: > > ...here. > >> * diagnostic.c (get_any_inlining_info): New. >> (update_effective_level_from_pragmas): Handle inlining context. >> (diagnostic_enabled): Same. >> (diagnostic_report_diagnostic): Same. >> * diagnostic.h (struct diagnostic_info): Add ctor. >> (struct diagnostic_context): Add new member. >> * tree-diagnostic.c (set_inlining_locations): New. >> (tree_diagnostics_defaults): Set new callback pointer. >> >> >> >> Enumerating objects: 11, done. >> Counting objects: 100% (11/11), done. >> Delta compression using up to 16 threads >> Compressing objects: 100% (6/6), done. >> Writing objects: 100% (6/6), 3.37 KiB | 3.37 MiB/s, done. >> Total 6 (delta 5), reused 0 (delta 0) >> remote: *** The following commit was rejected by your >> hooks.commit-extra-checker script (status: 1) >> remote: *** commit: 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 >> remote: *** ChangeLog format failed: >> remote: *** ERR: PR 98512 in subject but not in changelog: "Improve warning >> suppression for inlined functions [PR98512]." >> remote: *** >> remote: *** Please see: >> https://gcc.gnu.org/codingconventions.html#ChangeLogs >> remote: *** >> remote: error: hook declined to update refs/heads/master >> To git+ssh://gcc.gnu.org/git/gcc.git >> ! [remote rejected] master -> master (hook declined) >> error: failed to push some refs to >> 'git+ssh://msebor@gcc.gnu.org/git/gcc.git' >> > > Marek >