From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 274083858433 for ; Tue, 30 May 2023 23:07:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 274083858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685488058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mFqe20zn1QAtJ/V/YAM/koR4bBFHSX8MxgEiD1z3SPo=; b=dN/oYUik8RaIIMpbWXiEEKl+jdE9XIQl+HsnOBSbAMFFu9sL1BWAVtmYKYAb241aCh2eZs Ux44VnQEzs+dAzEHnGRkvQR2/Sb/GYDKA2XfGqRtx6/x/f5aoHHi2j8IuiMf3/vvivpi8D yrJ+04KLGm6Xxe0w0XpWe2gGNQJgxOU= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-q-EUEbpLNgmfYvUkYb5XZw-1; Tue, 30 May 2023 19:07:37 -0400 X-MC-Unique: q-EUEbpLNgmfYvUkYb5XZw-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-3f6afd58c32so34895901cf.3 for ; Tue, 30 May 2023 16:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685488057; x=1688080057; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mFqe20zn1QAtJ/V/YAM/koR4bBFHSX8MxgEiD1z3SPo=; b=fp+GiBf8zLun5ccbnNFw94r8plmpBsh42/38R+//wgAiqTEWif36it4JBKN76W3j3S bOqeut4exoyGjxT5ZGlsLTWTgZiNP61dj6JOK+At+jPB8298OEGUxWqnOXOf9jtH3ZXB cFCnwOM0wD8u3WA39Pl9ONXU5Pck4geHsVVKXTWRkFiITwfKx7pbCH4Jw8+0kcswcIf3 YvybpXB8kASqvjJqgQseBXUFCTywytSfJ8SRgGSFm0Dr4couzMHcd7jvRAqa7xO3bw94 SD7ASHbgYGse/bLBdiYgjDD5Myoyf5INkkXfKUw2I6/Up86LFxDTflE0Le3OHaLrTwiO Adaw== X-Gm-Message-State: AC+VfDy8jnlO2wRja4EuMgadf0j+hlqqwv6YeKT/sQ7YWsLw8lS1LRBJ N8QUug7/W99O8GwdwvwYjuiZyhD8XwnUhtGVHmco4n0VQi1QFznHqIKQrSD++KQlLAWUD6K6ZTp YeEoXLWw= X-Received: by 2002:ac8:5709:0:b0:3f6:bcda:e77 with SMTP id 9-20020ac85709000000b003f6bcda0e77mr4655368qtw.55.1685488056919; Tue, 30 May 2023 16:07:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6T8pc9wu+IQxCStgJh4PR+EUrKEyC0iQ0HXlZetPnA1taZQlL25QpMkfyb/tQKWDjQFS3uTg== X-Received: by 2002:ac8:5709:0:b0:3f6:bcda:e77 with SMTP id 9-20020ac85709000000b003f6bcda0e77mr4655352qtw.55.1685488056656; Tue, 30 May 2023 16:07:36 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id c11-20020ac853cb000000b003f72236e150sm5181505qtq.33.2023.05.30.16.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 16:07:36 -0700 (PDT) Message-ID: <93c718cd2c53b863c454312702430a42585212fd.camel@redhat.com> Subject: Re: Testing a patch From: David Malcolm To: Benjamin Priour , gcc@gcc.gnu.org Date: Tue, 30 May 2023 19:07:35 -0400 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-05-29 at 15:09 +0200, Benjamin Priour wrote: > Hi, >=20 > Regstrapping finally done for PR109439 - Spurious > -Wanalyzer-use-of-uninitialized-value tagging along > -Wanalyzer-out-of-bounds. > Now only a OOB warning is reported when necessary instead of OOB + > Use > of uninitialized value. >=20 > Some tests in analyzer (out-of-bounds-*, realloc-5, pr101962) were > checking for the now removed use-of-uninitialized-value warning, and > therefore I fixed that. >=20 > But now I'm confused since the documentation reads that to perform > regtesting, one should use make -k check, > and that's what I always use too, but because I fixed the above test > files, contrib/compare_tests obviously complains about them having > disappeared. > Does it mean regtesting failed ? If part of the purpose of a patch is the removal of certain tests, then if compare_tests is "complaining" about them disappearing, then arguably compare_tests is in fact verifying that the behavior of the patch matches the intended behavior. In this case, regression testing has effectively passed. > Can I submit the patch in its current > state or should I do something else before doing so ? Yes, please submit the patch in its current state, to gcc-patches, and CC me on it. Thanks Dave > Guess I would get feedback anyway if something's wrong. >=20 > I figured I would send it here rather than to gcc-patches, as it's > more general than a discussion over a single patch. >=20 > Thanks, > Benjamin >=20