From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by sourceware.org (Postfix) with ESMTPS id B6E6E3858C31 for ; Thu, 14 Mar 2024 15:33:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6E6E3858C31 Authentication-Results: sourceware.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cloud.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B6E6E3858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710430436; cv=none; b=p3CWCJ+Ie4xgcJSBYgjEFfg5KkTcIJtTFwtuAB5dcY7n/r3B9u29Tx97ocoqlKfcyZWcc7FsKqJOufT4dslfCuuRLStBunO0AMR6HDbocLkcnB+G0s1oXDuZYTd4yJiZ7/Te/57Yw9+hGylDAo2URpIk79qiUoUcYJF6F+/Nq5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710430436; c=relaxed/simple; bh=ISaCJZj9chqG+PW6LNyRuUHZiEPH8IF31XsiYj/3cas=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dQfYdAtpYefgNpydcpRIahJPAVCyzEFdVQIsPBhlcJHaPZNHMNIXp1CAmZ0R0z9B7+01OGhAVplk+wCTd9JdR37MTvLQEJPiF6DA17WcQhjX5gPRNKDIX/PuyMoHF1Clk4GPu+Co1C6FDYPdRw0DNT3VABMBYME8HLviov8rC3A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-690c43c5b5aso7728966d6.1 for ; Thu, 14 Mar 2024 08:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1710430434; x=1711035234; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ISaCJZj9chqG+PW6LNyRuUHZiEPH8IF31XsiYj/3cas=; b=Is00MxYjpqidJKXWcUw0YoK/0WER1KVe8kgdOOjYLAL6NzdO0t9t6hDavf/17Thyjb U62T5mWyGK5Z42mVDJw6ZLmmjFyHKLO5j4PzM1DhUdSTFVsrF5QqH+Z96WDlvr3WWCul nrIG7RAHwJZJGK0MrbRqTKK46VStwKCwqvlj0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710430434; x=1711035234; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ISaCJZj9chqG+PW6LNyRuUHZiEPH8IF31XsiYj/3cas=; b=Qii6We/yAmfZ7HYa3i/plEVKyLv/TwQG+v8L4+0uoeNRWNxudYcOJKvc2ccsVT6Rz9 l6mN0Z6u7UA+WeRkY24EAI6Dc52Ig/INzAI/27yZSYWY7tSgJTJNMlBs3WNivOXUgghB 4C17lSrQvcWtWdbLDVV2xnO/W2/CSbAuRLDnKfTmMTp7W38Mff3qd9iRHOyTDDDbmTDG RsXPrHHTxD2/998L2NPJKgcd9kloNxOcWlTc1bfO8R0TtKXLpN5w+geowCtylyZTkmA4 VhJv/eY3ECsh0cTx2sfHqqpYPnr+LhEymudYlzu/JXLBTKXh70yNydUF5W1KaYaN40Zi R4DA== X-Forwarded-Encrypted: i=1; AJvYcCXUBQGthj79WWUWhNtUltP/F9GrTeuhyV3tCxmtv6Ho8XaBDZhig7e4VbjR9kZuD6Xn8R02yD3beIGKTK7Czd4= X-Gm-Message-State: AOJu0Yx5KMSYakLtihE/SXQOrz1Y4FOXgCO/3flkR7VKmGu+hzYeesRU 1+5MM8aNFgzYkEQl1n7Rd6tYmoY3j7aB56coNQVOv7YOzESNMbC8O/ZM/9oIoD655R53b1CddKp v X-Google-Smtp-Source: AGHT+IFblWaMCYNIqiFKW1zjNUQq2mDNKgRntfj5wYGgS9HSs68QoRDm9t2eNxLm+eX0sbXe94xCZA== X-Received: by 2002:a05:6214:2b44:b0:691:1c52:692f with SMTP id jy4-20020a0562142b4400b006911c52692fmr2205425qvb.12.1710430434032; Thu, 14 Mar 2024 08:33:54 -0700 (PDT) Received: from [10.80.67.149] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id iu10-20020ad45cca000000b006914cd7a8b1sm588535qvb.48.2024.03.14.08.33.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 08:33:53 -0700 (PDT) Message-ID: <9704774f-00f9-48d4-ad27-6cd07a816359@citrix.com> Date: Thu, 14 Mar 2024 15:33:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Builtin for consulting value analysis (better ffs() code gen) Content-Language: en-GB To: Andreas Schwab , Andrew Cooper via Gcc Cc: Alexander Monakov References: <06d7af49-c4a9-43d5-a18f-266439c7f82d@citrix.com> <12b2c99d-993d-ba8d-75ff-b107de2eba67@ispras.ru> From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/03/2024 12:03 pm, Andreas Schwab wrote: > On Mär 14 2024, Andrew Cooper via Gcc wrote: > >> so any known-constant value can be folded.  What I'm dealing with is the >> remainder of the cases. > Which cases remain? None, thanks to the answers on this thread. The overall structure I've got now is: unsigned int ffs(unsigned int x) {     if ( __builtin_constant_p(x) )         return __builtin_ffs(x);  // Allows constant folding #ifndef arch_ffs #define arch_ffs __builtin_ffs #endif     return arch_ffs(x); } And for x86's arch_ffs(), unsigned int arch_ffs(unsigned int x) {     unsigned int res;     if ( __builtin_constant_p(x > 0) && x > 0 )     {         // Well defined when x is known non-zero         asm("bsf %1, %0" : "=r"(res) : "rm"(x));     }     else     {         // The architects say this is safe even for 0.         res = -1;         asm("bsf %1, %0" : "+r"(res) : "rm"(x));     }     return res + 1; } This gives the same code gen as before (give or take some register shuffling), without having to rely on the programmer to remember to get their ffs()'s separated from their __ffs()'s as it pertains to undefined input. The other architectures which have better-defined instructions don't need any of these games to retain the same good code-gen that is currently expressed with a maze of subtly-different functions. ~Andrew