From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manfred.Hollstein@ks.sel.alcatel.de To: msimons@saic1.com Cc: ghazi@caip.rutgers.edu, egcs@cygnus.com Subject: Re: egcs-980129, warning patches to alpha.c Date: Fri, 06 Feb 1998 05:56:00 -0000 Message-id: <9802061339.AA24361@lts.sel.alcatel.de> References: <199802052207.RAA21462@caip.rutgers.edu> <199802060804.DAA22841@aura.saic1.com> X-SW-Source: 1998-02/msg00232.html On Fri, 6 February 1998, 03:04:18, msimons@saic1.com wrote: > > Thu Feb 5 14:53:05 1998 Kaveh R. Ghazi > > > > (add_long_const): Use HOST_WIDE_INT_PRINT_DEC as needed. > [...] > > @@ -3246,7 +3273,9 @@ > > if (sa_size != 0) > > { > > reg_mask |= 1 << REG_RA; > > - fprintf (file, "\tstq $26,%d($%d)\n", reg_offset, sa_reg); > > + fprintf (file, "\tstq $26,"); > > + fprintf (file, HOST_WIDE_INT_PRINT_DEC, reg_offset); > > + fprintf (file, "($%d)\n", sa_reg); > > reg_offset += 8; > > int_reg_save_area_size += 8; > > } > > Kaveh, > > I just glanced at your patch, couldn't we do this: > fprintf (file, "\tstq $26," HOST_WIDE_INT_PRINT_DEC "($%d)\n", > reg_offset, sa_reg); > > it is much more condensed, the compiler will merge the strings for us. =) > This of course would only work with an ANSI C compiler; e.g. SunOS's old K&R cc will fail to concatenate string literals :-( Manfred