From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2068.outbound.protection.outlook.com [40.107.20.68]) by sourceware.org (Postfix) with ESMTPS id C66753858D32 for ; Thu, 25 May 2023 09:43:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C66753858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rr+0PJTOTa4fRNGzJJSKJ8UWcTeLbEJwTMh5bC0qS7/j/j2ZYAPZpKE/1/GwYIXILwHhIr6Knch5fuLgfOzAeegTjlofVr7EL0xRpT3nGVmwhx9Vm9cPPX/EqK4DiWHaSSwGBz9LddevKgTuocQBho2GZICPoE1qOYZ7JPxJiHageQqaG3dHsCWXcHJonp7KaVfb1jXlkGapAiMsq/QYXTokLU2p3W48r24j/wu6Hh9Qta5pq2OlcRINcYJS0r6Dlw6GTkLSJ6RR77RmtB86Kd1UMWKmlawIupb5HWDT04ndMLrjWYNiCI7YxPop1hx9PZYFUvxVAIwB3ISKmfycPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0vcf0FZ6FYhymFVshgTAvniYtdwiXh+Vl2WLRcOHH8=; b=TF8KduHKtU+2AY6GEfKwUq7ZYDF+UBJhprP8naFglFVnMiJB7FjZUrlZTT/y6+OmEfDlbI7Y3rykab2tlEpS3ejNijdxyMe9zLGeAC6sD/SYp6gjUmtVa5BtIv/1nCDm9Mj71YlCLInMvm5aMsih/nSNPBiuHms9T+aeDNWSlOX55oGcNEIe/ieiVlJwYgSczmxI2qSzirVPrnb4eCCjxjBisgY+vByoInhDxLXKQ8uLndBhwugq92CKNOdWeTOFE/TQYfVTtCc31e73WorFQjyEQcREe1/J6rAyluygtHK5w52i2gsKGxX0OPk4MVQ8F4Rwxq52M0RSFe9NCdCZ8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0vcf0FZ6FYhymFVshgTAvniYtdwiXh+Vl2WLRcOHH8=; b=Z3S9xYCgIqExp+ezpTa3ez12b2kH5UN5pj/zD/FqVtd+Zkt2tOFr5k/O+TpBzmskp73tgmsuzc1WMNjeYYO7WVxJDTZYj30ecnb1+ohFBh+HurA7kzR63kUCwc78pVm5e7mEghtIuXMTmibvoOBk6C5UPY7pILxlBv2VRfC75wWL9QmQukWIUk98G3WfbQQGNcW0azzeMdvpeEF+QqjiqggXuHffxQIUw92eTFlXT+PrXskf8MjSiwwk1ZDdKgXVvI3Y3KY5CwVejYb2avNl72vfVe9wdHMYlFGF9NZ1cv3CHpw/wURZXm5VmFkef4BxxRxrxpkav7Bb0RZm4sLBHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7175.eurprd04.prod.outlook.com (2603:10a6:20b:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Thu, 25 May 2023 09:43:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6433.016; Thu, 25 May 2023 09:43:39 +0000 Message-ID: <9c2f195e-da0d-b636-7009-15eddf7c2cba@suse.com> Date: Thu, 25 May 2023 11:43:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: x86: making better use of vpternlog{d,q} Content-Language: en-US To: Hongtao Liu Cc: "gcc@gcc.gnu.org" , Kirill Yukhin , Hongtao Liu References: <999cd9e7-c20a-2992-590e-82ef01506604@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0197.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7175:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a1ad593-a8a9-43ab-b99c-08db5d048486 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R8KU9/gij5SgVe2D8dFr+gfBe3Ee3YsyJsVAPXfMiP1qjA0ou4ObdKeVY4wycXt2Cl+uQybnt/qO2By2bJT7y8YxnqEK0N00E0XbWWEQaDyDH1o64guaNd0x5f2lHakOo401Q+IAOzbnMDO0MuHcrpKd6QTRkQFqo2GwVOFTEmLX8gVKNAopd6b7HHf5qeTzn7XSMkTteAqyYqlUkJ5iaePoC8vo62K8IX17X2hyk1vJ6RjZVZHqtfXA6T7LCpLVgJdRx2VN3tit4STl2DA5NBXMsESD1unbhXqOE0seFPvXxu+x7pCHMkBId6zrOfKf2l86pH1uZQ8ZB7cBAjXob7DyY4rCZDELjlnhCQeefcLbUjZVuIAHHT1OgWJTKyr7KGMFklVHFgyqLfgJCNlF/5fxR2mVfuaFHYC2nMgkmimUPXte11VEknukw9syQiMPRDiKRR8IaF3buZn3fYadAlhVeLA1KuHmaUhIbfvoAumV2IF8Qs8E/LBRXKRhb1WRJ/QCdwg8RGMRtf/sm/0Z2Ew0mS7Cpdzw7+5nHumx5Ao9Nj/n00O/fam+RMj+mHXI1187ypLPpBoZRfwZg0V5nnnYx/hpe2Q5d5jewyM1gp3cdX0WiHSe/TIaQOeGQZgEkljP+ApT1DETYO66mkyhOg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199021)(6486002)(54906003)(478600001)(31686004)(31696002)(316002)(66556008)(41300700001)(4326008)(6916009)(66476007)(66946007)(86362001)(5660300002)(8936002)(8676002)(38100700002)(26005)(6506007)(6512007)(186003)(53546011)(2906002)(83380400001)(2616005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZU52ZDFNU2tpUHdnanhlRFlqTG9xT2xJSjJpTjJGZjVQd1VNaU1KTGh4NE9q?= =?utf-8?B?a3FONnI1dnM0LzZGbXhQR2daV0E0TmpuYWJpYVJQVzAxVTJ2WkFrendvWHNv?= =?utf-8?B?Ty9WaG8xVHBEWW1rekpJME0yTGh2Q1gvR2dzRlRpSDBER3pjWUcyR3YwblVN?= =?utf-8?B?VWw5NVpWSGFkOHdlNFNhN0dnSCtJTTB5MVJsTkhpOGhBWm5RS3huTjZSRTI0?= =?utf-8?B?QVMraTVJOFRDZ1FBQngxZm55c2JpaTRiODYrQ1pUQTJFRVdKdEQyR2FCVnUr?= =?utf-8?B?TmRMZE0vZDdYYmdwYmRFMFQ2UTJibm5YUEhuL3RuMGJHa2ViTUxsWEpqU2Vp?= =?utf-8?B?a0lnSWZ2ZEx6VWtnZWhJS0tEbTBTUkl5WmY5di9UajV0Q0NLM3lQaVdvcnAz?= =?utf-8?B?QnVXMG05YzJhMmtCcmhhTFhDTDNESW1tYmdRSU5YQXBZUitlMlVqeHNZejdJ?= =?utf-8?B?OHRpMnV4bzB5Z0hCRXN4MndFN3lFTEZONkpLcnJrbFMxTTArQ3dqdGN6aWdN?= =?utf-8?B?cGcyYko4QnlMUXMrQzlJcHBOeE93Njl2b1NrOFplQjdnZ2ovbkhoM0VONkFz?= =?utf-8?B?VGRDNXBheWFBUzNYKzV6TTFEZ3lxS2xIT3prV3pIRTZXK2pwcjBiZlNoN2pn?= =?utf-8?B?Q2RNZ2Qwc0s0bVI4dk1NcVBLSnl0SHFDTi8rV1NQS2dWRUMyTkh3Zm9pT0M2?= =?utf-8?B?ejBCNHJEZ1FUNEt3SDN4V01BVENnQkpLWHdoSFI5TUhCOXY2S29EYUlBSHVq?= =?utf-8?B?THpDemdMMXdGL0NFY0N5aGdNU1piVjlmOTBrRStwZGNwcllyUnBBWS9kSUVm?= =?utf-8?B?MjVsQnFlZitxZDFRR2NRL2dOM1g2YThSdklLdlBmdXF6aVYrcURoNHF6azg0?= =?utf-8?B?aURjamkzaWg0ZVpiRkR5bGQwcXpvRDJmcmJsVGhXOWVmVUdmT3pEQUFhOGow?= =?utf-8?B?eEE3dzVGZmN5QXZLejNOclYwOUpEVjh4N2V6MEtWSXE1RHErTjFVdUhHejNP?= =?utf-8?B?b1hiNE5MNUFSbkdZc0xraEQ4UWw0QkIrYXpaK3l4NldzbTlxZndUcFJFT2lx?= =?utf-8?B?WG9FUzlYRUJ0UkhXU05yNzdZN1psQkNUZnBOMTBUNjhuTXRhaWoyVzZ3czhi?= =?utf-8?B?T0daemUxbG8zcDJNQmVhRWlQVVFBaTNhdkhraVVMbmtpcFZ0Q3RVcW9iRzdl?= =?utf-8?B?c1pGaUFxbUhTSmd2a2Y5VHJFMVYxTFFVS0Znak0yUkNHYTNUWG5CQW84aGha?= =?utf-8?B?NVM1ZHpsOHBmcGhaZmJ6ZmI3Tk16RC92OHYwajFNTGd3UCtQZXlDcXkwZXNE?= =?utf-8?B?ajQ5Rm5OcndTNXVIazJQVXJvRktBOWlRWWtZSWlnNjN3ZDVNM2NLeVlKVXEz?= =?utf-8?B?S2dWRmNUZFQ1RUFuZGRaSUVJa0RiK3ArQzVnYUx3YWZRL0JlUzZxUHQrd2RB?= =?utf-8?B?cmZKczB5Ymt5REJyZThBVHF1VUlFRWlsUHE4N2doS0NHa0t4QXkxVVVJM3BD?= =?utf-8?B?RXFrSTkyeEgwNm53UGRxeEMyUDJGTXFHMVFGcFdxcmsrVDlPRjZPR2NEYTJI?= =?utf-8?B?Ky9YaXQ0WXp4cm1XakYzT2ZmeW02K05YVUFrSGhVdi9lK3poaW5mY2tONDkv?= =?utf-8?B?MGFGd0VZczZWNkh0SEpvZjlCWGJpUkNzcFdOTzUzK2JZZVh0RFljcG13cnZ3?= =?utf-8?B?bTlBdlZEbVhBbGVWSEk1b01wbnFMeW5pOUdGc3lXdEl0Vlg3RnI5T1YxWVRG?= =?utf-8?B?RUdjV1FCOXZ2akZ1ZFdRcldHRTl3NU40UXlCOStWbU5wMklZcmhoWFAvWDVE?= =?utf-8?B?SFlManpPbEQ0WnVmOTgzN2RXR2ErK1RqZzJRVk5saWR5QWJ0aVhJN0J1YlFZ?= =?utf-8?B?YjdDRTNqZ2RkZUtHeVdWTUxSUmZYbHJaRmE3bnRuYUNoL2tzeDR5a1JrT2VB?= =?utf-8?B?QWtIRm0vQm5ZSTJteU1wdlhLZEt2RXB2Z0tFc2U1V1JYc2lETUNlbVNPRzAx?= =?utf-8?B?MWE3WGdXYVVKcENyc0FPQ0FKOTZSK1ZzYVRKVzVhUUpmY3VQQTd0NmJuRzFN?= =?utf-8?B?em8vSHZQbUF3NDdkczF0cmVRQ00vNHZUclRMSVhMditLZVdCQU45czhrOU44?= =?utf-8?Q?93Gwo0RWFEOV8ZmU6EL35CmIN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a1ad593-a8a9-43ab-b99c-08db5d048486 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 09:43:38.9712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gs+cY4g+4yisUo152xoZtXRMyrR634PqfxQD4P5D+MtAOs/DMnKiGX9GfXa+jR1oexBDAp5Ur09d32VrJRREgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7175 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.05.2023 11:01, Hongtao Liu wrote: > On Wed, May 24, 2023 at 3:58 PM Jan Beulich via Gcc wrote: >> >> Hello, >> >> for a couple of years I was meaning to extend the use of these AVX512F >> insns beyond the pretty minimalistic ones there are so far. Now that I've >> got around to at least draft something, I ran into a couple of issues I >> cannot explain. I'd like to start with understanding the unexpected >> effects of a change to an existing insn I have made (reproduced at the >> bottom). I certainly was prepared to observe testsuite failures, but it >> ends up failing tests I didn't expect it would fail, and - upon looking >> at sibling ones - also ends up leaving intact tests which I would expect >> would then need adjustment (because of using the new alternative). >> >> In particular (all mentioned tests are in gcc.target/i386/) >> - avx512f-andn-si-zmm-1.c (and its AVX512VL counterparts) fails because >> for whatever reason generated code reverts back to using vpbroadcastd, >> - avx512f-andn-di-zmm-1.c, otoh, is unaffected (i.e. continues to use >> vpandnq with embedded broadcast), >> - avx512f-andn-si-zmm-2.c doesn't use the new 4th insn alternative when >> at the same time a made-up DI variant of the test (akin to what might >> be an avx512f-andn-di-zmm-2.c testcase) does. >> IOW: How is SI mode element size different here from DI mode one? Is >> there anything wrong with the 4th alternative I'm adding, or is this >> hinting at some anomaly elsewhere? > __m512i is defined as __v8di, when it's used for _mm512_andnot_epi32, > it's explicitlt converted to (__v16si) and creates an extra subreg > which is not needed for DImode cases. > And pass_combine try to match the below pattern but failed due to the > condition REG_P (operands[1]) || REG_P (operands[2]). Here I think you > want register_operand instead of REG_P. Thanks, this has indeed made things match my expectations wrt testsuite results. Sadly similar adjustments for other (new) insns didn't make any difference with the further issues I'm facing. I may therefore need to ask more questions; I hope they're not going to be too dumb. Jan