From: roy rosen <roy.1rosen@gmail.com>
To: Jeff Law <law@redhat.com>
Cc: Vladimir Makarov <vmakarov@redhat.com>, gcc@gcc.gnu.org
Subject: Re: register allocation
Date: Wed, 05 Jan 2011 14:44:00 -0000 [thread overview]
Message-ID: <AANLkTikLmF0KHXnwRWqL1niUBA1wWkH9nSRcTSMMr_Zd@mail.gmail.com> (raw)
In-Reply-To: <4D21EE2F.7070202@redhat.com>
2011/1/3 Jeff Law <law@redhat.com>:
> On 12/27/10 08:43, roy rosen wrote:
>>>
>>> I'd recommend to try ira-improv branch. I think that part of the problem
>>> is
>>> in usage of cover classes. The branch removes the cover classes and
>>> permits
>>> IRA to use intersected register classes and that helps to assign better
>>> hard
>>> registers.
>>>
>>>
>> I tried now this branch and got better results for some cases but
>> still in other cases I get lots of redundent register copies.
>> I might be missing something from the gcc history but I wonder why do
>> we need to limit the coloring stage to select a hard reg from a class
>> that was chosen by a prior stage.
>
> It was a design decision with the introduction of IRA. It made certain
> problems easier to resolve at the time and in reality, most of the time the
> set of legitimate and profitable hard registers for a given pseudo maps to a
> register class reasonably well.
>
>> Why not simply put in the interference graph edges for all registers
>> which are not possible for a pseudo and let the coloring algorithm
>> select the best hard reg.
>
> That's largely what the ira-improv branch does. Register classes at that
> point are used primarily to drive the costing model.
Actually, I tried on this branch disabling the improve_allocation
function and now it is doing a great job.
For some reason the improve_allocation function only damaged the good
allocation that was done.
In order to look at that I am trying to understand the conflict table: I see
;; a3(r255,l0) conflicts: a4(r243,l0) a6(r129,l0) a8(r126,l0)
a9(r254,l0) a10(r256,l0) a11(r257,l0) a12(r291,w0,l0) a12(r291,w1,l0)
a13(r316,w0,l0) a13(r316,w1,l0) a14(r318,w0,l0) a14(r318,w1,l0)
a15(r319,w0,l0) a15(r319,w1,l0) a16(r321,w0,l0) a16(r321,w1,l0)
a5(r253,l0) a7(r252,l0) a17(r261,l0)
;; total conflict hard regs: 53
;; conflict hard regs: 53
I see here conflicts of the pseudo with other pseudos and conflict
with a hard reg - all are result of live range data.
How is the constraint data which limits a pseudo in an insn to be of a
certain class gets into this table?
I have expected also all hard regs which are not allowed for this
pseudo because of constraints in the insns to be also in the conflict
table. I guess I miss something...
If it isn't there then how is it guranteed that the pseudo would be
allocated to a hard reg which is allowed by the constraints?
Thanks, Roy.
>
> jeff
>
next prev parent reply other threads:[~2011-01-05 14:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 8:13 roy rosen
2010-12-23 16:48 ` Vladimir Makarov
2010-12-23 17:22 ` Jeff Law
2010-12-27 15:43 ` roy rosen
2011-01-03 15:41 ` Jeff Law
2011-01-05 14:44 ` roy rosen [this message]
2011-01-05 15:26 ` Jeff Law
2011-01-11 16:11 ` Vladimir Makarov
2011-01-11 15:53 ` Vladimir Makarov
-- strict thread matches above, loose matches on Subject: below --
2005-11-24 20:51 Register Allocation Joern RENNECKE
2005-11-17 16:53 Andrew MacLeod
2005-11-18 2:55 ` Mark Mitchell
2005-11-18 3:27 ` Daniel Jacobowitz
2005-11-18 9:53 ` Giovanni Bajo
2005-11-18 15:28 ` Andrew MacLeod
2005-11-19 19:31 ` Ian Lance Taylor
2005-11-19 20:20 ` Denis Chertykov
2005-11-20 0:20 ` Giovanni Bajo
2005-11-23 17:07 ` Andrew MacLeod
2005-11-23 20:43 ` Ian Lance Taylor
2005-11-20 0:37 ` Steven Bosscher
2005-11-23 17:08 ` Andrew MacLeod
2005-11-22 19:26 ` Peter Bergner
2005-11-22 21:55 ` Steven Bosscher
[not found] ` <200511222256.13823.>
2005-11-22 22:58 ` Peter Bergner
2005-11-23 14:06 ` Michael Matz
2005-11-23 20:50 ` Peter Bergner
2005-11-23 17:08 ` Andrew MacLeod
2004-09-22 1:21 Adrian Strätling
2004-09-22 5:22 ` tm_gccmail
2004-10-04 14:13 ` Nick Ing-Simmons
2004-05-02 13:27 register allocation Qiong Cai
2004-05-02 16:56 ` Daniel Berlin
2004-05-03 7:07 ` Michael Matz
2004-03-26 22:21 Register Allocation John Lu
2004-03-26 22:21 ` Vladimir N. Makarov
2004-03-26 22:26 ` Andrew MacLeod
2004-03-27 18:22 ` Andi Kleen
2002-03-12 6:21 register Allocation Danish Samad
1997-10-14 5:51 Register allocation Thomas Koenig
1998-12-21 22:38 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikLmF0KHXnwRWqL1niUBA1wWkH9nSRcTSMMr_Zd@mail.gmail.com \
--to=roy.1rosen@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=law@redhat.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).