public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Simon Baldwin <simonb@google.com>
To: gcc@gcc.gnu.org
Subject: Hints for backporting gcc 4.5 powerpc fix to gcc 4.4.3?
Date: Tue, 22 Mar 2011 13:25:00 -0000	[thread overview]
Message-ID: <AANLkTikXft9pgJT7V5eSCpVhCmCPai-odShcMX-VYrd6@mail.gmail.com> (raw)

I'm currently trying to backport a small part of gcc 4.5 r151729 to
gcc 4.4.3.  This revision fixes a problem in powerpc code generation
that leads to gcc not using lmw/stmw instructions in function prologue
and epilogues, where it could otherwise validly use them.

On the face of things, the central piece of r151729 I seem to want is just this:

Index: gcc/config/rs6000/rs6000.c
===================================================================
--- gcc/config/rs6000/rs6000.c  (revision 151728)
+++ gcc/config/rs6000/rs6000.c  (revision 151729)
@@ -18033,7 +18033,8 @@ static bool
 no_global_regs_above (int first, bool gpr)
 {
   int i;
-  for (i = first; i < gpr ? 32 : 64 ; i++)
+  int last = gpr ? 32 : 64;
+  for (i = first; i < last; i++)
     if (global_regs[i])
       return false;
   return true;

Taking only that and leaving out all of the rest of r151729 lets me
build a powerpc gcc that does use lmw/stmw instructions in function
prologue and epilogues as hoped.  Unfortunately it also has bad
codegen elsewhere.  So it seems I need more than just this little
piece of r151729.  Unfortunately, r151729 is a fairly large patch that
seems to do a number of jobs and which does not apply readily to gcc
4.4.  At the moment it's not clear to me what other parts of it I
might need.

Can anyone here offer any hints or pointers on how to extract from the
r151729 diff just the few pieces needed to fix this single powerpc
codegen bug in gcc 4.4.3?  Anyone recognize this issue and already
dealt with it in isolation?

Thanks.

--
Google UK Limited | Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ | Registered in England Number: 3977902

             reply	other threads:[~2011-03-22 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 13:25 Simon Baldwin [this message]
2011-03-22 13:56 ` David Edelsohn
2011-03-24  9:42   ` Simon Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikXft9pgJT7V5eSCpVhCmCPai-odShcMX-VYrd6@mail.gmail.com \
    --to=simonb@google.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).