public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Michael Matz <matz@suse.de>
Cc: Mike Frysinger <vapier@gentoo.org>,
	libc-alpha@sourceware.org, 	GCC Development <gcc@gcc.gnu.org>,
	LKML <linux-kernel@vger.kernel.org>,
	x32-abi@googlegroups.com
Subject: Re: X32 psABI status update
Date: Mon, 21 Mar 2011 10:52:00 -0000	[thread overview]
Message-ID: <AANLkTikYxVzFjLQFNvEy2FBmuO76PJPA5JuLgoUGzPF0@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1103210907530.20892@wotan.suse.de>

On Mon, Mar 21, 2011 at 1:20 AM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Sun, 20 Mar 2011, H.J. Lu wrote:
>
>> I don't think it will help x32 and I think it will make it harder to add
>> x32 support. I still want to see a real usage before I add it.
>
> % cat real-world.c
> /* intptr_t; what's that? */
> union space_saving_htab_element {
>  void *generic_pointer;
>  /* Usually we need a long for a pointer, but I just figured out
>     that on x32 an int is enough and smaller.  My program
>     now needs half as much memory, supi!  */
> #ifdef __x32__
>  unsigned int as_number;
> #else
>  unsigned long as_number;
> #endif
> };

That is the wrong way to support x32.  You should remove "#ifdef __x32__",
which only shows __x32__ shouldn't be used/needed.

>
> Ciao,
> Michael.
> PS: Of course you and I wouldn't write such code, but Mikes point was that
> there might be some that do.  I could probably construct an example where
> it would matter for real involving inline asm that for some reason has to
> slightly differ depending on x32-ness.
>

I  am still waiting for a real example.

-- 
H.J.

  reply	other threads:[~2011-03-21 10:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-05 19:08 H.J. Lu
2011-03-06 17:29 ` H.J. Lu
2011-03-07 21:33 ` Mike Frysinger
2011-03-16  4:17   ` H.J. Lu
2011-03-16  4:30     ` Mike Frysinger
2011-03-16  4:51       ` H.J. Lu
2011-03-16  5:24         ` Mike Frysinger
2011-03-16 12:40           ` H.J. Lu
2011-03-17  2:57             ` Mike Frysinger
2011-03-17  5:21               ` H.J. Lu
2011-03-17  5:45                 ` Mike Frysinger
2011-03-17 14:43                   ` H.J. Lu
2011-03-17 17:38                 ` Richard Henderson
2011-03-21  5:09                 ` Mike Frysinger
2011-03-21  5:35                   ` H.J. Lu
2011-03-21  5:53                     ` Mike Frysinger
2011-03-21  6:55                       ` H.J. Lu
2011-03-21  8:20                         ` Michael Matz
2011-03-21 10:52                           ` H.J. Lu [this message]
     [not found]         ` <201103160124.42939.vapier__14164.6524928094$1300277836$gmane$org@gentoo.org>
2011-03-16 12:40           ` Andreas Schwab
2011-03-16  4:19 ` H.J. Lu
  -- strict thread matches above, loose matches on Subject: below --
2011-02-17 11:04 x32 " H.J. Lu
2011-02-19 20:57 ` H.J. Lu
2011-02-19 22:01   ` H.J. Lu
     [not found]     ` <AANLkTikkpK9ouXckHaVzwXe+p_Cz2hVH5T7xOoQL7OSE@mail.gmail.com>
2011-02-19 22:52       ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikYxVzFjLQFNvEy2FBmuO76PJPA5JuLgoUGzPF0@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matz@suse.de \
    --cc=vapier@gentoo.org \
    --cc=x32-abi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).