From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10410 invoked by alias); 1 Jun 2010 23:30:56 -0000 Received: (qmail 10249 invoked by uid 22791); 1 Jun 2010 23:30:55 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-fx0-f47.google.com (HELO mail-fx0-f47.google.com) (209.85.161.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 23:30:44 +0000 Received: by fxm9 with SMTP id 9so674047fxm.20 for ; Tue, 01 Jun 2010 16:30:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.81.14 with SMTP id v14mr1161048bkk.105.1275435039678; Tue, 01 Jun 2010 16:30:39 -0700 (PDT) Received: by 10.204.76.139 with HTTP; Tue, 1 Jun 2010 16:30:39 -0700 (PDT) In-Reply-To: References: Date: Tue, 01 Jun 2010 23:39:00 -0000 Message-ID: Subject: Re: merging the maverick FPU patches From: Martin Guy To: Ian Lance Taylor Cc: "gcc@gcc.gnu.org" , Nick Clifton , Richard Earnshaw , Paul Brook Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2010-06/txt/msg00059.txt.bz2 On 4/25/10, Ian Lance Taylor wrote: > Martin Guy writes: > > > now that stage3 is over I'm thinking of updating the > > MaverickCrunch FPU fixes (currently for 4.3) and merging them but > > would appreciate some guidance. > > > > There are 26 patches in all and I can't expect anyone to understand > > them because they require a good understanding of the FPU and its > > hardware bugs (and there are a lot of them!) :) What's the best path? > > Create a branch, work there and then merge when done? > > > > I have done the copyright assignment stuff but don't have an account > > on gcc.gnu.org. They all affect files under config/arm/ apart from one > > testsuite fix and the docs. > > > For a backend specific patch like this, I would recommend contacting > the ARM backend maintainers directly to ask how they would prefer to > proceed. They can be found in the top level MAINTAINERS file: > > arm port Nick Clifton nickc@redhat.com > arm port Richard Earnshaw richard.earnshaw@arm.com > arm port Paul Brook paul@codesourcery.com Hi I've had no reply from anyone - maybe everyone is hoping someone else do so. :) Of the three companies, redhat would be the most suitable, since the original unfinished port was done by them, and I guess ARM has no interest in making GCC work with non-ARM FPUs. The code they add/remove/change is pretty self-contained and doesn't impact the other code generation options. It just fixes the current implementation. Nick, are you willing to do the necessary? Since it just fixes existing code that never worked, all it requires from a maintainer is to check that it doesn't break code generation for other targets, which is easy to check automatically by testing a sample of targets and it's not hard to check by eye that the changes are only active when TARGET_MAVERICK. Cheers M