From: Laurynas Biveinis <laurynas.biveinis@gmail.com>
To: jeremie.salvucci@free.fr
Cc: gcc <gcc@gcc.gnu.org>, basile <basile@starynkevitch.net>
Subject: Re: Gengtype : strange code in output_type_enum
Date: Fri, 27 Aug 2010 14:47:00 -0000 [thread overview]
Message-ID: <AANLkTin=zEtmOMczdpHy-SnZf5Lz3o4qZghnRANWQhZN@mail.gmail.com> (raw)
In-Reply-To: <662566448.453381282918810720.JavaMail.root@zimbra30-e5.priv.proxad.net>
2010/8/27 <jeremie.salvucci@free.fr>:
> We recompiled GCC-trunk r162692 with the following modification :
>
> In function output_type_enum of gcc/gengtype.c, we replaced
>
> - if (s->kind == TYPE_PARAM_STRUCT && s->u.s.line.file != NULL)
> + if (s->kind == TYPE_PARAM_STRUCT && s->u.param_struct.line.file != NULL)
>
> And Gengtype works like before with c,c++, lto enabled.
>
> Do you think we have to submit a one line patch (if yes, could it be reviewed quickly)? We don't know why the old version works, and we think writing u.s.line.file is incorrect for TYPE_PARAM_STRUCT (even if it happens to work by luck), since the union u.param_struct member is the only valid for TYPE_PARAM_STRUCT.
One-line patches are welcome, but in this instance could you please
find out how the old code worked before changing it (as you admit, you
don't understand it).
--
Laurynas
next prev parent reply other threads:[~2010-08-27 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 12:49 jeremie.salvucci
2010-08-27 13:40 ` Laurynas Biveinis
2010-08-27 13:44 ` jeremie.salvucci
2010-08-27 14:25 ` jeremie.salvucci
2010-08-27 14:43 ` Arnaud Charlet
2010-08-27 14:47 ` Laurynas Biveinis [this message]
2010-08-27 18:25 ` Basile Starynkevitch
2010-08-27 18:29 ` Ian Lance Taylor
2010-08-27 15:02 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTin=zEtmOMczdpHy-SnZf5Lz3o4qZghnRANWQhZN@mail.gmail.com' \
--to=laurynas.biveinis@gmail.com \
--cc=basile@starynkevitch.net \
--cc=gcc@gcc.gnu.org \
--cc=jeremie.salvucci@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).