From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55499 invoked by alias); 18 Sep 2019 13:08:54 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 55489 invoked by uid 89); 18 Sep 2019 13:08:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=improving, quality X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-oln040092071074.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.92.71.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2019 13:08:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDwQUkjWKFRme9G9yowYA2gyi75J/nmr4ZESLfsPNvzUeFujES0Agd+QxPV1H73vK1J1LRhT97ww+8E4TkYfAO5iVXNE44dGMgQEks8ehemldI2CQs9EcrMv/k1rhIRAW/mQSZLh0Y3ghVnsRbnhakXTVo5MqWTsppov2jthu8Dcm/X6eDRMaPCKiINhXitAlXEhqz4L4zmYYlDF+RGaRfY3utDWS1H3zEfYc+bGp2i8aZc5xHIOgzsPsh1M5hUJOndSzeUPvIe07ZoMKK9HcS46LFcb+dWwIueyaPftVF98bIssRNZ5wj6U5NUDYJPMxhLnBbEiGfMQU1cxj8bGnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cet7qevd3Fit2oDQvvTIzDssgu519rxjSiirUEQqLSY=; b=VVzxmi7a8l0RKYCv56OZZc+xcP/d4gh/IP/vuKcVMHwBEExiUJJCBtoIpdYhWw3EAj8r+jftQrJ5RKdLIb1kmwnwHwKjd6REmhy2E075l7pWsQZJ7kUGmhe4f/sL2x54hdSOiAhF+Tfc0BgFd5JdqKYX/X4OM5+zI03LYtsEAjHbNrrOMg45Ki+z5mlZODekTMjRpPobkFiQEkaMid5tM5DRzhetPCQjj6j9LJ7DJ61MBSltR0VUtnW3rgNL0YZZ526TCcYmFQQOhqLXuDPka1fhBTzPpub7bKaOBVW06KSKgO/NPPYIOg87OP3a+sOt6tNGNqHTyr68IR7Ah4uc5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB5EUR03FT030.eop-EUR03.prod.protection.outlook.com (10.152.20.55) by DB5EUR03HT190.eop-EUR03.prod.protection.outlook.com (10.152.21.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2263.14; Wed, 18 Sep 2019 13:08:50 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM (10.152.20.57) by DB5EUR03FT030.mail.protection.outlook.com (10.152.20.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2263.14 via Frontend Transport; Wed, 18 Sep 2019 13:08:50 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::2c65:b468:fdc0:d924]) by AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::2c65:b468:fdc0:d924%6]) with mapi id 15.20.2284.009; Wed, 18 Sep 2019 13:08:50 +0000 From: Bernd Edlinger To: "gcc@gcc.gnu.org" Subject: Adding -Wshadow=local to gcc build rules Date: Wed, 18 Sep 2019 13:08:00 -0000 Message-ID: x-microsoft-original-message-id: <0b30e882-9993-fab0-c954-30a54ae5f2fc@hotmail.de> x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-09/txt/msg00129.txt.bz2 Hi, I'm currently trying to add -Wshadow=3Dlocal to the gcc build rules. I started with -Wshadow, but gave up that idea immediately. As you could expect the current code base has plenty of shadowed local variables. Most are trivial to resolve, some are less trivial. I am not finished yet, but it is clear that it will be a rather big patch. I would like to ask you if you agree that would be a desirable step, in improving code quality in the gcc tree. Thanks Bernd.