Re: Libobjc and libffi on Darwin

Re: Libobjc and libffi on Darwin

[Bill Northcott]

Andre Pinski wrote
>> On 14/08/2004, at 11:17 AM, James E Wilson wrote:
>>> Bill Northcott wrote:
>>>> ffi.h never got installed.  ffitarget.h was installed in the
>>>> compiler includes directory.  Any suggestions where this should be
>>>> fixed?
>>>
>>> Maybe you are looking in the wrong place?  ffi.h gets installed in a
>>> different place than ffitarget.h.
>>>
>>> If it really wasn't installed, then look at the Makefile in the
>>> $target/libffi/include directory.  There should be an install rule
>>> for the ffi.h file.  Works backwards from there to figure out why it
>>> wasn't called.
>>>
>>
>> Thanks for the comments. I got it fixed by patching build-gcc thus
>
> So this is on the apple-ppc-branch which means you installed the
> Apple way using build_gcc which is different the FSF way.
> Which was not there in your description of the problem.
>
Sorry about that.  I apologise.

> Well since GNUStep uses libffi, I thought that compiling with objc
> would
> install libffi automatically.

Adding objc to the languages does not even build libffi.  Fudging the
targets in configure to make it build means it also installs with an
FSF build, but Apple use build_gcc to assemble the final distribution
and it does not copy ffi.h into its final location without a patch like
I suggested.

I will stick it on Apple's bug reporter as a suggestion.

Bill Northcott

Re: Libobjc and libffi on Darwin

[Andrew Pinski]

On Aug 14, 2004, at 8:48 PM, Bill Northcott wrote:

>> Well since GNUStep uses libffi, I thought that compiling with objc
>> would install libffi automatically.
>
> Adding objc to the languages does not even build libffi.  Fudging the
> targets in configure to make it build means it also installs with an
> FSF build, but Apple use build_gcc to assemble the final distribution
> and it does not copy ffi.h into its final location without a patch like
> I suggested.


This was mainly a reply to Tom's email and what should happen in the 
future,
not what happens now.

Thanks,
Andrew Pinski 

Libobjc and libffi on Darwin

[Bill Northcott]

I built gcc-3.5 on MacOS X using source from the cvs with tag 
apple-ppc-gcc-1771 (merged from lno 20040718) and the patches which 
Andrew has proposed to enable libobjc.  This seems to work fine so far. 
  I managed to compile a working set of Swarm libraries with it, 
although I am not yet using the GNU runtime.

I tried to enable libffi by moving it from the gcj only section in the 
configure script.  It all got built OK using Apple's build script but 
ffi.h never got installed.  ffitarget.h was installed in the compiler 
includes directory.  Any suggestions where this should be fixed?

Bill Northcott

Re: Libobjc and libffi on Darwin

[Tom Tromey]

>>>>> "Bill" == Bill Northcott <w.northcott@unsw.edu.au> writes:

Bill> I tried to enable libffi by moving it from the gcj only section in the
Bill> configure script.  It all got built OK using Apple's build script but
Bill> ffi.h never got installed.  ffitarget.h was installed in the compiler
Bill> includes directory.  Any suggestions where this should be fixed?

Do we want to install any of libffi?

What I'd like to see is the copy of libffi in gcc be treated purely as
an implementation detail for libgcj (and whatever other language
libraries might want to use it), but then have separate standalone
libffi releases as a real library.  I think Anthony is working toward
this goal, but I'm not sure where things stand at the moment.

Tom

Re: Libobjc and libffi on Darwin

[Andrew Pinski]

On Aug 13, 2004, at 5:15 PM, Tom Tromey wrote:

>>>>>> "Bill" == Bill Northcott <w.northcott@unsw.edu.au> writes:
>
> Bill> I tried to enable libffi by moving it from the gcj only section 
> in the
> Bill> configure script.  It all got built OK using Apple's build 
> script but
> Bill> ffi.h never got installed.  ffitarget.h was installed in the 
> compiler
> Bill> includes directory.  Any suggestions where this should be fixed?
>
> Do we want to install any of libffi?
Well since GNUStep uses libffi, I thought that compiling with objc would
install libffi automatically.


-- Pinski

Re: Libobjc and libffi on Darwin

[James E Wilson]

Bill Northcott wrote:
> ffi.h never got installed.  ffitarget.h was installed in the compiler 
> includes directory.  Any suggestions where this should be fixed?

Maybe you are looking in the wrong place?  ffi.h gets installed in a 
different place than ffitarget.h.

If it really wasn't installed, then look at the Makefile in the 
$target/libffi/include directory.  There should be an install rule for 
the ffi.h file.  Works backwards from there to figure out why it wasn't 
called.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

Re: Libobjc and libffi on Darwin

[Bill Northcott]

On 14/08/2004, at 11:17 AM, James E Wilson wrote:
> Bill Northcott wrote:
>> ffi.h never got installed.  ffitarget.h was installed in the compiler 
>> includes directory.  Any suggestions where this should be fixed?
>
> Maybe you are looking in the wrong place?  ffi.h gets installed in a 
> different place than ffitarget.h.
>
> If it really wasn't installed, then look at the Makefile in the 
> $target/libffi/include directory.  There should be an install rule for 
> the ffi.h file.  Works backwards from there to figure out why it 
> wasn't called.
>

Thanks for the comments. I got it fixed by patching build-gcc thus:
Index: build_gcc
===================================================================
RCS file: /cvsroot/gcc/gcc/Attic/build_gcc,v
retrieving revision 1.1.2.9
diff -c -c -r1.1.2.9 build_gcc
*** build_gcc	6 Aug 2004 20:15:31 -0000	1.1.2.9
--- build_gcc	12 Aug 2004 07:23:42 -0000
***************
*** 289,294 ****
--- 289,297 ----
   # include
   HEADERPATH=$DEST_ROOT/include/gcc/darwin/$MAJ_VERS
   mkdir -p .$HEADERPATH || exit 1
+ # fudge for odd headers not really gcc like ffi.h
+ cp -p $DIR/dst-$BUILD-$BUILD/$DEST_ROOT/include/*.h \
+   .$DEST_ROOT/include
   cp -rp $DIR/dst-$BUILD-$BUILD$HEADERPATH/c++ \
     .$HEADERPATH/ || exit 1
   for t in $TARGETS ; do

Bill Northcott

Re: Libobjc and libffi on Darwin

[Andrew Pinski]

On Aug 13, 2004, at 7:11 PM, Bill Northcott wrote:

>
> On 14/08/2004, at 11:17 AM, James E Wilson wrote:
>> Bill Northcott wrote:
>>> ffi.h never got installed.  ffitarget.h was installed in the 
>>> compiler includes directory.  Any suggestions where this should be 
>>> fixed?
>>
>> Maybe you are looking in the wrong place?  ffi.h gets installed in a 
>> different place than ffitarget.h.
>>
>> If it really wasn't installed, then look at the Makefile in the 
>> $target/libffi/include directory.  There should be an install rule 
>> for the ffi.h file.  Works backwards from there to figure out why it 
>> wasn't called.
>>
>
> Thanks for the comments. I got it fixed by patching build-gcc thus

So this is on the apple-ppc-branch which means you installed the
Apple way using build_gcc which is different the FSF way.
Which was not there in your description of the problem.

Thanks,
Andrew Pinski

Re: Libobjc and libffi on Darwin

[James E Wilson]

On Fri, 2004-08-13 at 19:11, Bill Northcott wrote:
> Thanks for the comments. I got it fixed by patching build-gcc thus:

I don't know what build-gcc is.  Maybe some Apple specific thingy?  If
so, you may need to direct this patch to them.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

Re: Libobjc and libffi on Darwin

[Dale Johannesen]

On Aug 13, 2004, at 8:28 PM, James E Wilson wrote:

> On Fri, 2004-08-13 at 19:11, Bill Northcott wrote:
>> Thanks for the comments. I got it fixed by patching build-gcc thus:
>
> I don't know what build-gcc is.  Maybe some Apple specific thingy?  If
> so, you may need to direct this patch to them.

Thanks, we see it.  Somebody will review it, probably not before Monday 
(I personally
don't know build-gcc well enough to do so).

Re: Libobjc and libffi on Darwin

[Bill Northcott]

On 15/08/2004, at 4:20 AM, Dale Johannesen wrote:
> On Aug 13, 2004, at 8:28 PM, James E Wilson wrote:
>
>> On Fri, 2004-08-13 at 19:11, Bill Northcott wrote:
>>> Thanks for the comments. I got it fixed by patching build-gcc thus:
>>
>> I don't know what build-gcc is.  Maybe some Apple specific thingy?  If
>> so, you may need to direct this patch to them.
>
> Thanks, we see it.  Somebody will review it, probably not before 
> Monday (I personally
> don't know build-gcc well enough to do so).
>
It is Apple specific, but it is just a fairly simple script that uses 
the environment of Apple build system for the Darwin OS.  It drives the 
normal configure, make bootstrap sequence to build the compiler and 
then copies the files into an Apple directory structure.

Bill