From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id E0D9A3858D35 for ; Tue, 7 Nov 2023 07:38:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0D9A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0D9A3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699342703; cv=none; b=RrKs822EKi9oMTUmH/164XIzOint+i/1GF6uPM8xqlRSCcGM1R0i6LRTCF282G9P/CO5Z8zpeew60I3rxqDxXmtGc3l8nYMd8vdymEVcBGfMY+iTGXRUcQnXE8TjjXWeYY5DQXnwB8jZUZRRXhkqGQeBcq02TbvKTIR1Vo/PUvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699342703; c=relaxed/simple; bh=9v9lDQAXEJfgRhbn0J4c3CDpvFWKqITGgi9kabcgHrA=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=WIvu+bqrFKjeaF1JRbTF48PbeG1beWid6Myw4DEfDpe0KRM9DzJYEHIJlHTgEBHUPesT8k4f0ZjIq2lhtanpI6leZamc93Hs0I9STBhUDWZQ6zObGHBFeGF6pwMfF6eFNYFWRvOjS8gmL579uR3mbLE8XvBIlos2BJCJdBjBj6I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-53db2f8d193so1747880a12.0 for ; Mon, 06 Nov 2023 23:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699342700; x=1699947500; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JG8qzQpZlvHOUwKvu/qwRsZdVWIcZ5vDibEW4ywCjIw=; b=Zqv2Pt7N+wOyfZmC3KjQ5K3iStTaxl//1GcbjRW/8VS776Ox/kR2KDsYMj9k5BabKj kch3HQNC/GGeh3mPYk6hkUfaZAHI38TnjHm8reC3UZZmOtpSRffODRcwqXvjQ8U2oghB RomX5mXytzBNNsLAj2UQjkPPEIfXiU2X60N8H1AYCsO5jQlaaaQ6ZyiuItQddZPvtM2L 6OIUs1dVyEIs3u6rC/zh0rx1wS2HGowraW3tmR4waxBfSnbnzCNdWOsBU9hmWA/ntVaE Wm3gE3khJ1KGJFj9hllkBlhdnM0lOhSZ/xKCYJArgDjQxv+lWvDyKYcV7CiJS92cuOOG wqfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699342700; x=1699947500; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JG8qzQpZlvHOUwKvu/qwRsZdVWIcZ5vDibEW4ywCjIw=; b=a397PwZNXliLNrLYU2JrUDPSZl/Z/nqIWvpf026jLyZ3qPPPjUUrEo7CJx84iTcxNh gVXOUCwJwMbYRPmT+LI2Ssvzk+27dB7ptRIJJRa0dB4gI4f+sftXgR5d/Da3s8kaA9ic ODcNichD8P2cutKv8aL1mku1O7rPG+NOWylop/RmimMpagB36ClIop0qlWlsEsvn7IOR DMmWHSgegVAcVMfODvgMlNBtwjxv2pFL22VjY+4rnPeHzyofLaRJ7k4X+ArOVxYTgAOW 4VZRlclFJwvBvX4pLcXIqFMNAKwmyogAR2gMgWxxw9F1ebXZqJFOsngKaln9bRF3zusC Eckg== X-Gm-Message-State: AOJu0YxBXbTAv/4EFs8yngyjyhS1SG7X3O4+gAkOh2k7qAsdhmq2L2Gx LQaawJQHxxg0K9k9OJQpmg2g X-Google-Smtp-Source: AGHT+IGOPPjNYW0o0QypzRMPMvkKwZBOO/UK2jKM9DGdhJy+SDo73xS/XMDgYC+LOA5U6YHy6WLcfg== X-Received: by 2002:a17:907:9411:b0:9de:b20c:be46 with SMTP id dk17-20020a170907941100b009deb20cbe46mr6062924ejc.3.1699342700508; Mon, 06 Nov 2023 23:38:20 -0800 (PST) Received: from smtpclient.apple ([37.252.80.67]) by smtp.gmail.com with ESMTPSA id j16-20020a170906831000b009df5d874ca7sm715274ejx.23.2023.11.06.23.38.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2023 23:38:19 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: Checks that autotools generated files were re-generated correctly From: Maxim Kuvyrkov In-Reply-To: Date: Tue, 7 Nov 2023 11:38:08 +0400 Cc: GCC Mailing List , Christophe Lyon , Siddhesh Poyarekar , Carlos O'Donell Content-Transfer-Encoding: quoted-printable Message-Id: References: <65491cda.c80a0220.5fa79.7688SMTPIN_ADDED_BROKEN@mx.google.com> To: Martin Jambor X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Nov 6, 2023, at 21:19, Christophe Lyon = wrote: >=20 > Hi! >=20 > On Mon, 6 Nov 2023 at 18:05, Martin Jambor wrote: >>=20 >> Hello, >>=20 >> I have inherited Martin Li=C5=A1ka's buildbot script that checks that = all >> sorts of autotools generated files, mainly configure scripts, were >> re-generated correctly when appropriate. While the checks are = hopefully >> useful, they report issues surprisingly often and reporting them = feels >> especially unproductive. >>=20 >> Could such checks be added to our server side push hooks so that = commits >> introducing these breakages would get refused automatically. While = the >> check might be a bit expensive, it only needs to be run on files >> touching the generated files and/or the files these are generated = from. >>=20 >> Alternatively, Maxim, you seem to have an infrastructure that is = capable >> of sending email. Would you consider adding the check to your = buildbot >> instance and report issues automatically? The level of totally >=20 > After the discussions we had during Cauldron, I actually thought we > should add such a bot. >=20 > Initially I was thinking about adding this as a "precommit" check, to > make sure the autogenerated files were submitted correctly, but I > realized that the policy is actually not to send autogenerated files > as part of the patch (thus making pre-commit check impracticable in > such cases, unless we autogenerate those files after applying the > patch) >=20 > I understand you mean to run this as a post-commit bot, meaning we > would continue to "accept" broken commits, but now automatically send > a notification, asking for a prompt fix? >=20 > We can probably implement that, indeed. Is that the general agreement? [CC: Siddhesh, Carlos] Hi Martin, I agree with Christophe, and we can add various source-level checks and = wrap them up as a post-commit job. The job will then send out email = reports to developers whose patches failed it. Where the current script is located? These checks would be useful for = all GNU Toolchain projects -- binutils/GDB, GCC, Glibc and, maybe, = Newlib -- so it would be useful to put it in a separate "gnutools" repo. = I think Siddhesh and Carlos are looking into creating such a repo on = gitlab? Thanks, -- Maxim Kuvyrkov https://www.linaro.org