From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id CBE793886C6C for ; Mon, 21 Jun 2021 08:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBE793886C6C Received: by mail-wr1-x430.google.com with SMTP id j1so1289649wrn.9 for ; Mon, 21 Jun 2021 01:02:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yjgKqgeNJtRpjG69j8QeEiui4wC0inRVNwTyLv6tmCI=; b=C7cRDZKjgoTKLR6DwbXvyPpYhfc131NFdvZ2qgXNFl9U5N6oqCM21QSwzNlKM2RHWC iMQ1BGO27XGAUIuK1GHEgzV8PfmT1BUa7+nfA0F3xRq7qJL4djEc1uyN+81k7ZjyvNDj TpJv2lPJkUwcS8kJp46Ijf06KGc2om6NGLZ/oCm65lUJld3D3hL1AkE1dTMBdClTuTw6 OUlGCCyIWQhzDHjmIcOZh8oIK4udV59Q2VG1pjbke7D1Y9xc5yNh3mmtTXt+9fDo0FUH H4f3bWPMgiwrPweptAPidn9dzUf8ZwMn6CLJxGabk375oIc9cETG3T853Qte43OsTEnk 1DyA== X-Gm-Message-State: AOAM533OMjWuzUoHIMCBFb6u81Kmu8fI8ujr84MhvgVVu4qqv5XMv1IE LShwP49i8Q56hKASZiX2l5w= X-Google-Smtp-Source: ABdhPJyxyrKQiJ0llUKPf3xdaZzg/0e28dUF2hT1biHJPasBbEYRfnkby3S6Ya0q+8Am6S1MOIaeog== X-Received: by 2002:a5d:4443:: with SMTP id x3mr11226626wrr.67.1624262577740; Mon, 21 Jun 2021 01:02:57 -0700 (PDT) Received: from [192.168.1.214] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id s7sm16966112wru.67.2021.06.21.01.02.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jun 2021 01:02:57 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog) From: Iain Sandoe In-Reply-To: <1cea588b-a709-785e-9da1-01004b45e504@suse.cz> Date: Mon, 21 Jun 2021 09:02:50 +0100 Cc: Tobias Burnus , Jason Merrill , Jakub Jelinek , gcc Mailing List , Jonathan Wakely , Richard Earnshaw , Joseph Myers Content-Transfer-Encoding: quoted-printable Message-Id: References: <71b4a023-efb2-6c6a-9ced-93cce7c96540@gmail.com> <013d6727-4008-b4b5-b793-c782a5ba8e10@redhat.com> <916af0f3-0877-e977-6b6c-899edec8e706@foss.arm.com> <20210617172129.GH7746@tucnak> <16f70de7-8324-e249-dbd8-605022066d12@foss.arm.com> <070f57d5-1496-50f4-1144-3ff2e75a4460@codesourcery.com> <501b0e4f-c184-899b-701b-e370e377c347@codesourcery.com> <1cea588b-a709-785e-9da1-01004b45e504@suse.cz> To: Martin Liska X-Mailer: Apple Mail (2.3445.104.21) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 08:03:01 -0000 > On 21 Jun 2021, at 08:26, Martin Li=C5=A1ka wrote: >=20 > On 6/21/21 8:42 AM, Tobias Burnus wrote: >> On 18.06.21 16:41, Jason Merrill wrote: >>>=20 >>> * Being able to specify the PR numbers on the command line in = addition >>> (currently, they are only extracted from the testsuite = patches) >>>=20 >>>=20 >>> This bit seems unnecessary to me, since we want the commit to = include >>> tests that identify the PR. >> I full hearty disagree! >=20 > Hello. >=20 > I do support Tobias' patch and I really think -b argument is handy. = Question is, > if one can use it from 'git commit-mklog' hook? I'm asking because I = don't use mklog.py > directly. +1 =E2=80=A6 and probably including options to the commit ..=20 so for something like git commit-mklog -s -b xxxxxx or even (if this makes sense ) git commit-mklog =E2=80=94amend -b xxxxx perhaps we need a way to indicate which sub-process the options are for? Iain >=20 > Martin >=20 >>> Martin Sebor's patch to extract the PR number from the testcase >>> filename, as an alternative to a comment, should be enough. >> Regarding the PR from the filename, are we only talking about >> new files =E2=80=93 or about modifications to old files? >> For new files, together with -p it seems to be useful; for >> old files, I think there will be more spurious/false PRs than >> useful/right PRs. >> Looking through the last few commits, in all of the following >> cases the -b would be useful =E2=80=94 and I do regard the commits >> messages are sensible: >> * cc9c94d43dcfa98436152af9c00f011e9dab25f6 PR libstdc++/100387 >> added testsuite/25_algorithms/minmax/constrained.cc (etc.) >> but file neither has a pr... name nor contains a PR line >> (BTW: The fix is not primarily for the PR but fixes it as, >> a side effect; hence, not having a PR line makes sense) >> * 870b674f72d4894b94efa61764fd87ecec29ffde >> 'ranger' - removes a datastructure (no testcase but also >> does not make sense here) >> * 17a4bee01c3b29c5ccdd39f34384521e5d44135b >> Fixes an ICE for one testcase (but of course does not add >> a new testcase or modify an existing one.) >> * 76e990fd211cbb20bf74ce074eb8b2d7b096d3b7 >> fix a bootstrap issue (found with the GCC 11 backport). >> Those are all commits between last Friday and today. Hence, I do >> believe it makes sense to be able to specify the PR on the >> command line =E2=80=94 besides obtaining it from file names. >> Tobias >> ----------------- >> Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnch= en Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: = Thomas Heurung, Frank Th=C3=BCrauf >=20