From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 83FC93848025 for ; Mon, 14 Jun 2021 17:00:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83FC93848025 Received: by mail-lj1-x22a.google.com with SMTP id bn21so21145568ljb.1 for ; Mon, 14 Jun 2021 10:00:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jNHMuL0G+wV6HfBeyYwFjCVRXOafMbzfpmvyCGqizOg=; b=mOFjk1FQNP24E0Iu7nm36YGMbJH5Fz+yilSJYw7T+eCcgm34TIMJOfmoPAzvcrlI1p iK6QUVOVoKJSW2TtcJMXEG1WftgKYrOwqbaufBw8IG9ybaFgs3jnG+6lqAy69ZNRTXSN TCfUz8DJJHx+niWK998c8B6w5SBkaZnmFY8qmlH+7MrPOTpS9Qw5IZzcJp1DzVRUF1BX U5RoCAQON4aboOpsYfLVQKtOLuMDRGQhrSmGbJF0VuLelKwD6yNcMJSLK2j84zbDIuWG Fge7d6JllgzZRV0QUM+6LR7cyLu4CTIZCGyJrsMIY8Sc+9C/qFwww86QjtYgVNJ2fyFG dCmQ== X-Gm-Message-State: AOAM533Pzic53jLLmGMBSttIvZ2wtkjx3GkFUW7pPdfuWCUeDng3HCz6 glgugbCmrSCDis8Q1nFt3YyKtVWV+adM3Xv3dlA0xQ== X-Google-Smtp-Source: ABdhPJx5vLgXB42NZ6Up1rwJgs0lkx2O0nWNQ0zbkGbzrcsdcgdriVgNXN9PGcoc82HWucS5iwm12N0O0WdOxzvmJvU= X-Received: by 2002:a05:651c:20c:: with SMTP id y12mr14461601ljn.428.1623690025351; Mon, 14 Jun 2021 10:00:25 -0700 (PDT) MIME-Version: 1.0 References: <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> <20210426180011.GA1401198@tassilo.jf.intel.com> <20210429054025.GB4032392@tassilo.jf.intel.com> In-Reply-To: From: Wei Mi Date: Mon, 14 Jun 2021 10:00:20 -0700 Message-ID: Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC To: Eugene Rozenfeld Cc: Andi Kleen , Hongtao Yu , Xinliang David Li , Jan Hubicka , "gcc@gcc.gnu.org" , Wenlei He X-Spam-Status: No, score=-17.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, HTML_MESSAGE, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 17:00:32 -0000 Yeah, create_llvm_prof depends on llvm_symbolizer which shouldn't have the same limitation. To separate from llvm, create_gcov still depends on the old set of addr2line library which likely doesn't support dwarf v5. That is an issue indeed. Thanks, Wei. On Fri, Jun 11, 2021 at 6:14 PM Eugene Rozenfeld < Eugene.Rozenfeld@microsoft.com> wrote: > It appears that create_gcov doesn't support binaries with dwarf version 5 > (which is the current default). > I tried a trivial example and got reasonable gcov files for binaries with > dwarf v2, v3, and v4 but the same example with dwarf v5 produced > "File './sort' has mangled .debug_info section." > and a gcov file with 0 functions. > > Does create_llvm_prof has the same limitation? > > Eugene > > -----Original Message----- > From: Wei Mi > Sent: Wednesday, May 26, 2021 7:52 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > David Li ; Jan Hubicka ; > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > Thanks. Good to know the build works with newer protobuf. > > Wei. > > On Wed, May 26, 2021 at 4:40 PM Eugene Rozenfeld < > Eugene.Rozenfeld@microsoft.com> wrote: > > > > 3.0.0 is the latest supported version on Ubuntu 18.04. I verified that > the build works on Ubuntu 20.04 with protobuf-compiler and libprotobuf-d= ev > version 3.6.1.3. > > > > Eugene > > > > -----Original Message----- > > From: Wei Mi > > Sent: Tuesday, May 25, 2021 8:07 PM > > To: Eugene Rozenfeld > > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > > David Li ; Jan Hubicka ; > > gcc@gcc.gnu.org; Wenlei He > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > I checked the source of protobuf 3.0.0 and it didn't contain the > operator[] in RepeatedField. Need to install a newer version of protobuf. > > > > Thanks, > > Wei. > > > > On Tue, May 25, 2021 at 1:49 PM Eugene Rozenfeld < > Eugene.Rozenfeld@microsoft.com> wrote: > > > > > > Both are 3.0.0-9.1ubuntu1: > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list > > > protobuf-compiler Listing... Done protobuf-compiler/bionic,now > > > 3.0.0-9.1ubuntu1 amd64 [installed] > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list > > > libprotobuf-dev Listing... Done libprotobuf-dev/bionic,now > > > 3.0.0-9.1ubuntu1 amd64 [installed] > > > > > > -----Original Message----- > > > From: Wei Mi > > > Sent: Tuesday, May 25, 2021 9:17 AM > > > To: Eugene Rozenfeld > > > Cc: Andi Kleen ; Hongtao Yu ; > > > Xinliang David Li ; Jan Hubicka > > > ; gcc@gcc.gnu.org; Wenlei He > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > It looks like some version problem about protobuf-compiler and > libprotobuf-dev. Could you check what is the installed version on your en= d > for those two packages and see if they are consistent? > > > > > > On my platform, they are both 3.12.4. > > > > > > On Tue, May 25, 2021 at 12:01 AM Eugene Rozenfeld < > Eugene.Rozenfeld@microsoft.com> wrote: > > > > > > > > That eliminates the previous error but there is a new one: > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [3/199] > > > > Building CXX object > > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/qu > > > > ip > > > > pe > > > > r/perf_reader.cc.o > > > > FAILED: > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/p= erf_reader.cc.o > > > > /usr/bin/c++ -I../third_party/perf_data_converter/src > -I../third_party/perf_data_converter/src/quipper -I../ > -I../third_party/glog/src -I../third_party/abseil -I../util -I. > -Ithird_party/glog -std=3Dgnu++1z -MD -MT > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/p= erf_reader.cc.o > -MF > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/p= erf_reader.cc.o.d > -o > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/p= erf_reader.cc.o > -c ../third_party/perf_data_converter/src/quipper/perf_reader.cc > > > > ../third_party/perf_data_converter/src/quipper/perf_reader.cc: In > member function 'bool > quipper::PerfReader::ReadCPUTopologyMetadata(quipper::DataReader*, size_t= )': > > > > > ../third_party/perf_data_converter/src/quipper/perf_reader.cc:1518:46: > error: no match for 'operator[]' (operand types are 'const > google::protobuf::RepeatedField' and 'int') > > > > nrcpus =3D proto_uint32_metadata.data()[0]; > > > > > > > > -----Original Message----- > > > > From: Wei Mi > > > > Sent: Monday, May 24, 2021 8:54 PM > > > > To: Eugene Rozenfeld > > > > Cc: Andi Kleen ; Hongtao Yu ; > > > > Xinliang David Li ; Jan Hubicka > > > > ; gcc@gcc.gnu.org; Wenlei He > > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > It isn't exposed on my platform either. Looks like a bug in > perf_data_converter (i.e., quipper). Could you try adding #include > in > third_party/perf_data_converter/src/quipper/huge_page_deducer.cc and see = if > it fixes the problem? If it works, I will need to file a bug against > perf_data_converter. > > > > > > > > Thanks, > > > > Wei. > > > > > > > > On Mon, May 24, 2021 at 8:33 PM Eugene Rozenfeld < > Eugene.Rozenfeld@microsoft.com> wrote: > > > > > > > > > > That fixed the error I saw before but the build still fails. The > > > > > errors start with > > > > > > > > > > > > > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja > > > > > > > > > > [2/217] Building CXX object > > > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/ > > > > > qu > > > > > ip > > > > > pe > > > > > r/huge_page_deducer.cc.o > > > > > > > > > > FAILED: > > > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/ > > > > > qu > > > > > ip > > > > > pe > > > > > r/huge_page_deducer.cc.o > > > > > > > > > > /usr/bin/c++ -I../third_party/perf_data_converter/src > -I../third_party/perf_data_converter/src/quipper -I../ > -I../third_party/glog/src -I../third_party/abseil -I../util -I. > -Ithird_party/glog -std=3Dgnu++1z -MD -MT > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/h= uge_page_deducer.cc.o > -MF > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/h= uge_page_deducer.cc.o.d > -o > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/h= uge_page_deducer.cc.o > -c ../third_party/perf_data_converter/src/quipper/huge_page_deducer.cc > > > > > > > > > > > ../third_party/perf_data_converter/src/quipper/huge_page_deducer.cc: > > > > > 14 > > > > > 4:26: error: 'unordered_map' in namespace 'std' does not name a > > > > > template type > > > > > > > > > > using container =3D std::unordered_map; > > > > > > > > > > ^~~~~~~~~~~~~ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Wei Mi > > > > > Sent: Monday, May 24, 2021 8:12 PM > > > > > To: Eugene Rozenfeld > > > > > Cc: Andi Kleen ; Hongtao Yu ; > > > > > Xinliang David Li ; Jan Hubicka > > > > > ; gcc@gcc.gnu.org; Wenlei He > > > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > > > > > > > > > > > > > Sorry, I added dependency for create_gcov but missed it for > dump_gcov. Fixed it at > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fgoogle%2Fautofdo%2Fcommit%2F6ca36cdc30986f13583a3aef3e27746ca4fc5bf= 6&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.com%7Cf1e7a16701ba42957= 22c08d920ba6846%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63757680725812= 5451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik= 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D826uc8So5JIW6bTbsxBMiEbLWexdiBiPjYr= xexHOLmI%3D&reserved=3D0 > . > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Wei. > > > > > > > > > > > > > > > > > > > > On Mon, May 24, 2021 at 6:39 PM Eugene Rozenfeld < > Eugene.Rozenfeld@microsoft.com> wrote: > > > > > > > > > > Thank you Wei. Looks like something is still missing. This time > perf_data.pb.h is not found. I'm getting the error below (on Ubuntu 18.04 > with cmake 3.12.1): > > > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/241] > > > > > Building CXX object CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > > > > FAILED: CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > > > > /usr/bin/c++ -I../ -I../third_party/glog/src > -I../third_party/abseil -I../third_party/perf_data_converter/src > -I../third_party/perf_data_converter/src/quipper -I../util -I. > -Ithird_party/glog -std=3Dgnu++1z -MD -MT > CMakeFiles/dump_gcov_lib.dir/profile.cc.o -MF > CMakeFiles/dump_gcov_lib.dir/profile.cc.o.d -o > CMakeFiles/dump_gcov_lib.dir/profile.cc.o -c ../profile.cc > > > > > In file included from > ../third_party/perf_data_converter/src/quipper/perf_parser.h:18:0, > > > > > from ../sample_reader.h:18, > > > > > from ../profile.h:15, > > > > > from ../profile.cc:5: > > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > > > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > > > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > > > > > > > > > In file included from ../profile.h:14:0, > > > > > from ../profile.cc:5: > > > > > ../base/macros.h:114:0: note: this is the location of the > > > > > previous definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) > > > > > \ > > > > > > > > > > In file included from > ../third_party/perf_data_converter/src/quipper/perf_parser.h:18:0, > > > > > from ../sample_reader.h:18, > > > > > from ../profile.h:15, > > > > > from ../profile.cc:5: > > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0= : > > > > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) > > > > > / > > > > > sizeof(*x)) > > > > > > > > > > In file included from ../profile.h:14:0, > > > > > from ../profile.cc:5: > > > > > ../base/macros.h:162:0: note: this is the location of the > > > > > previous definition #define arraysize(array) > > > > > (sizeof(ArraySizeHelper(array))) > > > > > > > > > > In file included from > ../third_party/perf_data_converter/src/quipper/perf_parser.h:21:0, > > > > > from ../sample_reader.h:18, > > > > > from ../profile.h:15, > > > > > from ../profile.cc:5: > > > > > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:14:10: > > > > > fatal error: perf_data.pb.h: No such file or directory #include > "perf_data.pb.h" > > > > > ^~~~~~~~~~~~~~~~ > > > > > compilation terminated. > > > > > [6/241] Building CXX object > > > > > CMakeFiles/dump_gcov_lib.dir/symbol_map.cc.o > > > > > ninja: build stopped: subcommand failed. > > > > > > > > > > Thanks, > > > > > > > > > > Eugene > > > > > > > > > > From: Wei Mi > > > > > Sent: Saturday, May 22, 2021 9:37 AM > > > > > To: Eugene Rozenfeld > > > > > Cc: Andi Kleen ; Hongtao Yu ; > > > > > Xinliang David Li ; Jan Hubicka > > > > > ; gcc@gcc.gnu.org; Wenlei He > > > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > > > It is a proto library build dependency issue which didn't expose > on my platform. I fix it at > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fgoogle%2Fautofdo%2Fcommit%2F98269aee9674cc885cc5eb1bd917eb2d1273171= 0&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.com%7Cf1e7a16701ba42957= 22c08d920ba6846%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63757680725812= 5451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik= 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D%2Br9qK1fc2SQu%2FT9rHOCsJcYqzpkXnDu= 7SNfpLB9NCqQ%3D&reserved=3D0. > Please try again. > > > > > > > > > > Thanks, > > > > > Wei. > > > > > > > > > > On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld Eugene.Rozenfeld@microsoft.com> wrote: > > > > > I tried following the instructions in "2.2 Build autofdo tool for > gcc" in > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozenfeld%40m= icrosoft.com%7Cf1e7a16701ba4295722c08d920ba6846%7C72f988bf86f141af91ab2d7cd= 011db47%7C1%7C0%7C637576807258125451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj= AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DKpb= Q1SBpwtPLdgJCpJQ6aW6iHj3mvisPN5kZVRiRQhM%3D&reserved=3D0 > got build failures: > > > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/228] > > > > > Building CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o > > > > > FAILED: CMakeFiles/create_gcov_lib.dir/profile.cc.o > > > > > /usr/bin/c++ -I../ -I../third_party/glog/src > > > > > -I../third_party/abseil -I../third_party/perf_data_converter/src > -I../third_party/perf_data_converter/src/quipper -I../util -I. > -Ithird_party/glog -std=3Dgnu++1z -MD -MT > CMakeFiles/create_gcov_lib.dir/profile.cc.o -MF > CMakeFiles/create_gcov_lib.dir/profile.cc.o.d -o > CMakeFiles/create_gcov_lib.dir/profile.cc.o -c ../profile.cc In file > included from > ../third_party/perf_data_converter/src/quipper/perf_parser.h:18:0, > > > > > from ../sample_reader.h:18, > > > > > from ../profile.h:15, > > > > > from ../profile.cc:5: > > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > > > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > > > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file included from > ../profile.h:14:0, > > > > > from ../profile.cc:5: > > > > > ../base/macros.h:114:0: note: this is the location of the > > > > > previous definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > > > > In file included from > ../third_party/perf_data_converter/src/quipper/perf_parser.h:18:0, > > > > > from ../sample_reader.h:18, > > > > > from ../profile.h:15, > > > > > from ../profile.cc:5: > > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0= : > > > > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) / > > > > > sizeof(*x)) In file included from ../profile.h:14:0, > > > > > from ../profile.cc:5: > > > > > ../base/macros.h:162:0: note: this is the location of the > > > > > previous definition #define arraysize(array) > > > > > (sizeof(ArraySizeHelper(array))) In file included from > ../third_party/perf_data_converter/src/quipper/perf_parser.h:21:0, > > > > > from ../sample_reader.h:18, > > > > > from ../profile.h:15, > > > > > from ../profile.cc:5: > > > > > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:16:10: > > > > > fatal error: perf_stat.pb.h: No such file or directory #include > "perf_stat.pb.h" > > > > > ^~~~~~~~~~~~~~~~ > > > > > compilation terminated. > > > > > > > > > > What is supposed to generate perf_stat.pb.h? > > > > > > > > > > Thanks, > > > > > > > > > > Eugene > > > > > > > > > > From: Wei Mi > > > > > Sent: Monday, May 10, 2021 4:47 PM > > > > > To: Andi Kleen > > > > > Cc: Hongtao Yu ; Xinliang David Li > > > > > ; Jan Hubicka > > > > > ; mailto:gcc@gcc.gnu.org; Eugene > > > > > Rozenfeld ; Wenlei He > > > > > > > > > > Subject: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fgoogle%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.= com%7Cf1e7a16701ba4295722c08d920ba6846%7C72f988bf86f141af91ab2d7cd011db47%7= C1%7C0%7C637576807258135446%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ= QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D0qVyYYmYDZfH= t3cdxg1LjUYvonck6G6PLAOFeYCNnTc%3D&reserved=3D0 > has been updated. Now create_gcov/dump_gcov are added back and can be bui= lt > separately. > > > > > > > > > > Please look at "2.2 Build autofdo tool for gcc" in > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F= % > > > > > 2F > > > > > gi > > > > > th > > > > > ub.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Ro= z > > > > > en > > > > > fe > > > > > ld > > > > > %40microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86 > > > > > f1 > > > > > 41 > > > > > af > > > > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbG > > > > > Zs > > > > > b3 > > > > > d8 > > > > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > > > > 3D > > > > > %7 > > > > > C1 > > > > > 000&sdata=3DEwHtN1OqRmBwL6qMgTc1lAU6cz5%2BJzQZxpd5nos11FM%3D&= a > > > > > mp > > > > > ;r > > > > > es > > > > > erved=3D0 On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen > > > > > wrote: > > > > > > > > > > > > On Mon, Apr 26, 2021 at 06:40:56PM +0000, Hongtao Yu wrote: > > > > > > > Andi, thanks for pointing out the perf script issues. Can > you please > > > > > > > elaborate a bit on the exact issue you have seen? We've > been using > > > > > > > specific output of perf script such as mmap, LBR and > callstack events > > > > > > > filtered by process id. It works fine so far but may > certainly hit issues > > > > > > > in the future with extended uses. > > > > > > > > > > > > Okay I took a look at the latest autofdo now. It seems to be > > > > > > basically a LLVM project now that depends on LLVM to even > > > > > > build with all kinds of dependency hell on some old LLVM versio= n > and other packages. > > > > > > > > > > > > I guess gcc will really need a replacement that doesn't pull > > > > > > in all of LLVM if it wants to continue supporting autofdo. > > > > > > > > > > > > I'm myself unable to build now. > > > > > > > > > > > > I'm using the old version I had a git fork of and that was > > > > > > before all of this. I added a patch to make it work with the > > > > > > latest perf by ignoring increased perf_attr and unknown perf > events. > > > > > > > > > > > > Honza please use > > > > > > > > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%= 2 > > > > > > F% > > > > > > 2F > > > > > > gi > > > > > > thub.com%2Fandikleen%2Fautofdo&data=3D04%7C01%7CEugene.Roze= n > > > > > > fe > > > > > > ld > > > > > > %4 > > > > > > 0microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86 > > > > > > f1 > > > > > > 41 > > > > > > af > > > > > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFp > > > > > > bG > > > > > > Zs > > > > > > b3 > > > > > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > > > > > > Mn > > > > > > 0% > > > > > > 3D > > > > > > %7C1000&sdata=3DDilu5PUjpAbA6e6d6GBd5idoKLAMMr7H5eCve%2FGdC= 8 > > > > > > g% > > > > > > 3D > > > > > > &a > > > > > > mp;reserved=3D0 -b perf-future > > > > > > > > > > > > for testing. > > > > > > > > > > > > -Andi > > > > > > >