From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by sourceware.org (Postfix) with ESMTPS id 83E1C3858000 for ; Fri, 7 Jan 2022 10:44:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83E1C3858000 Received: by mail-vk1-xa2f.google.com with SMTP id l68so3429384vkh.4 for ; Fri, 07 Jan 2022 02:44:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=0WK30RwhgsGNhbbqDTQ3OMnEp6TZ6YdR3q8msfSGxPA=; b=UIlaKnKNSiuOEW2MhKL3evp7UHrtINtz8AM28xNJLCLe4k8KFYJLhCh6cwfRCfdCZ2 OC2LnkqOdISN8xJaAYx2Of2AJgO5Fhdq3tTjqfsyUYGzgGXlt5FJ9qT+flL/8iu/z6Fz MqPOgnVjDBqeZ9SdvWEi9ucMo0Y7lVtDb56alIyz+gPcqgCmWjJtdbcdOn3X2QGTW9mB +Z5rgnbeYmgtTBMOrAbL4PfvgPWRPc81dMTTTmd1gl7J+pPm13+y8ArMDBSPJUr7Nna2 v+EwcpbYM+NlTOxNeYdd8WShE3g5XBRWXBgMfOLrHTAFkq8NZTZDBHMBWeoynEqxt/3s tAJA== X-Gm-Message-State: AOAM531iWu7X+pFGNczXv+cR+BLNyKxOMdPsvQiPh/C/MG5cFFdl9yUB drvNrPLYhj+vri/u2/+6eGpjMd5lONhgNUXqcKk= X-Google-Smtp-Source: ABdhPJwM4nkpDWYazFsk45lsJRCDDYOva4/8tMtEeUWUqVdCfG04nDClFGPLdhmtK3papagnz4qNvzBTrlYOOE4MKfk= X-Received: by 2002:a05:6122:b64:: with SMTP id h4mr23427782vkf.24.1641552264005; Fri, 07 Jan 2022 02:44:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrew Pinski Date: Fri, 7 Jan 2022 02:44:09 -0800 Message-ID: Subject: Re: Mass rename of C++ .c files to .cc suffix? To: Richard Sandiford , Martin Jambor , GCC Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2022 10:44:25 -0000 On Fri, Jan 7, 2022 at 2:35 AM Richard Sandiford via Gcc wrote: > > Martin Jambor writes: > > Hi, > > > > Would anyone be terribly against mass renaming all *.c files (that are > > actually C++ files) within the gcc subdirectory to ones with .cc suffix= ? > > > > We already have 47 files with suffix .cc directly in the gcc > > subdirectory and 160 if we also count those in (non-testsuite) > > subdirectories, while the majority of our non-header C++ files still ha= s > > the .c suffix. > > > > I have already missed stuff when grepping because I did not include *.c= c > > files and the inconsistency is also just ugly and must be very confusin= g > > to anyone who encounters it for the first time. > > > > Since we have switched to git, this should have quite small effect on > > anyone who does their development on branches. With Martin Li=C5=A1ka = we did > > a few experiments and git blame, git rebase and even git gcc-backport > > worked seamlessly across a rename. > > > > I would be fine waiting with it until GCC 12 gets released but see > > little value in doing so. > > > > What do others think? (Any important caveats I might have missed?) > > +1 in favour FWIW. And I agree we might as well do it now. It seems > likely to be less disruptive than waiting to GCC 12, since at that point > there's going to be more bug fixes that need to be applied to both trunk > and the new branch, as well as the unleashed stage 1 patches. +1 in favor. (I don't mind it either time really). I also think the generated files that get built in the build directory should also be moved but that is more depth patch. Thanks, Andrew Pinski > > Thanks, > Richard