From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id A0E48385781F for ; Fri, 17 Feb 2023 17:13:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0E48385781F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52a.google.com with SMTP id o1so1054762pgm.7 for ; Fri, 17 Feb 2023 09:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676653995; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4hckey+G5HL2Wlf/UonxxdpdMeYT/4iqVyJd6zNYiB4=; b=T5vkNZGzxMfrsIeyL/Q0/w2AzL9ZZNobzjrnXSXkojaGgxXak374SULNPkG1gZV1dQ qlSm2j3hCOZfBusurME7ZX3tLoLOoa4rrCAxpt7THsDMX1Bwo/UF6hp/tmz7hUvudUZB Kt2q5A3Owaet2YVmIA6N8pXOyKYEeXIR2BdYceUqHiDIN7gNoOYomiKEJ8eORO3tibl2 zKysqU2Loofo/xHiPIrxfEdFtl0oIEr+0CDJOcE6VuwClmE9kQyyvKgKG1Twu7h7bLKe /d6ULkhsVc5MRr/F216QglH0LBghyIAmW7gI5RJn8NHxuP65YP3zDKe5CH3v/t4jqGkk gdVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676653995; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4hckey+G5HL2Wlf/UonxxdpdMeYT/4iqVyJd6zNYiB4=; b=aiXsCazXNGJGRcDAHJJDsCQwP8uZelwjnHtQpZ95ySa99140Uru9aGrHARQk+2Rdzs b6RKzYN6MCwYM0aLImLQhnWLulmTVs8btxRi8LHFPLKCMfWkcJmL3bKr1LBMk1AW0tpg kKwPbnaVv+wSubqFu10MO8dPwlyKDWiq/y/D3EPhT6w5+cRgmHxjePiFF+FaALB8wBlQ GaUCcLZcee6lQb1KEm6XEElSiOtDhWCGnz8x4ccaOy9INDZjxIY0yeEAQZI198A0FVB0 IMnzTAapdJ1IKMsvxdsMGh34Uw++FeVnp47dBColfHBW35/+2ujenW1VSO2XOQF4zm11 tjvw== X-Gm-Message-State: AO0yUKVguovowMGuJL/5fZ6gaNPmQaPebaM0bVCca7TvHuhOy66JPvfw 6TKrG4hFEKA1SrrFWtkc4IqdJUBBSzYfb70hJ94= X-Google-Smtp-Source: AK7set8KKGvKv3R4efUhdylqJR/GuaBG6woo3O2zEb0riAGYrt4uGTEkW6oeTBqiuVvXiwwsuBOqRCGiwutwQfhFnCM= X-Received: by 2002:a62:86ca:0:b0:5a9:9549:9f1b with SMTP id x193-20020a6286ca000000b005a995499f1bmr813087pfd.22.1676653995555; Fri, 17 Feb 2023 09:13:15 -0800 (PST) MIME-Version: 1.0 References: <009a0ac2-0626-c21c-c0f9-4d2e8daa66b3@redhat.com> In-Reply-To: <009a0ac2-0626-c21c-c0f9-4d2e8daa66b3@redhat.com> From: Andrew Pinski Date: Fri, 17 Feb 2023 09:13:03 -0800 Message-ID: Subject: Re: get_range_query vs NULL argument To: Andrew MacLeod Cc: Aldy Hernandez , GCC Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 15, 2023 at 2:30 PM Andrew MacLeod wrote: > > > On 2/15/23 14:50, Andrew Pinski wrote: > > Hi, > > While fixing PR 108354, I came across that > > ssa_name_has_boolean_range calls get_range_query with cfun as the > > argument but sometimes while in IPA passes cfun is currently nullptr. > > The question should we check the argument before calling > > get_range_query or is it a valid thing to call it with a nullptr (and > > have it return global_ranges in that case)? > > That might be ok... personally I see nothing wrong with: > > diff --git a/gcc/value-query.h b/gcc/value-query.h > index 63878968118..2d7bf8fcf33 100644 > --- a/gcc/value-query.h > +++ b/gcc/value-query.h > @@ -140,7 +140,7 @@ get_global_range_query () > ATTRIBUTE_RETURNS_NONNULL inline range_query * > get_range_query (const struct function *fun) > { > - return fun->x_range_query ? fun->x_range_query : &global_ranges; > + return (fun && fun->x_range_query) ? fun->x_range_query : &global_ranges; > } > > // Query the global range of NAME in function F. Default to cfun. > > > The client is probably going to do that anyway. Ok. I will submit a patch which does the above; I had that patch already when I wrote the email and wanted to double check before submitting it. Thanks, Andrew Pinski > > Aldy? > >