From: Guillaume Gomez <guillaume1.gomez@gmail.com>
To: Antoni Boucher <bouanto@zoho.com>
Cc: gcc@gcc.gnu.org, David Malcolm <dmalcolm@redhat.com>
Subject: Re: Handling of nonnull function attribute
Date: Thu, 21 Sep 2023 21:48:09 +0200 [thread overview]
Message-ID: <CAAOQCfThOxbMXH3A0rj41JCOsDSgHxFQ5iSV6NDa+vEY_0tocg@mail.gmail.com> (raw)
In-Reply-To: <ce657b2623113a9deef67c21a2282d8e07959b5a.camel@zoho.com>
Hi,
We were able to make it work by calling:
```
decl_attributes (&fndecl, fn_attributes, 0);
```
We used to set the attributes directly in `fndecl` using equivalents of:
```
DECL_ATTRIBUTES (fndecl) =
tree_cons (ident, attribute_value, DECL_ATTRIBUTES (fndecl));
```
We now store inside `fn_attributes` using:
```
fn_attributes = tree_cons (ident, attribute_value, fn_attributes);
```
Like this, the function attributes seem to be correctly set and the
optimization is triggered as expected when using the `nonnull`
attribute.
I think with this it's all good. If you see something we did wrong,
please don't hesitate to tell us.
Le jeu. 21 sept. 2023 à 16:48, Antoni Boucher <bouanto@zoho.com> a écrit :
>
> Hi.
> I'm working on adding the support for the nonnull attribute in
> libgccjit.
> I found out a way to make it working, but I need more help to find a
> proper solution.
> The problem is that the nonnull attribute should be added to the
> fn_type while we added it to the fn_decl.
> If we add it to the fn_type directly, it works.
> However, it seems the other frontends do that automatically, by the way
> of c_common_attribute_table (field type_required set to true).
> Is this correct?
> If so, how does this mechanism work and how can it be enabled for a
> frontend?
> I tried calling init_attributes at the end of jit_langhook_init, but
> that doesn't work.
> Thanks for your help.
prev parent reply other threads:[~2023-09-21 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:47 Antoni Boucher
2023-09-21 19:48 ` Guillaume Gomez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAOQCfThOxbMXH3A0rj41JCOsDSgHxFQ5iSV6NDa+vEY_0tocg@mail.gmail.com \
--to=guillaume1.gomez@gmail.com \
--cc=bouanto@zoho.com \
--cc=dmalcolm@redhat.com \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).