From: Gabriel Dos Reis <gdr@integrable-solutions.net>
To: Michael Matz <matz@suse.de>
Cc: Lawrence Crowl <crowl@googlers.com>, "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: Simplifying Gimple Generation
Date: Thu, 15 Nov 2012 16:52:00 -0000 [thread overview]
Message-ID: <CAAiZkiAOCvQjQqWZYJEz3yTYO8rYdBVEgF8Qb9ekGBsacTT1UQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1211151523550.21868@wotan.suse.de>
On Thu, Nov 15, 2012 at 8:48 AM, Michael Matz <matz@suse.de> wrote:
[...]
> The method name should imply the action, e.g. 'add_stmt' or append_stmt
> or the like.
strongly agreed.
[...]
> All in all I think we can severely improve on building gimple statements
> without introduction of any helper class. Basically, whenever a helper
> class merely contains one member of a different type, then I think that
> other type should be improved so that the wrapper class isn't necessary
> anymore. Fewer types -> good :)
no, it is the opposite. Distinct abstractions should be materialized
by distinct types. => less opportunities for bugs.
-- Gaby
next prev parent reply other threads:[~2012-11-15 16:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 1:13 Lawrence Crowl
2012-11-15 6:06 ` Basile Starynkevitch
2012-11-15 19:34 ` Lawrence Crowl
2012-11-16 13:15 ` Diego Novillo
2012-11-15 7:32 ` Xinliang David Li
2012-11-16 13:13 ` Diego Novillo
2012-11-17 1:05 ` Xinliang David Li
2012-11-15 14:48 ` Michael Matz
2012-11-15 16:52 ` Gabriel Dos Reis [this message]
2012-11-15 17:01 ` Michael Matz
2012-11-15 17:07 ` Xinliang David Li
2012-11-15 19:59 ` Lawrence Crowl
2012-11-16 12:44 ` Michael Matz
2012-11-16 13:59 ` Diego Novillo
2012-11-16 14:30 ` Michael Matz
2012-11-16 17:31 ` Andrew Pinski
2012-11-20 16:49 ` Andrew MacLeod
2012-11-25 1:35 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAiZkiAOCvQjQqWZYJEz3yTYO8rYdBVEgF8Qb9ekGBsacTT1UQ@mail.gmail.com \
--to=gdr@integrable-solutions.net \
--cc=crowl@googlers.com \
--cc=gcc@gcc.gnu.org \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).