From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 9843F38930D0 for ; Mon, 26 Apr 2021 18:05:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9843F38930D0 Received: by mail-pg1-x532.google.com with SMTP id j7so31167634pgi.3 for ; Mon, 26 Apr 2021 11:05:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uhkxcYt56LNroVk2xGlkl4+Nj27r+h/VLc8hbckDxQU=; b=gDXCDkWJT1O/vxgPKWDUm64hyE1SyUEXDXSOolewYpDkDth9RcIQigDFzvcCGW9CP1 7fmb5DruCJqzf9XJYLS2dq+tD4f7A+k2ktx5diZW4UnQ5OwIqdTbEYZTLULom4INX1jf f/ygfm2HAWKZyttPyidnWgprVl2IWRe3axlLu1UJ10bKVZtSrL+PVjSWtfP6zQidfRe9 rm1GAh40aW/rqHUdwZxhsNbqqo9IFGetBEArweYoF7FT2x672WDp0S3PxJy/+25Q9d74 RUkH1KwfrKuuhavjfdvifLjKtouTLFWOuaFS5DEa9jGJv7NTAhzx1EkrTm5ze6TodUHd pZig== X-Gm-Message-State: AOAM533NGCHU5WmL5xF8DCN4zIap4hd75bYByaDGack01ioylB7Yqt6r tPkh13Co7o5Yc0y6tBD3ZSpPBQufQ5KqHTq1ti1UOQ== X-Google-Smtp-Source: ABdhPJyFdj8JO5ir8aDPPY4cx0Z90Uc7FvtloEks1bEhEKxJcLcLThYTQAcCwiuF4p+ANWWiSdj3bPhR66Ie8XlOY4Q= X-Received: by 2002:a62:1ec1:0:b029:24d:b3de:25be with SMTP id e184-20020a621ec10000b029024db3de25bemr18596294pfe.17.1619460336458; Mon, 26 Apr 2021 11:05:36 -0700 (PDT) MIME-Version: 1.0 References: <20210423165449.GC56452@kam.mff.cuni.cz> <20210423171611.GA82007@kam.mff.cuni.cz> <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> <20210426180011.GA1401198@tassilo.jf.intel.com> In-Reply-To: <20210426180011.GA1401198@tassilo.jf.intel.com> From: Xinliang David Li Date: Mon, 26 Apr 2021 11:05:25 -0700 Message-ID: Subject: Re: State of AutoFDO in GCC To: Andi Kleen Cc: Jan Hubicka , "gcc@gcc.gnu.org" , Wei Mi , Eugene Rozenfeld , Wenlei He , Hongtao Yu X-Spam-Status: No, score=-17.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 18:05:39 -0000 On Mon, Apr 26, 2021 at 11:00 AM Andi Kleen wrote: > > There are multiple directional changes in this new tool: > > 1) it uses perf-script trace output (in text) as input profile data; > > I suspect this will break regularly too > > (I personally did numerous changes to perf script output, and also > wrote a lot of parsing scripts) > > The perf script output has some bad problems, e.g. for file names or > processes > with spaces and some other issues. To make it handleable would need some > redesign to actually generate in a machine friendly format. > Andi, thanks for the input. +authors of the llvm-profgen tool for their experience with using perf script output. David > > A perf.data parser should be fine, just don't fill it up with asserts > and "be liberal what you accept" and ignore unknown records. > > -Andi >