From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29404 invoked by alias); 29 May 2019 11:21:34 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 29396 invoked by uid 89); 29 May 2019 11:21:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=holidays, H*c:alternative X-HELO: mail-ed1-f48.google.com Received: from mail-ed1-f48.google.com (HELO mail-ed1-f48.google.com) (209.85.208.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 11:21:32 +0000 Received: by mail-ed1-f48.google.com with SMTP id m4so3191916edd.8 for ; Wed, 29 May 2019 04:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GbctI2exJf0OyaZjQEPksZnqnTF+dABlCYs6AM1rzBo=; b=rtskwlc2b0JtN0p9xUyoSfOgZobEdfrnuuDEYRbc1jtnRobzi620brTC4a0+yPBjaf NNXL0fa4WMobeV817nrwVFnJWDbVRzkLAivY7UpQy98ipklgx1G1+9hmvBveC3DUFmHp 6zdu+kuXWS3Ob7xh0fn0ZMqpoTJ+Y5Ju25ceNk8bmZv4pCl3tr5qwr+ph9JeGE779aFC WdxWk9sa8Z3quio1W9yeZWjXBeGR6uDnBzvevFBskEtdpvlcltbNlD3t0bBd95B49+Vb kZAKdJvCuyAladIfxj36nQLz4g0tjD3ASCEhJzpnL16UVGDy987Cady42f89t2MQrnLf TLlQ== MIME-Version: 1.0 References: In-Reply-To: From: Tejas Joshi Date: Wed, 29 May 2019 11:21:00 -0000 Message-ID: Subject: Re: About GSOC. To: gcc@gcc.gnu.org Cc: Martin Jambor , hubicka@ucw.cz Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00248.txt.bz2 Hello. My exams are finally over and I have started to address these points now. I intend to give my most of the time cause of holidays and will try to consider most of the cases for the patch this time . Thanks, -Tejas On Tue, 21 May 2019 at 03:18, Joseph Myers wrote: > On Mon, 20 May 2019, Martin Jambor wrote: > > > in addition to the things already pointed out by Joseph, I have the > > following comments. But as Joseph has already pointed out, you should > > also test your patch on __float128 types, so please make sure your code > > gets invoked and works for something like: > > > > if (__builtin_roundevenf128 (0x1p64q+0.5) != (0x1p64q)) > > link_error (__LINE__); > > ... but with the f128 constant suffix not q, so it works on more > architectures (all those with _Float128 support, not just those with older > __float128 support). > > > > +DEF_EXT_LIB_BUILTIN (BUILT_IN_ROUNDEVEN, "roundeven", > BT_FN_DOUBLE_DOUBLE, ATTR_CONST_NOTHROW_LEAF_LIST) > > > +DEF_EXT_LIB_BUILTIN (BUILT_IN_ROUNDEVENF, "roundevenf", > BT_FN_FLOAT_FLOAT, ATTR_CONST_NOTHROW_LEAF_LIST) > > > +DEF_EXT_LIB_BUILTIN (BUILT_IN_ROUNDEVENL, "roundevenl", > BT_FN_LONGDOUBLE_LONGDOUBLE, ATTR_CONST_NOTHROW_LEAF_LIST) > > > > ...and for the code to trigger for __builtin_roundevenf128 you have to > > define this builtin function too. The easiest way is to do it in the > > same way it is done for BUILTIN_ROUND and many other functions, i.e. use > > DEF_EXT_LIB_FLOATN_NX_BUILTINS. > > Also note that TS 18661-1 has been merged into C2X. I haven't yet updated > glibc headers to reflect this, but this means a new DEF_C2X_BUILTIN should > be added similar to DEF_C11_BUILTIN, and used for those three new > functions, instead of DEF_EXT_LIB_BUILTIN. (And for the strdup and > strndup built-in functions, also added to C2X, but that's independent of > the present project.) > > -- > Joseph S. Myers > joseph@codesourcery.com >