From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19743 invoked by alias); 4 Feb 2019 15:56:55 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 19722 invoked by uid 89); 4 Feb 2019 15:56:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:sk:mail-ed, HX-Received:906, H*i:QBgY3YgMbuBaq, H*f:CAAgBjMk X-HELO: mail-ed1-f50.google.com Received: from mail-ed1-f50.google.com (HELO mail-ed1-f50.google.com) (209.85.208.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Feb 2019 15:56:53 +0000 Received: by mail-ed1-f50.google.com with SMTP id h50so294436ede.5 for ; Mon, 04 Feb 2019 07:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=vsFgoMRnEaGbVMN5ih38kEo2FlDcHQLZoVibgiHJam0=; b=gnzmq7Zx8XVoUqcD8uTvn9RsHcHHdykhzywyb4bzkpMwY6ILpkh748Dz6WRmiPMLbh +kRfcWAxn0woRQ0PnmmmlSvehvoTdzZmtWi1ZArLr7DuNlUQD5AW6ZjinEseHO5ZGMn3 1WhJzAQ4lD8et1V8iNTur8C2TabHMD6KEbGeQ2HTTX+bIKAAWLhXZ8Jo7ZyBppgkXBXO PDxpHWOQ2ZNevJnKxfZPjsDMn79Le+qZHAW6Vbg+oMBi4Sno/qgjM0cJLEe/Ytpg3hvl NNuMnLtr9+nPX9V3zbiCEHPfyUx4sPdLxCy46sLAVqYOXIG2Wd0NBDc+Ujlq1JsOC94T 1ecA== MIME-Version: 1.0 References: In-Reply-To: From: Tejas Joshi Date: Mon, 04 Feb 2019 15:56:00 -0000 Message-ID: Subject: Re: About GSOC. To: gcc@gcc.gnu.org Content-Type: multipart/mixed; boundary="00000000000071d5930581138aeb" X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00009.txt.bz2 --00000000000071d5930581138aeb Content-Type: text/plain; charset="UTF-8" Content-length: 4338 Thanks. > Did you add an entry for roundeven in builtins.def ? Yes, I did. Find here the attached patch.diff for which I did the changes to implement roundeven. There might be some unnecessary changes and some necessary changes which have not been made. Regards, -Tejas On Mon, 4 Feb 2019 at 20:36, Prathamesh Kulkarni wrote: > > On Mon, 4 Feb 2019 at 20:10, Tejas Joshi wrote: > > > > Hello. > > I have implemented roundeven function in real.c as follows: (and > > respective changes in real.h) > It's a better idea to include all changes in patch instead of copy-pasting. > Use the command: > git diff > patch.diff > which will create a file called "patch.diff" containing the changes > and send it as an attachment. > > > > /* Round X to nearest even integer towards zero. */ > > > > void > > real_roundeven (REAL_VALUE_TYPE *r, format_helper fmt, > > const REAL_VALUE_TYPE *x) > > { > > REAL_VALUE_TYPE t; > > > > do_fix_trunc (&t, x); > > HOST_WIDE_INT i = real_to_integer (&t); > > if(i % 2) > > do_add (r, &t, &dconstm1, 0); > > else > > *r = t; > > } > > > > Although I cant get it to test like > > > > int foo() > > { > > double x = __builtin_roundeven (3.5); > > printf("%f",x); > > return (int) x; > > } > > Because I do not know its dependencies through other files. I tried to > > track them down by inspecting real_ceil function, but it also includes > > other optimization procedures like folding. How do I know enough > > declarations to be made in respective files? > Did you add an entry for roundeven in builtins.def ? > > Thanks, > Prathamesh > > > > Thanks. > > -Tejas > > > > On Mon, 28 Jan 2019 at 22:33, Tejas Joshi wrote: > > > > > > Hello. > > > Representations of real numbers in real.c are a little complex to > > > understand right now for me. I am still trying to understand them and > > > figure them out using gdb and cscope. Though conventions are given in > > > comments in real.c, I will still be trying to figure it out. The > > > equation and its bitwise representation is not pretty elaborated in > > > any documentation I could find. > > > > > > x = s * b^e * \sum_{k=1}^p f_k * b^{-k} > > > > > > where > > > s = sign (+- 1) > > > b = base or radix, here always 2 > > > e = exponent > > > p = precision (the number of base-b digits in the significand) > > > f_k = the digits of the significand. > > > > > > In mean time, I've tried real_round function to work like roundeven. I > > > will try to submit a clean patch along with roundeven implemented > > > separately with changes like in builtins.def, adding cases, etc. > > > > > > void > > > real_round (REAL_VALUE_TYPE *r, format_helper fmt, > > > const REAL_VALUE_TYPE *x) > > > { > > > #if 0 > > > do_add (r, x, &dconsthalf, x->sign); > > > do_fix_trunc (r, r); > > > if (fmt) > > > real_convert (r, fmt, r); > > > #endif > > > fprintf (stderr, "\nhere\n"); > > > real_value z; > > > do_fix_trunc (&z, x); > > > HOST_WIDE_INT i = real_to_integer (&z); > > > fprintf (stderr, "\n i = %ld\n", i); > > > if (i % 2) > > > do_add (r, &z, &dconstm1, 0); > > > else > > > *r = z; > > > } > > > > > > Thanks. > > > -Tejas > > > > > > On Sat, 26 Jan 2019 at 03:02, Joseph Myers wrote: > > > > > > > > On Sat, 26 Jan 2019, Tejas Joshi wrote: > > > > > > > > > function with byte-byte comparison which also include mpfr. (Correct > > > > > me if I am wrong.) What is the significance of mpfr related to these > > > > > internal representations? > > > > > > > > real.c provides a fixed-size representation of floating-point numbers that > > > > allows for various non-IEEE formats supported by GCC, and also allows > > > > functions from dfp.c to be used for decimal floating-point formats. > > > > > > > > MPFR is used in GCC to provide operations that are nontrivial to > > > > implement, especially those that are nontrivial to implement in such a > > > > fixed-size context. real.c operations wrap around MPFR ones where > > > > appropriate, doing whatever's needed in cases where there are non-IEEE > > > > semantics or sets of values. > > > > > > > > -- > > > > Joseph S. Myers > > > > joseph@codesourcery.com --00000000000071d5930581138aeb Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrqitpkz0 Content-length: 4547 ZGlmZiAtLWdpdCBhL2djYy9idWlsdGlucy5jIGIvZ2NjL2J1aWx0aW5zLmMK aW5kZXggMjVlMDFlNDA5MmIuLjI1MjgyZDIxMjJkIDEwMDY0NAotLS0gYS9n Y2MvYnVpbHRpbnMuYworKysgYi9nY2MvYnVpbHRpbnMuYwpAQCAtMjA2Nyw2 ICsyMDY3LDcgQEAgbWF0aGZuX2J1aWx0X2luXzIgKHRyZWUgdHlwZSwgY29t YmluZWRfZm4gZm4pCiAgICAgQ0FTRV9NQVRIRk4gKFJFTVFVTykKICAgICBD QVNFX01BVEhGTl9GTE9BVE4gKFJJTlQpCiAgICAgQ0FTRV9NQVRIRk5fRkxP QVROIChST1VORCkKKyAgICBDQVNFX01BVEhGTl9GTE9BVE4gKFJPVU5ERVZF TikKICAgICBDQVNFX01BVEhGTiAoU0NBTEIpCiAgICAgQ0FTRV9NQVRIRk4g KFNDQUxCTE4pCiAgICAgQ0FTRV9NQVRIRk4gKFNDQUxCTikKZGlmZiAtLWdp dCBhL2djYy9idWlsdGlucy5kZWYgYi9nY2MvYnVpbHRpbnMuZGVmCmluZGV4 IGVmODk3MjlmZDBjLi5mMWI2ODMwYTQ5YyAxMDA2NDQKLS0tIGEvZ2NjL2J1 aWx0aW5zLmRlZgorKysgYi9nY2MvYnVpbHRpbnMuZGVmCkBAIC0zMDgsNiAr MzA4LDcgQEAgREVGX0M5OV9CVUlMVElOICAgICAgICAoQlVJTFRfSU5fQ0JS VCwgImNicnQiLCBCVF9GTl9ET1VCTEVfRE9VQkxFLCBBVFRSX01BVEhGTl8K IERFRl9DOTlfQlVJTFRJTiAgICAgICAgKEJVSUxUX0lOX0NCUlRGLCAiY2Jy dGYiLCBCVF9GTl9GTE9BVF9GTE9BVCwgQVRUUl9NQVRIRk5fRlBST1VORElO RykKIERFRl9DOTlfQlVJTFRJTiAgICAgICAgKEJVSUxUX0lOX0NCUlRMLCAi Y2JydGwiLCBCVF9GTl9MT05HRE9VQkxFX0xPTkdET1VCTEUsIEFUVFJfTUFU SEZOX0ZQUk9VTkRJTkcpCiBERUZfTElCX0JVSUxUSU4gICAgICAgIChCVUlM VF9JTl9DRUlMLCAiY2VpbCIsIEJUX0ZOX0RPVUJMRV9ET1VCTEUsIEFUVFJf Q09OU1RfTk9USFJPV19MRUFGX0xJU1QpCitERUZfRVhUX0xJQl9CVUlMVElO ICAgIChCVUlMVF9JTl9ST1VOREVWRU4sICJyb3VuZGV2ZW4iLCBCVF9GTl9E T1VCTEVfRE9VQkxFLCBBVFRSX0NPTlNUX05PVEhST1dfTEVBRl9MSVNUKQog REVGX0M5OV9DOTBSRVNfQlVJTFRJTiAoQlVJTFRfSU5fQ0VJTEYsICJjZWls ZiIsIEJUX0ZOX0ZMT0FUX0ZMT0FULCBBVFRSX0NPTlNUX05PVEhST1dfTEVB Rl9MSVNUKQogREVGX0M5OV9DOTBSRVNfQlVJTFRJTiAoQlVJTFRfSU5fQ0VJ TEwsICJjZWlsbCIsIEJUX0ZOX0xPTkdET1VCTEVfTE9OR0RPVUJMRSwgQVRU Ul9DT05TVF9OT1RIUk9XX0xFQUZfTElTVCkKICNkZWZpbmUgQ0VJTF9UWVBF KEYpIEJUX0ZOXyMjRiMjXyMjRgpkaWZmIC0tZ2l0IGEvZ2NjL2ludGVybmFs LWZuLmRlZiBiL2djYy9pbnRlcm5hbC1mbi5kZWYKaW5kZXggY2RhMzE0ZTEx MjEuLmI4OTkxODgxNWY5IDEwMDY0NAotLS0gYS9nY2MvaW50ZXJuYWwtZm4u ZGVmCisrKyBiL2djYy9pbnRlcm5hbC1mbi5kZWYKQEAgLTIyNCw2ICsyMjQs NyBAQCBERUZfSU5URVJOQUxfRkxUX0ZMT0FUTl9GTiAoRkxPT1IsIEVDRl9D T05TVCwgZmxvb3IsIHVuYXJ5KQogREVGX0lOVEVSTkFMX0ZMVF9GTE9BVE5f Rk4gKE5FQVJCWUlOVCwgRUNGX0NPTlNULCBuZWFyYnlpbnQsIHVuYXJ5KQog REVGX0lOVEVSTkFMX0ZMVF9GTE9BVE5fRk4gKFJJTlQsIEVDRl9DT05TVCwg cmludCwgdW5hcnkpCiBERUZfSU5URVJOQUxfRkxUX0ZMT0FUTl9GTiAoUk9V TkQsIEVDRl9DT05TVCwgcm91bmQsIHVuYXJ5KQorREVGX0lOVEVSTkFMX0ZM VF9GTE9BVE5fRk4gKFJPVU5ERVZFTiwgRUNGX0NPTlNULCByb3VuZGV2ZW4s IHVuYXJ5KQogREVGX0lOVEVSTkFMX0ZMVF9GTE9BVE5fRk4gKFRSVU5DLCBF Q0ZfQ09OU1QsIGJ0cnVuYywgdW5hcnkpCiAKIC8qIEJpbmFyeSBtYXRoIGZ1 bmN0aW9ucy4gICovCmRpZmYgLS1naXQgYS9nY2Mvb3B0YWJzLmRlZiBiL2dj Yy9vcHRhYnMuZGVmCmluZGV4IDVhNjdmNWVlZDVlLi5lYjllMjJhY2Q4ZiAx MDA2NDQKLS0tIGEvZ2NjL29wdGFicy5kZWYKKysrIGIvZ2NjL29wdGFicy5k ZWYKQEAgLTI2Nyw2ICsyNjcsNyBAQCBPUFRBQl9EIChmbm1zX29wdGFiLCAi Zm5tcyRhNCIpCiAKIE9QVEFCX0QgKHJpbnRfb3B0YWIsICJyaW50JGEyIikK IE9QVEFCX0QgKHJvdW5kX29wdGFiLCAicm91bmQkYTIiKQorT1BUQUJfRCAo cm91bmRldmVuX29wdGFiLCAicm91bmRldmVuJGEyIikKIE9QVEFCX0QgKGZs b29yX29wdGFiLCAiZmxvb3IkYTIiKQogT1BUQUJfRCAoY2VpbF9vcHRhYiwg ImNlaWwkYTIiKQogT1BUQUJfRCAoYnRydW5jX29wdGFiLCAiYnRydW5jJGEy IikKZGlmZiAtLWdpdCBhL2djYy9yZWFsLmMgYi9nY2MvcmVhbC5jCmluZGV4 IGY4MjJhZTgyZDYxLi45YzU3ZjUwZThmYyAxMDA2NDQKLS0tIGEvZ2NjL3Jl YWwuYworKysgYi9nY2MvcmVhbC5jCkBAIC01MDA0LDEwICs1MDA2LDM5IEBA IHZvaWQKKy8qIFJvdW5kIFggdG8gbmVhcmVzdCBldmVuIGludGVnZXIgdG93 YXJkcyB6ZXJvLiAqLworCit2b2lkCityZWFsX3JvdW5kZXZlbiAoUkVBTF9W QUxVRV9UWVBFICpyLCBmb3JtYXRfaGVscGVyIGZtdCwKKwkJY29uc3QgUkVB TF9WQUxVRV9UWVBFICp4KQoreworICBSRUFMX1ZBTFVFX1RZUEUgdDsKKwor ICBkb19maXhfdHJ1bmMgKCZ0LCB4KTsKKyAgSE9TVF9XSURFX0lOVCBpID0g cmVhbF90b19pbnRlZ2VyICgmdCk7CisgIGZwcmludGYgKHN0ZGVyciwgIlxu aGVyZVxuIik7CisgIGZwcmludGYgKHN0ZGVyciwgIlxuIGkgPSAlbGRcbiIs IGkpOworICBpZihpICUgMikKKyAgICBkb19hZGQgKHIsICZ0LCAmZGNvbnN0 bTEsIDApOworICBlbHNlCisgICAgKnIgPSB0OwogfQogCiAvKiBTZXQgdGhl IHNpZ24gb2YgUiB0byB0aGUgc2lnbiBvZiBYLiAgKi8KZGlmZiAtLWdpdCBh L2djYy9yZWFsLmggYi9nY2MvcmVhbC5oCmluZGV4IDBjZTQyNTY1NzA4Li4x MDg5OGVhZTc5ZSAxMDA2NDQKLS0tIGEvZ2NjL3JlYWwuaAorKysgYi9nY2Mv cmVhbC5oCkBAIC00OTksNiArNDk5LDggQEAgZXh0ZXJuIHZvaWQgcmVhbF9j ZWlsIChSRUFMX1ZBTFVFX1RZUEUgKiwgZm9ybWF0X2hlbHBlciwKIAkJICAg ICAgIGNvbnN0IFJFQUxfVkFMVUVfVFlQRSAqKTsKIGV4dGVybiB2b2lkIHJl YWxfcm91bmQgKFJFQUxfVkFMVUVfVFlQRSAqLCBmb3JtYXRfaGVscGVyLAog CQkJY29uc3QgUkVBTF9WQUxVRV9UWVBFICopOworZXh0ZXJuIHZvaWQgcmVh bF9yb3VuZGV2ZW4gKFJFQUxfVkFMVUVfVFlQRSAqLCBmb3JtYXRfaGVscGVy LAorICAgICAgY29uc3QgUkVBTF9WQUxVRV9UWVBFICopOwogCiAvKiBTZXQg dGhlIHNpZ24gb2YgUiB0byB0aGUgc2lnbiBvZiBYLiAgKi8KIGV4dGVybiB2 b2lkIHJlYWxfY29weXNpZ24gKFJFQUxfVkFMVUVfVFlQRSAqLCBjb25zdCBS RUFMX1ZBTFVFX1RZUEUgKik7CgogCg== --00000000000071d5930581138aeb--