From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id D944D385801B for ; Mon, 22 Nov 2021 19:02:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D944D385801B Received: by mail-oi1-x233.google.com with SMTP id r26so39722810oiw.5 for ; Mon, 22 Nov 2021 11:02:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/NK1jOBd1lNhCjx0/Zmi8PIRu67e1RPI5M4nzAL6O9E=; b=SA9Nol6Up3Gu0XD+bXXdlacRGMNTtjhpqbxrXO1ft1AcrYvdKyg9veNMPV0WN7mtYQ IWwYd4zKBCQp67F4ur1ahJ4jPHuckTlnhnGnJiOwRk42x/OyhDHK3yaojWa4OIqpkOiw B4+wTSqeIfw3OhWZDX3XRuHS7y9yoBt4urvC6EWjymTGaQSTms2neYRR59SP5k9E44E9 tsvjMfHhlOMk8NxUDU3T7s9LhgdVTGU7cj1YZUaI09R4lXawHNnGfQUQBhCdjZ/kzmel vCUiBz78sNjm2qNwh0p+Tz31U4z1XrfQ6lb/V71oAMMt9H/AIyyBWQoj4siVyNsG4Z9G PH7w== X-Gm-Message-State: AOAM533956GzJ/aaXvdTDSwOrJwSEa7vi2cKYJkLt3PwvSVI6PAfC5ns nrMu2Y995mY5mcVut3EFpiw8AbXSpYYTxuXYLRwOmA== X-Google-Smtp-Source: ABdhPJzc2zD5AH1QXbJiSOpivzn94tBeMDza3jv3vtcoRw2BOIOkSc5URIa/Xf+CBqBqzwnWR2HZ2bkkyB00vsKqkQc= X-Received: by 2002:aca:b843:: with SMTP id i64mr2540670oif.109.1637607725057; Mon, 22 Nov 2021 11:02:05 -0800 (PST) MIME-Version: 1.0 References: <7506afec-035a-bf4f-1dd7-f022423f4627@suse.cz> In-Reply-To: <7506afec-035a-bf4f-1dd7-f022423f4627@suse.cz> From: Dmitry Vyukov Date: Mon, 22 Nov 2021 20:01:53 +0100 Message-ID: Subject: Re: New ThreadSanitizer runtime (v3) To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: gcc , ro@gcc.gnu.org, Jakub Jelinek , =?UTF-8?Q?Martin_Li=C5=A1ka?= , Marco Elver , Alexander Potapenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 19:02:07 -0000 On Mon, 22 Nov 2021 at 19:38, Martin Li=C5=A1ka wrote: > > On 11/22/21 16:22, Dmitry Vyukov wrote: > > I wanted to give heads up regarding a significant re-design of the > > ThreadSanitizer runtime: > > https://reviews.llvm.org/D112603 > > Currently it's submitted: > > https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced06= 0a9bf9d232027 > > And I noticed the following new warnings: > > libsanitizer/tsan/tsan_shadow.h:93:32: warning: enumerated and non-enumer= ated type in conditional expression [-Wextra] > libsanitizer/tsan/tsan_shadow.h:94:44: warning: enumerated and non-enumer= ated type in conditional expression [-Wextra] > > *typ =3D (part_.is_read_ ? kAccessRead : kAccessWrite) | > (part_.is_atomic_ ? kAccessAtomic : 0) | > (part_.access_ =3D=3D kFreeAccess ? kAccessFree : 0); > > I think 0 should be replaced with kAccessWrite, am I right? Should I crea= te a pull request for it? I've already reverted the change. So I will include a fix into the next ver= sion. Thanks for notifying.