From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 0D99C3858401 for ; Thu, 18 Apr 2024 18:29:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D99C3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D99C3858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713464961; cv=none; b=CNT0hoD8B6jnUoX0KzH3okjAoyRuFL/hTW5frfLJaMQ2IC7F+AXy0Dk37miC4K+3R6z2c7Fbf9LFYx9Bp5UMTj4uWsjNZ7+zA4Ifi6wXBLlz8Bfst82m2Mt/n/Jt+Cr/Syxw7PzSBFToyOwT4akSGnNWVkPBT8YvgAOyT8yhx3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713464961; c=relaxed/simple; bh=IhMfPsNdo3Konq2CmXOwe/URJrsKLL5bl1PXZ53fXEg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=VLjQr3IK9Apt+OkVeE1xxsXOs64ZzAafN/rVLsTlPuP46khLXS+4ziUrXMFIgQCQaOqg6KRhA/Vfcjr37yclfdrLdczEMamlOOyjoLBSZ2pMEW4uLlDxjjjWJv803RsGi9LO+V0zj2qb0F88u8YtHLuNnhCSsPuKknutIL2OzRI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6ead4093f85so1197958b3a.3 for ; Thu, 18 Apr 2024 11:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713464959; x=1714069759; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=phuiDFO+ureHKjrd9BQ/l3bIaZQsYC/5JHgKYW3xG74=; b=Wn8Eb+5vXqCCpz+Kb/zlmmW03VbDifBr1fMCdotoSWCxDwpVTebHQ9bLzO5gH8Ln3s 7vH6usUTPQZzYxzKll2Y0C5B4uhlQzgigHtRq06x3uGIGJrDIZ/0mrapNJg0ZMfn06ov 4J7xjATKBTjFvw/7h3hXIwkL4qsD2p6dvWJ3sHnuyOYRZBKrBl65anoyFK1F2rHFePMn Qpj3M4tFv/4sLlK3bKvindU4pz7ea5ULU+mNIhJm5cIe7w2iaPPruhFP0VhhQhY3Enih i0BIiQhgjM7+sCnGGg3QZaR4uqgeAWRdoMWQU/RxNG0ihfl3X9XVKuuXJF39U72f3ZEn wlGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713464959; x=1714069759; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=phuiDFO+ureHKjrd9BQ/l3bIaZQsYC/5JHgKYW3xG74=; b=q9tiW9GfmKTJtyTYNdFw5FM+ED4O1MNCjI1IgD0a2qWUH3hervQ54pyF6WXENRJTgr VrgRpcyitVpIlAafFkWLsRPzycpxiWQHoZt4voYxDNRBNJyMkZtwUNQbuggAck9rsVuZ 1StpA04NNeee9pmKCQKf9PHlvpC662vY0eh540RV5lZDpPlpvhhAlLmJHrFtaV5LYZrN 6jh9PMgmr+/MV5nQtdFn1lWmt0ro6pwfdI2eZnivxp1v9mx/HZiNB3PCqMMksN8iiUkB KcINaUx3tzK0qeJW9TMLe8gO/rXueRJR2zVw5DkW6RI367qx2P0+rT/5zUBSP1q4CD8+ k9NA== X-Forwarded-Encrypted: i=1; AJvYcCVG+C5dk5qFKKpDpYAwLuQNwXsaVhPhV9o7aM/2+ulE3/N/XsxK6zOdFiTer/VwwGS9koJuccNJf8wkyXiXzKs= X-Gm-Message-State: AOJu0YxwtMvtGX8pdX8voMqnak+Y3DSBcxXNQRwVeJ1vdrs3O1WnpcJw O1xgA/4TulHSet9YLaQfz9HTsASn9O+uAZ0edbQHkInKfR7MrczRLY7J+N7stBg8ez3z2Uw5Ddk b2Q9k85VbvM2HUFd7BpgzBS2z+6o= X-Google-Smtp-Source: AGHT+IGJRiqqxdhZ5X5o/Kzue3xSwIhjsID7ecpo4IqezGu4IhZo84fPYsOYjmuULZvPAY/UO7cBwsoHRWEin0+Yric= X-Received: by 2002:a05:6a20:5651:b0:1a9:90e0:4760 with SMTP id is17-20020a056a20565100b001a990e04760mr12695pzc.56.1713464958898; Thu, 18 Apr 2024 11:29:18 -0700 (PDT) MIME-Version: 1.0 References: <20240417232725.GC25080@gnu.wildebeest.org> <20240418173726.GD9069@redhat.com> In-Reply-To: <20240418173726.GD9069@redhat.com> From: Matt Rice Date: Thu, 18 Apr 2024 18:29:07 +0000 Message-ID: Subject: Re: Updated Sourceware infrastructure plans To: "Frank Ch. Eigler" Cc: Overseers mailing list , Mark Wielaard , Joseph Myers , gcc@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org, libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 18, 2024 at 5:38=E2=80=AFPM Frank Ch. Eigler = wrote: > > Hi - > > > [...] I suggest that a basic principle for such a system is that it > > should be *easy* to obtain and maintain a local copy of the history > > of all pull requests. That includes all versions of a pull request, > > if it gets rebased, and all versions of comments, if the system > > allows editing comments. A system that uses git as the source of > > truth for all the pull request data and has refs [...] > > Do you know of a system with these characteristics? > > - FChE The closest thing I know of which may have these characteristics is alibaba's AGit-Flow described here: https://git-repo.info/en/2020/03/agit-flow-and-git-repo/ It actually sends pull-requests through the git protocol using a custom proc-receive hook. I'm a bit uncertain how code-review comments are handled in their system, And it isn't exactly something which can just be used off-the-shelf, AFAIK their server side implementation hasn't been released. I had written a prototype-worthy implementation of the server-side git hook here. It basically allows sending a pull-request through git push, along with a cover letter. But i've never really used it in the full PR review cycle beyond that. https://github.com/pullreqr/pullreqr_githook But protocol-wise IMO it seems like a good basis for building a system with these characteristics to me.