From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id AB4A83855004 for ; Fri, 11 Jun 2021 17:02:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB4A83855004 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-2c0LK0PwNimSpTSlHJmBhQ-1; Fri, 11 Jun 2021 13:02:31 -0400 X-MC-Unique: 2c0LK0PwNimSpTSlHJmBhQ-1 Received: by mail-wr1-f71.google.com with SMTP id q15-20020adfc50f0000b0290111f48b865cso2915279wrf.4 for ; Fri, 11 Jun 2021 10:02:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QfDhfIgy9XpMEzntOhffSOnfG2g641oJ7OJjdXWYpio=; b=WEAGSKDKugYD4rlEAP9jT+K/NNrWbIITkm0rR2QkhlvzBBmfZeZclXsiXI39iQT3PX BuhbS0+ZSzula/V2WHVv0N+Nwjapw2eRQe7va9uRHqeV5hY4X6B9EC2vgb23UCoJ9wsX l/vQfDS4pPI4TzHdw5P21P0LyXxXwJkuRG2nDXtQ+ttwiJJwk8Rx5i+eJKbomGVxtvoD bh22m05cBPY19PVia45qGTy92NJejWDO08cXTMN30gFztzySYrZEhOm4/BlqkiuxylNC y0/6oMALtwfQwJbHGylFz2oFRqaaZ+SCyllmlTdJojey7PZd4lnCshvkVPTKdS171f4w VU8A== X-Gm-Message-State: AOAM5321B70KGJePDlq3lDY0V+lhonzcHVTCd5oDGNA45rAG+3yIoER7 vEn3LrT6k3ykgcePppwCjgNVwGcUxBOg6/4iF8OlcjKQCabDxm7UaeLMaoTgOBrqKeC6KdI5PnS sk/brsZYUkYcwbc8JWG/+cAw= X-Received: by 2002:adf:eed2:: with SMTP id a18mr5158799wrp.147.1623430950113; Fri, 11 Jun 2021 10:02:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytECFEE9DRJYGTmGGAcxSmDZ96ioYWc61GpHAs/T3AJzz4vzCoRpx8t4LtluOvIm5vDHS1OqTXQmSXOrEuWnA= X-Received: by 2002:adf:eed2:: with SMTP id a18mr5158777wrp.147.1623430949901; Fri, 11 Jun 2021 10:02:29 -0700 (PDT) MIME-Version: 1.0 References: <36a4f5c4-357a-ca1c-e7f5-ede6ff3ba445@suse.cz> <20210610100851.GD7746@tucnak> <1230cb99-ed83-3e4e-8362-94f03ee021bc@gmail.com> <3228435b-aba0-6157-3266-c0f025822829@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 11 Jun 2021 18:02:18 +0100 Message-ID: Subject: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog To: Joseph Myers Cc: Martin Sebor , Jakub Jelinek , gcc@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 17:02:34 -0000 On Fri, 11 Jun 2021 at 16:45, Joseph Myers wrote: > > On Fri, 11 Jun 2021, Jonathan Wakely via Gcc wrote: > > > If you're not already doing a brief "subject" line in your git > > commits, you're Doing It Wrong! > > If you don't have a subject line which is more than one word, and does not > look like a ChangeLog header line, and which is followed by a blank line, > the commit hooks will reject the commit when you try to push it to the GCC > repository. (The check for a blank line after the subject is a generic > feature of the hooks, the checks for single-word subjects and those that > look like ChangeLog headers are part of the local commit_checker hook.) Oh good! All the more reason to document that format in codingconventions.html then.