From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 295F33858439 for ; Thu, 30 Mar 2023 12:23:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 295F33858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680179031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q19b+vGKwO5e+12jG3MaGolYqJOzF3BtE8IfAM/QS/U=; b=KCIPZ5kN9gNBO3fKZ8rtV1+jEzYsbf6mvkLpbLXP3VKsRYfM7jXco5a5A7cZS9OTohFxn8 ABgviltgaAvfzMz5i/q76WK82H051r4TPTFhNfG6M0uNAcSB7b8LKbuKJ5S1E377X1+jYD eVxlQtnA2kYlPYWx+nEIEBtoKWM5udM= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-HAKxJyFbNTSGGTGtFUpxqA-1; Thu, 30 Mar 2023 08:23:50 -0400 X-MC-Unique: HAKxJyFbNTSGGTGtFUpxqA-1 Received: by mail-lf1-f71.google.com with SMTP id b6-20020a196446000000b004eaf4c3bceeso7432457lfj.20 for ; Thu, 30 Mar 2023 05:23:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680179029; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q19b+vGKwO5e+12jG3MaGolYqJOzF3BtE8IfAM/QS/U=; b=rlpk/1aBj89L1W6PI0WqGlJzYLEjMnoDDYgREZEjzDU+l/df2LX7f6wQBEAZ4+tCfV A+KALFyDdmJvFISq4+mBxNP3WdCNlT1770SxJCWCtnedvpXVg3a9Q0ZHOTov8oEnzzwU MwIHs4aolzd1g9fv05NxUifrOzBctq/k5Tf93LNHTRsHS4REi5O8fq5CuVYRjxcgS2Kb fn6XPsNXtNEAkmHHHePZFJ8wwTI7xvlwDnPsn7RTYXwmgJHwJ27zdMik0svDydylrqRW HM06b19m6GAaJM6UPF8Cg2sUDf4P9UrUHPXX4Qt0/BQ2pgp7tz1Hk57zLzmnZNnElrzD srkA== X-Gm-Message-State: AAQBX9fWWpGYkYG17t0dgiwr9SGBwdMW5mZMlR5I2dac4DG/XhFadjop gL4OlxXAyb8MC4EmsK8pofbUaGqY3c1+iwSgdDYSzUP4J6v8wqGtrjSVNeqeWWS7iqpiHLufI3S ceSk0T675os20FpbNXeWodgw= X-Received: by 2002:ac2:514e:0:b0:4e8:dcb2:b2ea with SMTP id q14-20020ac2514e000000b004e8dcb2b2eamr6857443lfd.8.1680179029238; Thu, 30 Mar 2023 05:23:49 -0700 (PDT) X-Google-Smtp-Source: AKy350bs0ghI/TvBus3fyoH7CXGC0UcaLY+wHgL5M8dfFgxn4Fu9wsaNghYGbhhWpanZqsqTD9vU8L49XSklaFfgFrM= X-Received: by 2002:ac2:514e:0:b0:4e8:dcb2:b2ea with SMTP id q14-20020ac2514e000000b004e8dcb2b2eamr6857439lfd.8.1680179028969; Thu, 30 Mar 2023 05:23:48 -0700 (PDT) MIME-Version: 1.0 References: <7f83711f-5094-6c6d-822b-966293062afc@inria.fr> <32c3f04d-2196-5c3d-0176-f807b1744720@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 30 Mar 2023 13:23:37 +0100 Message-ID: Subject: Re: [GSoC] Conflicted Built-in Trait Name To: Ken Matsui Cc: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= , libstdc++@gcc.gnu.org, gcc@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 30 Mar 2023 at 09:33, Ken Matsui wrote: > > Hi Fran=C3=A7ois, > > On Wed, Mar 29, 2023 at 10:11=E2=80=AFPM Fran=C3=A7ois Dumont wrote: > > > > Hi > > > > Do not hesitate to dig into library doc. Especially this page: > > > > https://gcc.gnu.org/onlinedocs/gcc-8.1.0/libstdc++/manual/manual/test.h= tml > > > > You can also find it in your git clone in /libstdc++-v3/doc/h= tml. > > > > You'll see also how to run test in different std modes like --std=3Dc++= 98 > > to catch the kind of issue reported by Jonathan. > > This is what I wanted to know! Thank you so much! > > > Regarding your patches I wonder if it's not too splitted. 1 patch per > > builtin would sound more logical, at least for an easy one like __is_vo= id. > > I see. I will squash is_void-related commits into the commit of > __is_void implementation. Thank you for pointing it out! Yes, good point, Fran=C3=A7ois. These kind of changes for the front-end and library should be in one patch. Otherwise, if they were committed separately then you would create a revision where bootstrap fails. If the front-end change is committed without the library change, then you can't build the library because it still uses __is_void which is now a keyword. If the library change is committed first then you don't break bootstrap, but you're adding support to the library for a new built-in which doesn't actually exist (yet). They should be a single revision, so that the tree can always be built.